Програмиране с Ruby

Курс във Факултета по Математика и Информатика към СУ

Решение на Четвърта задача от Илия Ячев

Обратно към всички решения

Към профила на Илия Ячев

Резултати

  • 2 точки от тестове
  • 0 бонус точки
  • 2 точки общо
  • 16 успешни тест(а)
  • 25 неуспешни тест(а)

Код

class PrivacyFilter
attr_accessor :preserve_phone_country_code
attr_accessor :preserve_email_hostname
attr_accessor :partially_preserve_email_username
attr_reader :text
def initialize(text)
@text = text
end
def filtered
filter_emails.filter_phone_numbers.text
end
def filter_phone_numbers
tap do
@text = @text.gsub(/(?<![[:alnum:]+])0([_ ()]{,2}\d){6,11}/n, '[PHONE]')
@text = @text.gsub(/((00|\+)[1-9]\d{,2})([_ ()]{,2}\d){6,11}/n, '\1 [FILTERED]') if @preserve_phone_country_code
end
end
def filter_emails
tap do
if @partially_preserve_email_username then filter_emails_partially_preserving_username
else filter_emails_without_preserving_username
end
end
end
private
def email_validation_regex
/([[:alnum:]][[:alnum:]_+.-]{,200})\@([[:alnum:]](([[:alnum:]-]{,60}[[:alnum:]])?\.)+[a-zA-Z]{2,3})/n
end
def filter_emails_partially_preserving_username
@text = @text.gsub(email_validation_regex) { ($1.size > 6 ? $1[0..2] : '') + '[FILTERED]@' + $2 }
end
def filter_emails_without_preserving_username
if @preserve_email_hostname
@text = @text.gsub(email_validation_regex, '[FILTERED]@\2')
else
@text = @text.gsub(email_validation_regex, '[EMAIL]')
end
end
end
class Validations
class << self
def email?(value)
/[[:alnum:]][[:alnum:]_+.-]{0,200}@(.*)/n === value and hostname? $1
end
def hostname?(value)
/(?:([[:alnum:]][[:alnum:]-]{,60}[[:alnum:]])?\.)+([a-zA-Z]{2,3})/n === value
end
def phone?(value)
/(?<pre>(?<![[:alnum:]+])0|(?:00|\+)[1-9]\d{,2})(?<main>[_ ()]{,2}\d){6,11}/n === value
end
def ip_address?(value)
/(?<bit>\d|[1-9]\d|1\d\d|2[1-4]\d|25[0-5])(?:\.\g<bit>){3}/ === value
end
def number?(value)
/-?(0|[1-9]\d*)\.?\d+/ === value
end
def integer?(value)
/-?(0|[1-9]\d*)/ === value
end
def date?(value)
/(\d{4})-(0\d|1[0-2])-([0-2]\d|3[01])/ === value
end
def time?(value)
/([0-1]\d|2[0-4])(:[0-5]\d){2}/ === value
end
def date_time?(value)
/([0-9-]+)(?: |T)([0-9:]+)/ === value and date? $1 and time? $2
end
end
end

Лог от изпълнението

/tmp/d2.FFFFFF..FF.FFFFFFFFF.FF...F.F.FFF

Failures:

  1) PrivacyFilter does not filter invalid emails
     Failure/Error: filter(text_with_invalid_emails).should eq text_with_invalid_emails
       
       expected: "Contact me here: _invalid@email.com"
            got: "Contact me here: _[EMAIL]"
       
       (compared using ==)
     # /tmp/d20130203-23049-x7nfxn/spec.rb:52:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-x7nfxn/spec.rb:46:in `each'
     # /tmp/d20130203-23049-x7nfxn/spec.rb:46:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  2) PrivacyFilter filters more complex phone numbers
     Failure/Error: filter(text).should eq filtered
       
       expected: "[PHONE]"
            got: "+155512345699"
       
       (compared using ==)
     # /tmp/d20130203-23049-x7nfxn/spec.rb:85:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-x7nfxn/spec.rb:84:in `each'
     # /tmp/d20130203-23049-x7nfxn/spec.rb:84:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  3) PrivacyFilter does not filter invalid phone numbers
     Failure/Error: filter(text).should eq filtered
       
       expected: "Reach me at: 0885123"
            got: "Reach me at: [PHONE]"
       
       (compared using ==)
     # /tmp/d20130203-23049-x7nfxn/spec.rb:96:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-x7nfxn/spec.rb:95:in `each'
     # /tmp/d20130203-23049-x7nfxn/spec.rb:95:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  4) PrivacyFilter preserves whitespace around phones
     Failure/Error: filter(' +359881212-12-1 2 or...').should eq ' [PHONE] or...'
       
       expected: " [PHONE] or..."
            got: " +359881212-12-1 2 or..."
       
       (compared using ==)
     # /tmp/d20130203-23049-x7nfxn/spec.rb:101:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  5) PrivacyFilter filters more than one phone or email
     Failure/Error: filter(text).should eq filtered
       
       expected: "\n      Contacts\n\n      Phones: [PHONE] or [PHONE]\n      Email: [EMAIL] or [EMAIL]\n    "
            got: "\n      Contacts\n\n      Phones: +1 (555) 123-456-99 or [PHONE]\n      Email: [EMAIL] or [EMAIL]\n    "
       
       (compared using ==)
       
       Diff:
       @@ -1,7 +1,7 @@
        
              Contacts
        
       -      Phones: [PHONE] or [PHONE]
       +      Phones: +1 (555) 123-456-99 or [PHONE]
              Email: [EMAIL] or [EMAIL]
            
     # /tmp/d20130203-23049-x7nfxn/spec.rb:119:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  6) PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
     Failure/Error: filter.filtered.should eq filtered
       
       expected: "Phone: +359 [FILTERED]"
            got: "Phone: +3 [FILTERED]-1212"
       
       (compared using ==)
     # /tmp/d20130203-23049-x7nfxn/spec.rb:132:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-x7nfxn/spec.rb:129:in `each'
     # /tmp/d20130203-23049-x7nfxn/spec.rb:129:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  7) PrivacyFilter separates preserved country code from filtered phone with a space
     Failure/Error: filter.filtered.should eq filtered
       
       expected: "Phone: 0025 [FILTERED]"
            got: "Phone: [PHONE]5"
       
       (compared using ==)
     # /tmp/d20130203-23049-x7nfxn/spec.rb:144:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-x7nfxn/spec.rb:141:in `each'
     # /tmp/d20130203-23049-x7nfxn/spec.rb:141:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  8) Validations can validate more complex emails
     Failure/Error: Validations.email?(email).should be(valid)
       
       expected #<FalseClass:0> => false
            got #<TrueClass:2> => true
       
       Compared using equal?, which compares object identity,
       but expected and actual are not the same object. Use
       'actual.should eq(expected)' if you don't care about
       object identity in this example.
     # /tmp/d20130203-23049-x7nfxn/spec.rb:171:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-x7nfxn/spec.rb:170:in `each'
     # /tmp/d20130203-23049-x7nfxn/spec.rb:170:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  9) Validations does not break on emails in multiline strings
     Failure/Error: Validations.email?("foo@bar.com\nwat?").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-x7nfxn/spec.rb:176:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  10) Validations can validate more complex phone numbers
     Failure/Error: Validations.phone?(phone).should be(valid)
       
       expected #<FalseClass:0> => false
            got #<TrueClass:2> => true
       
       Compared using equal?, which compares object identity,
       but expected and actual are not the same object. Use
       'actual.should eq(expected)' if you don't care about
       object identity in this example.
     # /tmp/d20130203-23049-x7nfxn/spec.rb:210:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-x7nfxn/spec.rb:209:in `each'
     # /tmp/d20130203-23049-x7nfxn/spec.rb:209:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  11) Validations does not break on phones in multiline strings
     Failure/Error: Validations.phone?("0885123123\nwat?").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-x7nfxn/spec.rb:215:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  12) Validations validates hostnames
     Failure/Error: Validations.hostname?('not-a-hostname-.com').should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-x7nfxn/spec.rb:227:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  13) Validations handles multiline strings in hostname validation properly
     Failure/Error: Validations.hostname?("foo.com\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-x7nfxn/spec.rb:233:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  14) Validations validates IP addresses
     Failure/Error: Validations.ip_address?('300.2.3.4').should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-x7nfxn/spec.rb:239:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  15) Validations handles multiline strings in IP validation properly
     Failure/Error: Validations.ip_address?("8.8.8.8\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-x7nfxn/spec.rb:245:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  16) Validations validates numbers
     Failure/Error: Validations.number?('9').should be_true
       expected: true value
            got: false
     # /tmp/d20130203-23049-x7nfxn/spec.rb:254:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  17) Validations validates more complex numbers
     Failure/Error: Validations.number?(' 42 ').should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-x7nfxn/spec.rb:258:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  18) Validations handles multiline strings in numbers validation properly
     Failure/Error: Validations.number?("42\n24").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-x7nfxn/spec.rb:274:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  19) Validations validates more complex integers
     Failure/Error: Validations.integer?(' 42 ').should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-x7nfxn/spec.rb:284:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  20) Validations handles multiline strings in integer validation properly
     Failure/Error: Validations.number?("42\n24").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-x7nfxn/spec.rb:295:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  21) Validations does not allow zero months or days in dates
     Failure/Error: Validations.date?('1000-00-01').should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-x7nfxn/spec.rb:315:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  22) Validations handles newlines in date validation
     Failure/Error: Validations.date?("2012-11-19\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-x7nfxn/spec.rb:327:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  23) Validations does not allow invalid hours, minutes or seconds
     Failure/Error: Validations.time?('24:00:00').should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-x7nfxn/spec.rb:340:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  24) Validations validates datetime values
     Failure/Error: Validations.date_time?('2012-00-19T23:59:00').should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-x7nfxn/spec.rb:352:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  25) Validations handles newlines in time and datetime validation
     Failure/Error: Validations.time?("12:01:01\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-x7nfxn/spec.rb:360:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

Finished in 0.04978 seconds
41 examples, 25 failures

Failed examples:

rspec /tmp/d20130203-23049-x7nfxn/spec.rb:44 # PrivacyFilter does not filter invalid emails
rspec /tmp/d20130203-23049-x7nfxn/spec.rb:76 # PrivacyFilter filters more complex phone numbers
rspec /tmp/d20130203-23049-x7nfxn/spec.rb:89 # PrivacyFilter does not filter invalid phone numbers
rspec /tmp/d20130203-23049-x7nfxn/spec.rb:100 # PrivacyFilter preserves whitespace around phones
rspec /tmp/d20130203-23049-x7nfxn/spec.rb:104 # PrivacyFilter filters more than one phone or email
rspec /tmp/d20130203-23049-x7nfxn/spec.rb:122 # PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
rspec /tmp/d20130203-23049-x7nfxn/spec.rb:136 # PrivacyFilter separates preserved country code from filtered phone with a space
rspec /tmp/d20130203-23049-x7nfxn/spec.rb:160 # Validations can validate more complex emails
rspec /tmp/d20130203-23049-x7nfxn/spec.rb:175 # Validations does not break on emails in multiline strings
rspec /tmp/d20130203-23049-x7nfxn/spec.rb:184 # Validations can validate more complex phone numbers
rspec /tmp/d20130203-23049-x7nfxn/spec.rb:214 # Validations does not break on phones in multiline strings
rspec /tmp/d20130203-23049-x7nfxn/spec.rb:218 # Validations validates hostnames
rspec /tmp/d20130203-23049-x7nfxn/spec.rb:232 # Validations handles multiline strings in hostname validation properly
rspec /tmp/d20130203-23049-x7nfxn/spec.rb:237 # Validations validates IP addresses
rspec /tmp/d20130203-23049-x7nfxn/spec.rb:244 # Validations handles multiline strings in IP validation properly
rspec /tmp/d20130203-23049-x7nfxn/spec.rb:250 # Validations validates numbers
rspec /tmp/d20130203-23049-x7nfxn/spec.rb:257 # Validations validates more complex numbers
rspec /tmp/d20130203-23049-x7nfxn/spec.rb:273 # Validations handles multiline strings in numbers validation properly
rspec /tmp/d20130203-23049-x7nfxn/spec.rb:283 # Validations validates more complex integers
rspec /tmp/d20130203-23049-x7nfxn/spec.rb:294 # Validations handles multiline strings in integer validation properly
rspec /tmp/d20130203-23049-x7nfxn/spec.rb:314 # Validations does not allow zero months or days in dates
rspec /tmp/d20130203-23049-x7nfxn/spec.rb:326 # Validations handles newlines in date validation
rspec /tmp/d20130203-23049-x7nfxn/spec.rb:339 # Validations does not allow invalid hours, minutes or seconds
rspec /tmp/d20130203-23049-x7nfxn/spec.rb:347 # Validations validates datetime values
rspec /tmp/d20130203-23049-x7nfxn/spec.rb:359 # Validations handles newlines in time and datetime validation

История (2 версии и 1 коментар)

Илия обнови решението на 26.11.2012 02:29 (преди над 11 години)

+
+class PrivacyFilter
+ attr_accessor :preserve_phone_country_code
+ attr_accessor :preserve_email_hostname
+ attr_accessor :partially_preserve_email_username
+ attr_reader :text
+
+ def initialize(text)
+ @text = text
+ end
+
+ def filtered
+ filtered_emails.filtered_phone_numbers.text
+ end
+
+ def filtered_emails
+ tap { @text = filter_emails(@text) }
+ end
+
+ def filtered_phone_numbers
+ tap do
+ @text = @text.gsub(/(?<![[:alnum:]+])0([_ ()]{,2}\d){6,11}/n, '[PHONE]')
+ @text = @text.gsub(/((00|\+)[1-9]\d{,2})([_ ()]{,2}\d){6,11}/n, '\1 [FILTERED]') if @preserve_phone_country_code
+ end
+ end
+
+ private
+ def filter_emails(filter_text)
+ if @partially_preserve_email_username
+ filter_emails_partially_preserving_username(filter_text)
+ else
+ filter_emails_without_preserving_username(filter_text)
+ end
+ end
+
+ def email_validation_regex
+ /([[:alnum:]][[:alnum:]_+.-]{,200})\@([[:alnum:]](([[:alnum:]-]{,60}[[:alnum:]])?\.)+[a-zA-Z]{2,3})/n
+ end
+
+ def filter_emails_partially_preserving_username(filter_text)
+ filter_text.gsub(email_validation_regex) { ($1.size > 6 ? $1[0..2] : '') + '[FILTERED]@' + $2 }
+ end
+
+ def filter_emails_without_preserving_username(filter_text)
+ if @preserve_email_hostname
+ filter_text.gsub(email_validation_regex, '[FILTERED]@\2')
+ else
+ filter_text.gsub(email_validation_regex, '[EMAIL]')
+ end
+ end
+end
+
+class Validations
+ class << self
+ def email?(value)
+ /[[:alnum:]][[:alnum:]_+.-]{0,200}@(.*)/n === value and hostname? $1
+ end
+
+ def hostname?(value)
+ /(?:([[:alnum:]][[:alnum:]-]{,60}[[:alnum:]])?\.)+([a-zA-Z]{2,3})/n === value
+ end
+
+ def phone?(value)
+ /(?<pre>(?<![[:alnum:]+])0|(?:00|\+)[1-9]\d{,2})(?<main>[_ ()]{,2}\d){6,11}/n === value
+ end
+
+ def ip_address?(value)
+ /(?<bit>\d|[1-9]\d|1\d\d|2[1-4]\d|25[0-5])(?:\.\g<bit>){3}/ === value
+ end
+
+ def number?(value)
+ /-?(0|[1-9]\d*)\.?\d+/ === value
+ end
+
+ def integer?(value)
+ /-?(0|[1-9]\d*)/ === value
+ end
+
+ def date?(value)
+ /(\d{4})-(0\d|1[0-2])-([0-2]\d|3[01])/ === value
+ end
+
+ def time?(value)
+ /([0-1]\d|2[0-4])(:[0-5]\d){2}/ === value
+ end
+
+ def date_time?(value)
+ /([0-9-]+)(?: |T)([0-9:]+)/ === value and date? $1 and time? $2
+ end
+ end
+end

Илия обнови решението на 28.11.2012 01:30 (преди над 11 години)

class PrivacyFilter
attr_accessor :preserve_phone_country_code
attr_accessor :preserve_email_hostname
attr_accessor :partially_preserve_email_username
attr_reader :text
def initialize(text)
@text = text
end
def filtered
- filtered_emails.filtered_phone_numbers.text
+ filter_emails.filter_phone_numbers.text
end
- def filtered_emails
- tap { @text = filter_emails(@text) }
- end
-
- def filtered_phone_numbers
+ def filter_phone_numbers
tap do
@text = @text.gsub(/(?<![[:alnum:]+])0([_ ()]{,2}\d){6,11}/n, '[PHONE]')
@text = @text.gsub(/((00|\+)[1-9]\d{,2})([_ ()]{,2}\d){6,11}/n, '\1 [FILTERED]') if @preserve_phone_country_code
end
end
- private
- def filter_emails(filter_text)
- if @partially_preserve_email_username
- filter_emails_partially_preserving_username(filter_text)
- else
- filter_emails_without_preserving_username(filter_text)
+ def filter_emails
+ tap do
+ if @partially_preserve_email_username then filter_emails_partially_preserving_username
+ else filter_emails_without_preserving_username
+ end
end
end
+ private
def email_validation_regex
/([[:alnum:]][[:alnum:]_+.-]{,200})\@([[:alnum:]](([[:alnum:]-]{,60}[[:alnum:]])?\.)+[a-zA-Z]{2,3})/n
end
- def filter_emails_partially_preserving_username(filter_text)
- filter_text.gsub(email_validation_regex) { ($1.size > 6 ? $1[0..2] : '') + '[FILTERED]@' + $2 }
+ def filter_emails_partially_preserving_username
+ @text = @text.gsub(email_validation_regex) { ($1.size > 6 ? $1[0..2] : '') + '[FILTERED]@' + $2 }
end
- def filter_emails_without_preserving_username(filter_text)
+ def filter_emails_without_preserving_username
if @preserve_email_hostname
- filter_text.gsub(email_validation_regex, '[FILTERED]@\2')
+ @text = @text.gsub(email_validation_regex, '[FILTERED]@\2')
else
- filter_text.gsub(email_validation_regex, '[EMAIL]')
+ @text = @text.gsub(email_validation_regex, '[EMAIL]')
end
end
end
class Validations
class << self
def email?(value)
/[[:alnum:]][[:alnum:]_+.-]{0,200}@(.*)/n === value and hostname? $1
end
def hostname?(value)
/(?:([[:alnum:]][[:alnum:]-]{,60}[[:alnum:]])?\.)+([a-zA-Z]{2,3})/n === value
end
def phone?(value)
/(?<pre>(?<![[:alnum:]+])0|(?:00|\+)[1-9]\d{,2})(?<main>[_ ()]{,2}\d){6,11}/n === value
end
def ip_address?(value)
/(?<bit>\d|[1-9]\d|1\d\d|2[1-4]\d|25[0-5])(?:\.\g<bit>){3}/ === value
end
def number?(value)
/-?(0|[1-9]\d*)\.?\d+/ === value
end
def integer?(value)
/-?(0|[1-9]\d*)/ === value
end
def date?(value)
/(\d{4})-(0\d|1[0-2])-([0-2]\d|3[01])/ === value
end
def time?(value)
/([0-1]\d|2[0-4])(:[0-5]\d){2}/ === value
end
def date_time?(value)
/([0-9-]+)(?: |T)([0-9:]+)/ === value and date? $1 and time? $2
end
end
end

Тук имам един въпрос - понеже на много места досега сте казвали да избягваме методи с ! по всякакъв начин затова и тук така съм направил. Но все пак x = x.gsub... ми се струва малко WET в дадения случай и реално не е ли че gsub! прави същото. При това положение правилно ли съм избягвал gsub! или това е един от малкото случаи, когато няма проблем да ползваме метод с ! (ако това се извършва в някакъв tap)?