Програмиране с Ruby

Курс във Факултета по Математика и Информатика към СУ

Решение на Четвърта задача от Кирил Владимиров

Обратно към всички решения

Към профила на Кирил Владимиров

Резултати

  • 3 точки от тестове
  • 0 бонус точки
  • 3 точки общо
  • 18 успешни тест(а)
  • 23 неуспешни тест(а)

Код

PATTERNS = {
username: /(?<username>(?<preserve>[a-z0-9][A-Za-z0-9_\.+-]{2})[A-Za-z0-9_\.+-]{3,197}|[a-z0-9][A-Za-z0-9_\.+-]{,4})/,
hostname: /(?<hostname>[A-Za-z0-9][A-Za-z0-9-]{,61}[A-Za-z0-9]\.[A-Za-z]{2,3}(\.[A-Za-z]{2,3})?)/,
phone: /(?<country_code>((00|\+)[1-9][0-9]{,2}|0))(?<number>(([ \(\)-]{,2})\d){6,11})/,
ip_address: /((25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){3}/,
number: /-?(0\.|[1-9][0-9]*\.?)[0-9]*/,
integer: /-?[1-9][0-9]*/,
date: /[0-9]{4}-([1-9]|1[0-2])-(3[0-1]|2[0-9]|1[0-9]|[1-9])/,
time: /([0-9]|1[0-9]|2[0-3]):([0-5][0-9]):([0-5][0-9])/,
}
PATTERNS[:email] = Regexp.new [PATTERNS[:username].to_s, '@', PATTERNS[:hostname].to_s].join
PATTERNS[:date_time] = Regexp.new [PATTERNS[:date].to_s, ' ', PATTERNS[:time].to_s].join
class PrivacyFilter
attr_accessor :preserve_phone_country_code, :preserve_email_hostname, :partially_preserve_email_username
def initialize(text)
@text = text
@preserve_phone_country_code = false
@preserve_email_hostname = false
@partially_preserve_email_username = false
end
def filtered
decide_how_to_filter_email
filter_phone
@text
end
private
def decide_how_to_filter_email
if @preserve_email_hostname then filter_email_and_preserve_hostname
elsif @partially_preserve_email_username then filter_email_and_partially_preserve_username
else filter_email end
end
def filter_email
@text = @text.gsub(PATTERNS[:email], '[EMAIL]')
end
def filter_email_and_preserve_hostname
@text = @text.gsub(PATTERNS[:email], '[FILTERED]@\k<hostname>')
end
def filter_email_and_partially_preserve_username
@text = @text.gsub(PATTERNS[:email], '\k<preserve>[FILTERED]@\k<hostname>')
end
def filter_phone
return @text = @text.gsub(PATTERNS[:phone], '\k<country_code> [FILTERED]') if @preserve_phone_country_code
@text = @text.gsub(PATTERNS[:phone], '[PHONE]')
end
end
class Validations
def self.method_missing(name, *args, &block)
if name.to_s.end_with? '?'
format = name.to_s[0...-1].to_sym
return !!(args[0] =~ PATTERNS[format]) if PATTERNS.include? format
end
end
end

Лог от изпълнението

..FF.....F..F...FF.FFFFFF.FF.FF.FF..FFFFF

Failures:

  1) PrivacyFilter obfuscates more complicated emails
     Failure/Error: filter(text).should eq filtered
       
       expected: "[EMAIL]"
            got: "larodi@x.com"
       
       (compared using ==)
     # /tmp/d20130203-23049-ktd8nb/spec.rb:40:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-ktd8nb/spec.rb:39:in `each'
     # /tmp/d20130203-23049-ktd8nb/spec.rb:39:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  2) PrivacyFilter does not filter invalid emails
     Failure/Error: filter(text_with_invalid_emails).should eq text_with_invalid_emails
       
       expected: "Contact me here: _invalid@email.com"
            got: "Contact me here: _[EMAIL]"
       
       (compared using ==)
     # /tmp/d20130203-23049-ktd8nb/spec.rb:52:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-ktd8nb/spec.rb:46:in `each'
     # /tmp/d20130203-23049-ktd8nb/spec.rb:46:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  3) PrivacyFilter does not filter invalid phone numbers
     Failure/Error: filter(text).should eq filtered
       
       expected: "Reach me at: 0885123"
            got: "Reach me at: [PHONE]"
       
       (compared using ==)
     # /tmp/d20130203-23049-ktd8nb/spec.rb:96:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-ktd8nb/spec.rb:95:in `each'
     # /tmp/d20130203-23049-ktd8nb/spec.rb:95:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  4) PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
     Failure/Error: filter.filtered.should eq filtered
       
       expected: "Phone: [PHONE]"
            got: "Phone: 0 [FILTERED]"
       
       (compared using ==)
     # /tmp/d20130203-23049-ktd8nb/spec.rb:132:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-ktd8nb/spec.rb:129:in `each'
     # /tmp/d20130203-23049-ktd8nb/spec.rb:129:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  5) Validations can validate more complex emails
     Failure/Error: Validations.email?(email).should be(valid)
       
       expected #<FalseClass:0> => false
            got #<TrueClass:2> => true
       
       Compared using equal?, which compares object identity,
       but expected and actual are not the same object. Use
       'actual.should eq(expected)' if you don't care about
       object identity in this example.
     # /tmp/d20130203-23049-ktd8nb/spec.rb:171:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-ktd8nb/spec.rb:170:in `each'
     # /tmp/d20130203-23049-ktd8nb/spec.rb:170:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  6) Validations does not break on emails in multiline strings
     Failure/Error: Validations.email?("foo@bar.com\nwat?").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-ktd8nb/spec.rb:176:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  7) Validations can validate more complex phone numbers
     Failure/Error: Validations.phone?(phone).should be(valid)
       
       expected #<FalseClass:0> => false
            got #<TrueClass:2> => true
       
       Compared using equal?, which compares object identity,
       but expected and actual are not the same object. Use
       'actual.should eq(expected)' if you don't care about
       object identity in this example.
     # /tmp/d20130203-23049-ktd8nb/spec.rb:210:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-ktd8nb/spec.rb:209:in `each'
     # /tmp/d20130203-23049-ktd8nb/spec.rb:209:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  8) Validations does not break on phones in multiline strings
     Failure/Error: Validations.phone?("0885123123\nwat?").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-ktd8nb/spec.rb:215:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  9) Validations validates hostnames
     Failure/Error: Validations.hostname?('x.io').should be_true
       expected: true value
            got: false
     # /tmp/d20130203-23049-ktd8nb/spec.rb:223:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  10) Validations handles multiline strings in hostname validation properly
     Failure/Error: Validations.hostname?("foo.com\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-ktd8nb/spec.rb:233:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  11) Validations validates IP addresses
     Failure/Error: Validations.ip_address?('300.2.3.4').should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-ktd8nb/spec.rb:239:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  12) Validations handles multiline strings in IP validation properly
     Failure/Error: Validations.ip_address?("8.8.8.8\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-ktd8nb/spec.rb:245:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  13) Validations validates more complex numbers
     Failure/Error: Validations.number?(' 42 ').should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-ktd8nb/spec.rb:258:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  14) Validations handles multiline strings in numbers validation properly
     Failure/Error: Validations.number?("42\n24").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-ktd8nb/spec.rb:274:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  15) Validations validates more complex integers
     Failure/Error: Validations.integer?(' 42 ').should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-ktd8nb/spec.rb:284:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  16) Validations handles multiline strings in integer validation properly
     Failure/Error: Validations.number?("42\n24").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-ktd8nb/spec.rb:295:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  17) Validations allows zero years in date validation
     Failure/Error: Validations.date?('0000-01-01').should be_true
       expected: true value
            got: false
     # /tmp/d20130203-23049-ktd8nb/spec.rb:307:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  18) Validations allows huge years in date validation
     Failure/Error: Validations.date?('9999-01-01').should be_true
       expected: true value
            got: false
     # /tmp/d20130203-23049-ktd8nb/spec.rb:311:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  19) Validations handles newlines in date validation
     Failure/Error: Validations.date?("2012-11-19\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-ktd8nb/spec.rb:327:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  20) Validations validates times
     Failure/Error: Validations.time?('3:59:59').should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-ktd8nb/spec.rb:336:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  21) Validations does not allow invalid hours, minutes or seconds
     Failure/Error: Validations.time?('24:00:00').should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-ktd8nb/spec.rb:340:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  22) Validations validates datetime values
     Failure/Error: Validations.date_time?('2012-11-19T19:00:00').should be_true
       expected: true value
            got: false
     # /tmp/d20130203-23049-ktd8nb/spec.rb:349:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  23) Validations handles newlines in time and datetime validation
     Failure/Error: Validations.time?("12:01:01\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-ktd8nb/spec.rb:360:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

Finished in 0.05401 seconds
41 examples, 23 failures

Failed examples:

rspec /tmp/d20130203-23049-ktd8nb/spec.rb:30 # PrivacyFilter obfuscates more complicated emails
rspec /tmp/d20130203-23049-ktd8nb/spec.rb:44 # PrivacyFilter does not filter invalid emails
rspec /tmp/d20130203-23049-ktd8nb/spec.rb:89 # PrivacyFilter does not filter invalid phone numbers
rspec /tmp/d20130203-23049-ktd8nb/spec.rb:122 # PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
rspec /tmp/d20130203-23049-ktd8nb/spec.rb:160 # Validations can validate more complex emails
rspec /tmp/d20130203-23049-ktd8nb/spec.rb:175 # Validations does not break on emails in multiline strings
rspec /tmp/d20130203-23049-ktd8nb/spec.rb:184 # Validations can validate more complex phone numbers
rspec /tmp/d20130203-23049-ktd8nb/spec.rb:214 # Validations does not break on phones in multiline strings
rspec /tmp/d20130203-23049-ktd8nb/spec.rb:218 # Validations validates hostnames
rspec /tmp/d20130203-23049-ktd8nb/spec.rb:232 # Validations handles multiline strings in hostname validation properly
rspec /tmp/d20130203-23049-ktd8nb/spec.rb:237 # Validations validates IP addresses
rspec /tmp/d20130203-23049-ktd8nb/spec.rb:244 # Validations handles multiline strings in IP validation properly
rspec /tmp/d20130203-23049-ktd8nb/spec.rb:257 # Validations validates more complex numbers
rspec /tmp/d20130203-23049-ktd8nb/spec.rb:273 # Validations handles multiline strings in numbers validation properly
rspec /tmp/d20130203-23049-ktd8nb/spec.rb:283 # Validations validates more complex integers
rspec /tmp/d20130203-23049-ktd8nb/spec.rb:294 # Validations handles multiline strings in integer validation properly
rspec /tmp/d20130203-23049-ktd8nb/spec.rb:306 # Validations allows zero years in date validation
rspec /tmp/d20130203-23049-ktd8nb/spec.rb:310 # Validations allows huge years in date validation
rspec /tmp/d20130203-23049-ktd8nb/spec.rb:326 # Validations handles newlines in date validation
rspec /tmp/d20130203-23049-ktd8nb/spec.rb:331 # Validations validates times
rspec /tmp/d20130203-23049-ktd8nb/spec.rb:339 # Validations does not allow invalid hours, minutes or seconds
rspec /tmp/d20130203-23049-ktd8nb/spec.rb:347 # Validations validates datetime values
rspec /tmp/d20130203-23049-ktd8nb/spec.rb:359 # Validations handles newlines in time and datetime validation

История (1 версия и 2 коментара)

Кирил обнови решението на 27.11.2012 21:10 (преди над 11 години)

+PATTERNS = {
+ username: /(?<username>(?<preserve>[a-z0-9][A-Za-z0-9_\.+-]{2})[A-Za-z0-9_\.+-]{3,197}|[a-z0-9][A-Za-z0-9_\.+-]{,4})/,
+ hostname: /(?<hostname>[A-Za-z0-9][A-Za-z0-9-]{,61}[A-Za-z0-9]\.[A-Za-z]{2,3}(\.[A-Za-z]{2,3})?)/,
+ phone: /(?<country_code>((00|\+)[1-9][0-9]{,2}|0))(?<number>(([ \(\)-]{,2})\d){6,11})/,
+ ip_address: /((25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){3}/,
+ number: /-?(0\.|[1-9][0-9]*\.?)[0-9]*/,
+ integer: /-?[1-9][0-9]*/,
+ date: /[0-9]{4}-([1-9]|1[0-2])-(3[0-1]|2[0-9]|1[0-9]|[1-9])/,
+ time: /([0-9]|1[0-9]|2[0-3]):([0-5][0-9]):([0-5][0-9])/,
+}
+
+PATTERNS[:email] = Regexp.new [PATTERNS[:username].to_s, '@', PATTERNS[:hostname].to_s].join
+PATTERNS[:date_time] = Regexp.new [PATTERNS[:date].to_s, ' ', PATTERNS[:time].to_s].join
+
+
+class PrivacyFilter
+ attr_accessor :preserve_phone_country_code, :preserve_email_hostname, :partially_preserve_email_username
+
+ def initialize(text)
+ @text = text
+ @preserve_phone_country_code = false
+ @preserve_email_hostname = false
+ @partially_preserve_email_username = false
+ end
+
+ def filtered
+ decide_how_to_filter_email
+ filter_phone
+ @text
+ end
+
+ private
+
+ def decide_how_to_filter_email
+ if @preserve_email_hostname then filter_email_and_preserve_hostname
+ elsif @partially_preserve_email_username then filter_email_and_partially_preserve_username
+ else filter_email end
+ end
+
+ def filter_email
+ @text = @text.gsub(PATTERNS[:email], '[EMAIL]')
+ end
+
+ def filter_email_and_preserve_hostname
+ @text = @text.gsub(PATTERNS[:email], '[FILTERED]@\k<hostname>')
+ end
+
+ def filter_email_and_partially_preserve_username
+ @text = @text.gsub(PATTERNS[:email], '\k<preserve>[FILTERED]@\k<hostname>')
+ end
+
+ def filter_phone
+ return @text = @text.gsub(PATTERNS[:phone], '\k<country_code> [FILTERED]') if @preserve_phone_country_code
+ @text = @text.gsub(PATTERNS[:phone], '[PHONE]')
+ end
+end
+
+
+class Validations
+ def self.method_missing(name, *args, &block)
+ if name.to_s.end_with? '?'
+ format = name.to_s[0...-1].to_sym
+ return !!(args[0] =~ PATTERNS[format]) if PATTERNS.include? format
+ end
+ end
+end
  • ОК ли е да ползвам method_missing за тази цел? Аргументацията ми е, че няма нужда да пипам нищо из Validations щом добавя нов шаблон, пък и избягвам досадни повторения.
  • ОК ли е да вкарам логиката с показване на част от потребителското име в шаблона? Струва ми се доста кофти, но пък не правя разни конкатенации в самия метод. От друга страна, би следвало тази логика да е точно в метода, а не в шаблона.
  • Това ли е правилният начин да сливам шаблони (ред 12 и 13)?