Решение на Четвърта задача от Йордан Стефанов

Обратно към всички решения

Към профила на Йордан Стефанов

Резултати

  • 4 точки от тестове
  • 0 бонус точки
  • 4 точки общо
  • 24 успешни тест(а)
  • 17 неуспешни тест(а)

Код

class Validations
REG_EXP_HOSTNAME = /(([[:alnum:]][[:alnum:]\-]{,60})?[[:alnum:]]\.)+(?<tld>[[:alpha:]]{2,3}(\.[[:alpha:]]{2})?)/i
REG_EXP_EMAIL = /(?<username>[[:alnum:]][[:word:]\.\+\-]{,200})@(?<hostname>#{REG_EXP_HOSTNAME})/i
REG_EXP_PHONE = /(?:(?<local_prefix>0)|(?<inter_prefix>(00|\+)[1-9]\d{,2}))(([ \-()]{,2}\d){6,11})/
REG_EXP_IP_ADDRESS = /(\d{1,3})\.(\d{1,3})\.(\d{1,3})\.(\d{1,3})/
REG_EXP_INTEGER = /-?\d+/
REG_EXP_NUMBER = /#{REG_EXP_INTEGER}(\.\d+)?/
REG_EXP_DATE = /(\d{4})-(\d{2})-(\d{2})/
REG_EXP_TIME = /(\d{2}):(\d{2}):(\d{2})/
REG_EXP_DATE_TIME = /(?<date>#{REG_EXP_DATE})[ T](?<time>#{REG_EXP_TIME})/
def self.hostname? value
!/^#{REG_EXP_HOSTNAME}$/.match(value).nil?
end
def self.email? value
!/^#{REG_EXP_EMAIL}$/.match(value).nil?
end
def self.integer? value
!/^#{REG_EXP_INTEGER}$/.match(value).nil?
end
def self.number? value
!/^#{REG_EXP_NUMBER}$/.match(value).nil?
end
def self.phone? value
!/^#{REG_EXP_PHONE}$/.match(value).nil?
end
def self.ip_address? value
return false if /^#{REG_EXP_IP_ADDRESS}$/.match(value).nil?
[$1, $2, $3, $4].each do |ip_octet|
return false if ip_octet.to_i > 255
end
true
end
def self.date? value
return false if /^#{REG_EXP_DATE}$/.match(value).nil?
return true if $2.to_i.between?( 1, 12 ) and $3.to_i.between?( 1, 31 )
false
end
def self.time? value
return false if /^#{REG_EXP_TIME}$/.match(value).nil?
return true if $1.to_i.between?( 0, 23 ) and $2.to_i.between?( 0, 59 ) and $3.to_i.between?( 0, 59 )
false
end
def self.date_time? value
p value
match_data = REG_EXP_DATE_TIME.match( value )
return false if not match_data
return ( self.date?( match_data['date'] ) and self.time?( match_data['time'] ) )
end
end
class PrivacyFilter
attr_reader :private_data
attr_accessor :preserve_phone_country_code, :preserve_email_hostname, :partially_preserve_email_username
def initialize text
@private_data = text
@preserve_phone_country_code = false
@preserve_email_hostname = false
@partially_preserve_email_username = false
end
def filter_email username, hostname
return username.gsub( /(.{3}).+/, '\1[FILTERED]@' + hostname ) if partially_preserve_email_username
return '[FILTERED]@' + hostname if preserve_email_hostname
'[EMAIL]'
end
def filter_next_email text
text.gsub!( Validations::REG_EXP_EMAIL ) { |_| Validations.email?( _ ) ? filter_email( $1, $2 ) : _ }
end
def filter_phone inter_prefix
if preserve_phone_country_code and inter_prefix
return inter_prefix + ' [FILTERED]'
end
'[PHONE]'
end
def filter_next_phone text
text.gsub!( Validations::REG_EXP_PHONE ) { |_| Validations.phone?( _ ) ? filter_phone( $2 ) : _ }
end
def filtered
private_data_copy = String.new @private_data
while filter_next_email private_data_copy
end
while filter_next_phone private_data_copy
end
private_data_copy
end
end

Лог от изпълнението

...F..FF.F..FF...F.FF.F.F.FF.FF.....F.."2012-11-19 19:00:00"
"2012-11-19T19:00:00"
"foo"
"9999-11-19T23:59:00"
"2012-00-19T23:59:00"
"2012-01-00T23:59:00"
"2012-01-01T24:59:00"
"2012-01-01T12:60:00"
"2012-01-01T12:04:60"
.F

Failures:

  1) PrivacyFilter does not filter invalid emails
     Failure/Error: filter(text_with_invalid_emails).should eq text_with_invalid_emails
       
       expected: "Contact me here: _invalid@email.com"
            got: "Contact me here: _[EMAIL]"
       
       (compared using ==)
     # /tmp/d20130203-23049-122p8kk/spec.rb:52:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-122p8kk/spec.rb:46:in `each'
     # /tmp/d20130203-23049-122p8kk/spec.rb:46:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  2) PrivacyFilter filters whole email usernames if too short
     Failure/Error: partially_filter_email_usernames('me@example.com').should eq '[FILTERED]@example.com'
       
       expected: "[FILTERED]@example.com"
            got: "me"
       
       (compared using ==)
     # /tmp/d20130203-23049-122p8kk/spec.rb:69:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  3) PrivacyFilter does not brake with unicode
     Failure/Error: partially_filter_email_usernames('За връзка: me@example.com').should eq 'За връзка: [FILTERED]@example.com'
       
       expected: "За връзка: [FILTERED]@example.com"
            got: "За връзка: me"
       
       (compared using ==)
     # /tmp/d20130203-23049-122p8kk/spec.rb:73:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  4) PrivacyFilter does not filter invalid phone numbers
     Failure/Error: filter(text).should eq filtered
       
       expected: "Reach me at: 0885123"
            got: "Reach me at: [PHONE]"
       
       (compared using ==)
     # /tmp/d20130203-23049-122p8kk/spec.rb:96:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-122p8kk/spec.rb:95:in `each'
     # /tmp/d20130203-23049-122p8kk/spec.rb:95:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  5) PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
     Failure/Error: filter.filtered.should eq filtered
       
       expected: "Phone: 0025 [FILTERED]"
            got: "Phone: [PHONE]5"
       
       (compared using ==)
     # /tmp/d20130203-23049-122p8kk/spec.rb:132:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-122p8kk/spec.rb:129:in `each'
     # /tmp/d20130203-23049-122p8kk/spec.rb:129:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  6) PrivacyFilter separates preserved country code from filtered phone with a space
     Failure/Error: filter.filtered.should eq filtered
       
       expected: "Phone: 0025 [FILTERED]"
            got: "Phone: [PHONE]5"
       
       (compared using ==)
     # /tmp/d20130203-23049-122p8kk/spec.rb:144:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-122p8kk/spec.rb:141:in `each'
     # /tmp/d20130203-23049-122p8kk/spec.rb:141:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  7) Validations does not break on emails in multiline strings
     Failure/Error: Validations.email?("foo@bar.com\nwat?").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-122p8kk/spec.rb:176:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  8) Validations can validate more complex phone numbers
     Failure/Error: Validations.phone?(phone).should be(valid)
       
       expected #<FalseClass:0> => false
            got #<TrueClass:2> => true
       
       Compared using equal?, which compares object identity,
       but expected and actual are not the same object. Use
       'actual.should eq(expected)' if you don't care about
       object identity in this example.
     # /tmp/d20130203-23049-122p8kk/spec.rb:210:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-122p8kk/spec.rb:209:in `each'
     # /tmp/d20130203-23049-122p8kk/spec.rb:209:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  9) Validations does not break on phones in multiline strings
     Failure/Error: Validations.phone?("0885123123\nwat?").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-122p8kk/spec.rb:215:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  10) Validations handles multiline strings in hostname validation properly
     Failure/Error: Validations.hostname?("foo.com\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-122p8kk/spec.rb:233:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  11) Validations handles multiline strings in IP validation properly
     Failure/Error: Validations.ip_address?("8.8.8.8\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-122p8kk/spec.rb:245:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  12) Validations validates more complex numbers
     Failure/Error: Validations.number?('00').should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-122p8kk/spec.rb:263:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  13) Validations handles multiline strings in numbers validation properly
     Failure/Error: Validations.number?("42\n24").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-122p8kk/spec.rb:274:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  14) Validations validates more complex integers
     Failure/Error: Validations.integer?('00').should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-122p8kk/spec.rb:286:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  15) Validations handles multiline strings in integer validation properly
     Failure/Error: Validations.number?("42\n24").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-122p8kk/spec.rb:295:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  16) Validations handles newlines in date validation
     Failure/Error: Validations.date?("2012-11-19\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-122p8kk/spec.rb:327:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  17) Validations handles newlines in time and datetime validation
     Failure/Error: Validations.time?("12:01:01\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-122p8kk/spec.rb:360:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

Finished in 0.20387 seconds
41 examples, 17 failures

Failed examples:

rspec /tmp/d20130203-23049-122p8kk/spec.rb:44 # PrivacyFilter does not filter invalid emails
rspec /tmp/d20130203-23049-122p8kk/spec.rb:68 # PrivacyFilter filters whole email usernames if too short
rspec /tmp/d20130203-23049-122p8kk/spec.rb:72 # PrivacyFilter does not brake with unicode
rspec /tmp/d20130203-23049-122p8kk/spec.rb:89 # PrivacyFilter does not filter invalid phone numbers
rspec /tmp/d20130203-23049-122p8kk/spec.rb:122 # PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
rspec /tmp/d20130203-23049-122p8kk/spec.rb:136 # PrivacyFilter separates preserved country code from filtered phone with a space
rspec /tmp/d20130203-23049-122p8kk/spec.rb:175 # Validations does not break on emails in multiline strings
rspec /tmp/d20130203-23049-122p8kk/spec.rb:184 # Validations can validate more complex phone numbers
rspec /tmp/d20130203-23049-122p8kk/spec.rb:214 # Validations does not break on phones in multiline strings
rspec /tmp/d20130203-23049-122p8kk/spec.rb:232 # Validations handles multiline strings in hostname validation properly
rspec /tmp/d20130203-23049-122p8kk/spec.rb:244 # Validations handles multiline strings in IP validation properly
rspec /tmp/d20130203-23049-122p8kk/spec.rb:257 # Validations validates more complex numbers
rspec /tmp/d20130203-23049-122p8kk/spec.rb:273 # Validations handles multiline strings in numbers validation properly
rspec /tmp/d20130203-23049-122p8kk/spec.rb:283 # Validations validates more complex integers
rspec /tmp/d20130203-23049-122p8kk/spec.rb:294 # Validations handles multiline strings in integer validation properly
rspec /tmp/d20130203-23049-122p8kk/spec.rb:326 # Validations handles newlines in date validation
rspec /tmp/d20130203-23049-122p8kk/spec.rb:359 # Validations handles newlines in time and datetime validation

История (2 версии и 0 коментара)

Йордан обнови решението на 28.11.2012 12:53 (преди над 11 години)

+class Validations
+ REG_EXP_HOSTNAME = /(([[:alnum:]][[:alnum:]\-]{,60})?[[:alnum:]]\.)+(?<tld>[[:alpha:]]{2,3}(\.[[:alpha:]]{2})?)/i
+ REG_EXP_EMAIL = /(?<username>[[:alnum:]][[:word:]\.\+\-]{,200})@(?<hostname>#{REG_EXP_HOSTNAME})/i
+ REG_EXP_PHONE = /(?:(?<local_prefix>0)|(?<inter_prefix>(00|\+)[1-9]\d{,2}))(([ \-()]{,2}\d){6,11})/
+ REG_EXP_IP_ADDRESS = /(\d{1,3})\.(\d{1,3})\.(\d{1,3})\.(\d{1,3})/
+ REG_EXP_INTEGER = /-?\d+/
+ REG_EXP_NUMBER = /#{REG_EXP_INTEGER}(\.\d+)?/
+ REG_EXP_DATE = /(\d{4})-(\d{2})-(\d{2})/
+ REG_EXP_TIME = /(\d{2}):(\d{2}):(\d{2})/
+ REG_EXP_DATE_TIME = /(?<date>#{REG_EXP_DATE})[ T](?<time>#{REG_EXP_TIME})/
+
+ def self.hostname? value
+ !/^#{REG_EXP_HOSTNAME}$/.match(value).nil?
+ end
+
+ def self.email? value
+ !/^#{REG_EXP_EMAIL}$/.match(value).nil?
+ end
+
+ def self.integer? value
+ !/^#{REG_EXP_INTEGER}$/.match(value).nil?
+ end
+
+ def self.number? value
+ !/^#{REG_EXP_NUMBER}$/.match(value).nil?
+ end
+
+ def self.phone? value
+ !/^#{REG_EXP_PHONE}$/.match(value).nil?
+ end
+
+ def self.ip_address? value
+ return false if /^#{REG_EXP_IP_ADDRESS}$/.match(value).nil?
+ [$1, $2, $3, $4].each do |ip_octet|
+ return false if ip_octet.to_i > 255
+ end
+ true
+ end
+
+ def self.date? value
+ return false if /^#{REG_EXP_DATE}$/.match(value).nil?
+ return true if $2.to_i.between?( 1, 12 ) and $3.to_i.between?( 1, 31 )
+ false
+ end
+
+ def self.time? value
+ return false if /^#{REG_EXP_TIME}$/.match(value).nil?
+ return true if $1.to_i.between?( 0, 23 ) and $2.to_i.between?( 0, 59 ) and $3.to_i.between?( 0, 59 )
+ false
+ end
+
+ def self.date_time? value
+ p value
+ match_data = REG_EXP_DATE_TIME.match( value )
+ return false if not match_data
+ return ( self.date?( match_data['date'] ) and self.time?( match_data['time'] ) )
+ end
+end
+
+
+class PrivacyFilter
+ attr_reader :private_data
+ attr_accessor :preserve_phone_country_code, :preserve_email_hostname, :partially_preserve_email_username
+
+ def initialize text
+ @private_data = text
+ @preserve_phone_country_code = false
+ @preserve_email_hostname = false
+ @partially_preserve_email_username = false
+ end
+
+ def filter_email username, hostname
+ return username.gsub( /(.{3}).+/, '\1[FILTERED]@' + hostname ) if partially_preserve_email_username
+ return '[FILTERED]@' + hostname if preserve_email_hostname
+ '[EMAIL]'
+ end
+
+ def filter_next_email
+ @private_data.gsub!( Validations::REG_EXP_EMAIL ) { |_| Validations.email?( _ ) ? filter_email( $1, $2 ) : _ }
+ end
+
+ def filter_phone inter_prefix
+ if preserve_phone_country_code and inter_prefix
+ return inter_prefix + ' [FILTERED]'
+ end
+ '[PHONE]'
+ end
+
+ def filter_next_phone
+ @private_data.gsub!( Validations::REG_EXP_PHONE ) { |_| Validations.phone?( _ ) ? filter_phone( $2 ) : _ }
+ end
+
+ def filtered
+ while filter_next_email
+ end
+ while filter_next_phone
+ end
+ private_data
+ end
+end

Йордан обнови решението на 28.11.2012 13:00 (преди над 11 години)

class Validations
REG_EXP_HOSTNAME = /(([[:alnum:]][[:alnum:]\-]{,60})?[[:alnum:]]\.)+(?<tld>[[:alpha:]]{2,3}(\.[[:alpha:]]{2})?)/i
REG_EXP_EMAIL = /(?<username>[[:alnum:]][[:word:]\.\+\-]{,200})@(?<hostname>#{REG_EXP_HOSTNAME})/i
REG_EXP_PHONE = /(?:(?<local_prefix>0)|(?<inter_prefix>(00|\+)[1-9]\d{,2}))(([ \-()]{,2}\d){6,11})/
REG_EXP_IP_ADDRESS = /(\d{1,3})\.(\d{1,3})\.(\d{1,3})\.(\d{1,3})/
REG_EXP_INTEGER = /-?\d+/
REG_EXP_NUMBER = /#{REG_EXP_INTEGER}(\.\d+)?/
REG_EXP_DATE = /(\d{4})-(\d{2})-(\d{2})/
REG_EXP_TIME = /(\d{2}):(\d{2}):(\d{2})/
REG_EXP_DATE_TIME = /(?<date>#{REG_EXP_DATE})[ T](?<time>#{REG_EXP_TIME})/
def self.hostname? value
!/^#{REG_EXP_HOSTNAME}$/.match(value).nil?
end
def self.email? value
!/^#{REG_EXP_EMAIL}$/.match(value).nil?
end
def self.integer? value
!/^#{REG_EXP_INTEGER}$/.match(value).nil?
end
def self.number? value
!/^#{REG_EXP_NUMBER}$/.match(value).nil?
end
def self.phone? value
!/^#{REG_EXP_PHONE}$/.match(value).nil?
end
def self.ip_address? value
return false if /^#{REG_EXP_IP_ADDRESS}$/.match(value).nil?
[$1, $2, $3, $4].each do |ip_octet|
return false if ip_octet.to_i > 255
end
true
end
def self.date? value
return false if /^#{REG_EXP_DATE}$/.match(value).nil?
return true if $2.to_i.between?( 1, 12 ) and $3.to_i.between?( 1, 31 )
false
end
def self.time? value
return false if /^#{REG_EXP_TIME}$/.match(value).nil?
return true if $1.to_i.between?( 0, 23 ) and $2.to_i.between?( 0, 59 ) and $3.to_i.between?( 0, 59 )
false
end
def self.date_time? value
p value
match_data = REG_EXP_DATE_TIME.match( value )
return false if not match_data
return ( self.date?( match_data['date'] ) and self.time?( match_data['time'] ) )
end
end
class PrivacyFilter
attr_reader :private_data
attr_accessor :preserve_phone_country_code, :preserve_email_hostname, :partially_preserve_email_username
def initialize text
@private_data = text
@preserve_phone_country_code = false
@preserve_email_hostname = false
@partially_preserve_email_username = false
end
def filter_email username, hostname
return username.gsub( /(.{3}).+/, '\1[FILTERED]@' + hostname ) if partially_preserve_email_username
return '[FILTERED]@' + hostname if preserve_email_hostname
'[EMAIL]'
end
- def filter_next_email
- @private_data.gsub!( Validations::REG_EXP_EMAIL ) { |_| Validations.email?( _ ) ? filter_email( $1, $2 ) : _ }
+ def filter_next_email text
+ text.gsub!( Validations::REG_EXP_EMAIL ) { |_| Validations.email?( _ ) ? filter_email( $1, $2 ) : _ }
end
def filter_phone inter_prefix
if preserve_phone_country_code and inter_prefix
return inter_prefix + ' [FILTERED]'
end
'[PHONE]'
end
- def filter_next_phone
- @private_data.gsub!( Validations::REG_EXP_PHONE ) { |_| Validations.phone?( _ ) ? filter_phone( $2 ) : _ }
+ def filter_next_phone text
+ text.gsub!( Validations::REG_EXP_PHONE ) { |_| Validations.phone?( _ ) ? filter_phone( $2 ) : _ }
end
def filtered
- while filter_next_email
+ private_data_copy = String.new @private_data
+ while filter_next_email private_data_copy
end
- while filter_next_phone
+ while filter_next_phone private_data_copy
end
- private_data
+ private_data_copy
end
end