Решение на Четвърта задача от Йоана Тодорова

Обратно към всички решения

Към профила на Йоана Тодорова

Резултати

  • 2 точки от тестове
  • 0 бонус точки
  • 2 точки общо
  • 13 успешни тест(а)
  • 28 неуспешни тест(а)

Код

class Validations
def self.hostname?(value)
if value =~ /^((?<name>(?<no>[0-9A-Za-z])([0-9A-Za-z-]{,60}\g<no>)?)\.)*\g<name>(?<TLD>[A-Za-z]{2,3})(\.\g<TLD>)?$/x
return true
end
false
end
def self.email?(value)
if value =~ /[A-Za-z0-9][A-Za-z0-9_+.-]{,200}@\b/ and Validations.hostname? $'
return true
end
false
end
def self.phone?(value)
if value =~ /^(0|((0{2}|\+)[1-9]{1}\d{2}))(?<separators>[\s\(\)-])*(\d\g<separators>{0,2}){5,10}\d$/
return true
end
false
end
def self.ip_address?(value)
if value =~ /^(?<byte>\d|(\d\d)|(1\d\d)|(2[0-4]\d)|(25[0-5]))(\.\g<byte>){3}$/
return true
end
false
end
def self.number?(value)
if value =~ /^-?(0|([1-9]\d*))(\.\d+)?$/
return true
end
false
end
def self.integer?(value)
if value =~ /^-?(0|([1-9]\d*))$/
return true
end
false
end
def self.date?(value)
if value =~ /^\d{4}-((0[1-9])|(1[0-2]))-((0[1-9])|([1-2]\d)|(3[0-1]))$/
return true
end
false
end
def self.time?(value)
if value =~ /^(\d|(1\d)|(2[0-3]))(?<min>:((0\d)|([1-5]\d)))\g<min>$/
return true
end
false
end
def self.date_time?(value)
date_and_time = value.split(/[ T]/, 2)
if Validations.date? date_and_time[0] and Validations.time? date_and_time[1]
return true
end
false
end
end

Лог от изпълнението

FFFFFFFFFFFFFFFFFF.FFFF.F..F..F.....FF..F

Failures:

  1) PrivacyFilter works with blank or whitespace strings and preserves whitespace
     Failure/Error: PrivacyFilter.new(text).filtered
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-83jwcc/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-83jwcc/spec.rb:21:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  2) PrivacyFilter obfuscates simple emails
     Failure/Error: PrivacyFilter.new(text).filtered
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-83jwcc/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-83jwcc/spec.rb:27:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  3) PrivacyFilter obfuscates more complicated emails
     Failure/Error: PrivacyFilter.new(text).filtered
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-83jwcc/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-83jwcc/spec.rb:40:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-83jwcc/spec.rb:39:in `each'
     # /tmp/d20130203-23049-83jwcc/spec.rb:39:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  4) PrivacyFilter does not filter invalid emails
     Failure/Error: PrivacyFilter.new(text).filtered
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-83jwcc/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-83jwcc/spec.rb:52:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-83jwcc/spec.rb:46:in `each'
     # /tmp/d20130203-23049-83jwcc/spec.rb:46:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  5) PrivacyFilter allows email hostname to be preserved
     Failure/Error: filter = PrivacyFilter.new(text)
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-83jwcc/spec.rb:9:in `filter_email_usernames'
     # /tmp/d20130203-23049-83jwcc/spec.rb:60:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  6) PrivacyFilter allows email usernames to be partially preserved
     Failure/Error: filter = PrivacyFilter.new(text)
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-83jwcc/spec.rb:15:in `partially_filter_email_usernames'
     # /tmp/d20130203-23049-83jwcc/spec.rb:65:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  7) PrivacyFilter filters whole email usernames if too short
     Failure/Error: filter = PrivacyFilter.new(text)
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-83jwcc/spec.rb:15:in `partially_filter_email_usernames'
     # /tmp/d20130203-23049-83jwcc/spec.rb:69:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  8) PrivacyFilter does not brake with unicode
     Failure/Error: filter = PrivacyFilter.new(text)
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-83jwcc/spec.rb:15:in `partially_filter_email_usernames'
     # /tmp/d20130203-23049-83jwcc/spec.rb:73:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  9) PrivacyFilter filters more complex phone numbers
     Failure/Error: PrivacyFilter.new(text).filtered
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-83jwcc/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-83jwcc/spec.rb:85:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-83jwcc/spec.rb:84:in `each'
     # /tmp/d20130203-23049-83jwcc/spec.rb:84:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  10) PrivacyFilter does not filter invalid phone numbers
     Failure/Error: PrivacyFilter.new(text).filtered
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-83jwcc/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-83jwcc/spec.rb:96:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-83jwcc/spec.rb:95:in `each'
     # /tmp/d20130203-23049-83jwcc/spec.rb:95:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  11) PrivacyFilter preserves whitespace around phones
     Failure/Error: PrivacyFilter.new(text).filtered
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-83jwcc/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-83jwcc/spec.rb:101:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  12) PrivacyFilter filters more than one phone or email
     Failure/Error: PrivacyFilter.new(text).filtered
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-83jwcc/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-83jwcc/spec.rb:119:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  13) PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
     Failure/Error: filter = PrivacyFilter.new(text)
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-83jwcc/spec.rb:130:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-83jwcc/spec.rb:129:in `each'
     # /tmp/d20130203-23049-83jwcc/spec.rb:129:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  14) PrivacyFilter separates preserved country code from filtered phone with a space
     Failure/Error: filter = PrivacyFilter.new(text)
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-83jwcc/spec.rb:142:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-83jwcc/spec.rb:141:in `each'
     # /tmp/d20130203-23049-83jwcc/spec.rb:141:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  15) Validations allows validation for emails
     Failure/Error: Validations.email?('invalid@email').should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-83jwcc/spec.rb:152:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  16) Validations returns boolean true or false
     Failure/Error: Validations.email?('invalid@email').should be(false)
       
       expected #<FalseClass:0> => false
            got #<TrueClass:2> => true
       
       Compared using equal?, which compares object identity,
       but expected and actual are not the same object. Use
       'actual.should eq(expected)' if you don't care about
       object identity in this example.
     # /tmp/d20130203-23049-83jwcc/spec.rb:157:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  17) Validations can validate more complex emails
     Failure/Error: Validations.email?(email).should be(valid)
       
       expected #<FalseClass:0> => false
            got #<TrueClass:2> => true
       
       Compared using equal?, which compares object identity,
       but expected and actual are not the same object. Use
       'actual.should eq(expected)' if you don't care about
       object identity in this example.
     # /tmp/d20130203-23049-83jwcc/spec.rb:171:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-83jwcc/spec.rb:170:in `each'
     # /tmp/d20130203-23049-83jwcc/spec.rb:170:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  18) Validations does not break on emails in multiline strings
     Failure/Error: Validations.email?("foo@bar.com\nwat?").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-83jwcc/spec.rb:176:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  19) Validations can validate more complex phone numbers
     Failure/Error: Validations.phone?(phone).should be(valid)
       
       expected #<TrueClass:2> => true
            got #<FalseClass:0> => false
       
       Compared using equal?, which compares object identity,
       but expected and actual are not the same object. Use
       'actual.should eq(expected)' if you don't care about
       object identity in this example.
     # /tmp/d20130203-23049-83jwcc/spec.rb:210:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-83jwcc/spec.rb:209:in `each'
     # /tmp/d20130203-23049-83jwcc/spec.rb:209:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  20) Validations does not break on phones in multiline strings
     Failure/Error: Validations.phone?("0885123123\nwat?").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-83jwcc/spec.rb:215:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  21) Validations validates hostnames
     Failure/Error: Validations.hostname?('some.long-subdomain.domain.co.ul').should be_true
       expected: true value
            got: false
     # /tmp/d20130203-23049-83jwcc/spec.rb:220:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  22) Validations handles multiline strings in hostname validation properly
     Failure/Error: Validations.hostname?("foo.com\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-83jwcc/spec.rb:233:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  23) Validations handles multiline strings in IP validation properly
     Failure/Error: Validations.ip_address?("8.8.8.8\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-83jwcc/spec.rb:245:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  24) Validations handles multiline strings in numbers validation properly
     Failure/Error: Validations.number?("42\n24").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-83jwcc/spec.rb:274:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  25) Validations handles multiline strings in integer validation properly
     Failure/Error: Validations.number?("42\n24").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-83jwcc/spec.rb:295:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  26) Validations handles newlines in date validation
     Failure/Error: Validations.date?("2012-11-19\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-83jwcc/spec.rb:327:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  27) Validations validates times
     Failure/Error: Validations.time?('00:00:00').should be_true
       expected: true value
            got: false
     # /tmp/d20130203-23049-83jwcc/spec.rb:334:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  28) Validations handles newlines in time and datetime validation
     Failure/Error: Validations.time?("12:01:01\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-83jwcc/spec.rb:360:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

Finished in 0.06223 seconds
41 examples, 28 failures

Failed examples:

rspec /tmp/d20130203-23049-83jwcc/spec.rb:20 # PrivacyFilter works with blank or whitespace strings and preserves whitespace
rspec /tmp/d20130203-23049-83jwcc/spec.rb:26 # PrivacyFilter obfuscates simple emails
rspec /tmp/d20130203-23049-83jwcc/spec.rb:30 # PrivacyFilter obfuscates more complicated emails
rspec /tmp/d20130203-23049-83jwcc/spec.rb:44 # PrivacyFilter does not filter invalid emails
rspec /tmp/d20130203-23049-83jwcc/spec.rb:59 # PrivacyFilter allows email hostname to be preserved
rspec /tmp/d20130203-23049-83jwcc/spec.rb:64 # PrivacyFilter allows email usernames to be partially preserved
rspec /tmp/d20130203-23049-83jwcc/spec.rb:68 # PrivacyFilter filters whole email usernames if too short
rspec /tmp/d20130203-23049-83jwcc/spec.rb:72 # PrivacyFilter does not brake with unicode
rspec /tmp/d20130203-23049-83jwcc/spec.rb:76 # PrivacyFilter filters more complex phone numbers
rspec /tmp/d20130203-23049-83jwcc/spec.rb:89 # PrivacyFilter does not filter invalid phone numbers
rspec /tmp/d20130203-23049-83jwcc/spec.rb:100 # PrivacyFilter preserves whitespace around phones
rspec /tmp/d20130203-23049-83jwcc/spec.rb:104 # PrivacyFilter filters more than one phone or email
rspec /tmp/d20130203-23049-83jwcc/spec.rb:122 # PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
rspec /tmp/d20130203-23049-83jwcc/spec.rb:136 # PrivacyFilter separates preserved country code from filtered phone with a space
rspec /tmp/d20130203-23049-83jwcc/spec.rb:150 # Validations allows validation for emails
rspec /tmp/d20130203-23049-83jwcc/spec.rb:155 # Validations returns boolean true or false
rspec /tmp/d20130203-23049-83jwcc/spec.rb:160 # Validations can validate more complex emails
rspec /tmp/d20130203-23049-83jwcc/spec.rb:175 # Validations does not break on emails in multiline strings
rspec /tmp/d20130203-23049-83jwcc/spec.rb:184 # Validations can validate more complex phone numbers
rspec /tmp/d20130203-23049-83jwcc/spec.rb:214 # Validations does not break on phones in multiline strings
rspec /tmp/d20130203-23049-83jwcc/spec.rb:218 # Validations validates hostnames
rspec /tmp/d20130203-23049-83jwcc/spec.rb:232 # Validations handles multiline strings in hostname validation properly
rspec /tmp/d20130203-23049-83jwcc/spec.rb:244 # Validations handles multiline strings in IP validation properly
rspec /tmp/d20130203-23049-83jwcc/spec.rb:273 # Validations handles multiline strings in numbers validation properly
rspec /tmp/d20130203-23049-83jwcc/spec.rb:294 # Validations handles multiline strings in integer validation properly
rspec /tmp/d20130203-23049-83jwcc/spec.rb:326 # Validations handles newlines in date validation
rspec /tmp/d20130203-23049-83jwcc/spec.rb:331 # Validations validates times
rspec /tmp/d20130203-23049-83jwcc/spec.rb:359 # Validations handles newlines in time and datetime validation

История (1 версия и 0 коментара)

Йоана обнови решението на 28.11.2012 16:32 (преди над 11 години)

+class Validations
+ def self.hostname?(value)
+ if value =~ /^((?<name>(?<no>[0-9A-Za-z])([0-9A-Za-z-]{,60}\g<no>)?)\.)*\g<name>(?<TLD>[A-Za-z]{2,3})(\.\g<TLD>)?$/x
+ return true
+ end
+ false
+ end
+ def self.email?(value)
+ if value =~ /[A-Za-z0-9][A-Za-z0-9_+.-]{,200}@\b/ and Validations.hostname? $'
+ return true
+ end
+ false
+ end
+ def self.phone?(value)
+ if value =~ /^(0|((0{2}|\+)[1-9]{1}\d{2}))(?<separators>[\s\(\)-])*(\d\g<separators>{0,2}){5,10}\d$/
+ return true
+ end
+ false
+ end
+ def self.ip_address?(value)
+ if value =~ /^(?<byte>\d|(\d\d)|(1\d\d)|(2[0-4]\d)|(25[0-5]))(\.\g<byte>){3}$/
+ return true
+ end
+ false
+ end
+ def self.number?(value)
+ if value =~ /^-?(0|([1-9]\d*))(\.\d+)?$/
+ return true
+ end
+ false
+ end
+ def self.integer?(value)
+ if value =~ /^-?(0|([1-9]\d*))$/
+ return true
+ end
+ false
+ end
+ def self.date?(value)
+ if value =~ /^\d{4}-((0[1-9])|(1[0-2]))-((0[1-9])|([1-2]\d)|(3[0-1]))$/
+ return true
+ end
+ false
+ end
+ def self.time?(value)
+ if value =~ /^(\d|(1\d)|(2[0-3]))(?<min>:((0\d)|([1-5]\d)))\g<min>$/
+ return true
+ end
+ false
+ end
+ def self.date_time?(value)
+ date_and_time = value.split(/[ T]/, 2)
+ if Validations.date? date_and_time[0] and Validations.time? date_and_time[1]
+ return true
+ end
+ false
+ end
+end