Решение на Четвърта задача от Христо Владев

Обратно към всички решения

Към профила на Христо Владев

Резултати

  • 3 точки от тестове
  • 0 бонус точки
  • 3 точки общо
  • 18 успешни тест(а)
  • 23 неуспешни тест(а)

Код

class PrivacyFilter
attr_accessor :preserve_phone_country_code,
:preserve_email_hostname,
:partially_preserve_email_username
def initialize(text)
@text = text
@preserve_phone_country_code = false
@preserve_email_hostname = false
@partially_preserve_email_username = false
end
def filtered
end
def to_s
"#{@text}"
end
end
class Validations
class << self
def email?(value)
!!(value =~ /^[a-zA-Z0-9][a-zA-Z0-9_+.-]{0,200}@(.*)$/) and hostname?($1)
end
def hostname?(value)
!!(value =~ /^(([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9-]{0,60}[a-zA-Z0-9])\.)+([a-zA-Z]{2,3})$/)
end
def phone?(value)
!!(value =~ /^(0|(00|\+)[1-9]{1,3})([ ()-]{0,2}\d){6,11}$/)
end
def ip_address?(value)
!!(value =~ /^(([0-9]|[1-9][0-9]|1[0-9]{2}|2([0-4][0-9]|5[0-5]))\.){3}\g<2>$/)
end
def number?(value)
!!(value =~ /^-?(0|[1-9][0-9]*)(\.[0-9]+)?$/)
end
def integer?(value)
!!(value =~ /^-?(0|[1-9][0-9]*)$/)
end
def date?(value)
!!(value =~ /^[0-9]{4}-(0[1-9]|1[0-2])-(0[1-9]|[1-2][0-9]|3[0-1])$/)
end
def time?(value)
!!(value =~ /^([0-1][0-9]|2[0-3])(:[0-5][0-9]){2}$/)
end
def date_time?(value)
!!(value =~ /^(.*)[ T](.*)$/) and date?($1) and time?($2)
end
end
end

Лог от изпълнението

FFFFFFFFFFFFFF...F.FF.F.F..F..F.....F...F

Failures:

  1) PrivacyFilter works with blank or whitespace strings and preserves whitespace
     Failure/Error: filter('').should eq ''
       
       expected: ""
            got: nil
       
       (compared using ==)
     # /tmp/d20130203-23049-5ks0mz/spec.rb:21:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  2) PrivacyFilter obfuscates simple emails
     Failure/Error: filter('Contact: someone@example.com').should eq 'Contact: [EMAIL]'
       
       expected: "Contact: [EMAIL]"
            got: nil
       
       (compared using ==)
     # /tmp/d20130203-23049-5ks0mz/spec.rb:27:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  3) PrivacyFilter obfuscates more complicated emails
     Failure/Error: filter(text).should eq filtered
       
       expected: "[EMAIL]"
            got: nil
       
       (compared using ==)
     # /tmp/d20130203-23049-5ks0mz/spec.rb:40:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-5ks0mz/spec.rb:39:in `each'
     # /tmp/d20130203-23049-5ks0mz/spec.rb:39:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  4) PrivacyFilter does not filter invalid emails
     Failure/Error: filter(text_with_invalid_emails).should eq text_with_invalid_emails
       
       expected: "Contact me here: _invalid@email.com"
            got: nil
       
       (compared using ==)
     # /tmp/d20130203-23049-5ks0mz/spec.rb:52:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-5ks0mz/spec.rb:46:in `each'
     # /tmp/d20130203-23049-5ks0mz/spec.rb:46:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  5) PrivacyFilter allows email hostname to be preserved
     Failure/Error: filter_email_usernames('someone@example.com').should eq '[FILTERED]@example.com'
       
       expected: "[FILTERED]@example.com"
            got: nil
       
       (compared using ==)
     # /tmp/d20130203-23049-5ks0mz/spec.rb:60:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  6) PrivacyFilter allows email usernames to be partially preserved
     Failure/Error: partially_filter_email_usernames('someone@example.com').should eq 'som[FILTERED]@example.com'
       
       expected: "som[FILTERED]@example.com"
            got: nil
       
       (compared using ==)
     # /tmp/d20130203-23049-5ks0mz/spec.rb:65:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  7) PrivacyFilter filters whole email usernames if too short
     Failure/Error: partially_filter_email_usernames('me@example.com').should eq '[FILTERED]@example.com'
       
       expected: "[FILTERED]@example.com"
            got: nil
       
       (compared using ==)
     # /tmp/d20130203-23049-5ks0mz/spec.rb:69:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  8) PrivacyFilter does not brake with unicode
     Failure/Error: partially_filter_email_usernames('За връзка: me@example.com').should eq 'За връзка: [FILTERED]@example.com'
       
       expected: "За връзка: [FILTERED]@example.com"
            got: nil
       
       (compared using ==)
     # /tmp/d20130203-23049-5ks0mz/spec.rb:73:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  9) PrivacyFilter filters more complex phone numbers
     Failure/Error: filter(text).should eq filtered
       
       expected: "Reach me at: [PHONE]"
            got: nil
       
       (compared using ==)
     # /tmp/d20130203-23049-5ks0mz/spec.rb:85:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-5ks0mz/spec.rb:84:in `each'
     # /tmp/d20130203-23049-5ks0mz/spec.rb:84:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  10) PrivacyFilter does not filter invalid phone numbers
     Failure/Error: filter(text).should eq filtered
       
       expected: "Reach me at: 0885123"
            got: nil
       
       (compared using ==)
     # /tmp/d20130203-23049-5ks0mz/spec.rb:96:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-5ks0mz/spec.rb:95:in `each'
     # /tmp/d20130203-23049-5ks0mz/spec.rb:95:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  11) PrivacyFilter preserves whitespace around phones
     Failure/Error: filter(' +359881212-12-1 2 or...').should eq ' [PHONE] or...'
       
       expected: " [PHONE] or..."
            got: nil
       
       (compared using ==)
     # /tmp/d20130203-23049-5ks0mz/spec.rb:101:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  12) PrivacyFilter filters more than one phone or email
     Failure/Error: filter(text).should eq filtered
       
       expected: "\n      Contacts\n\n      Phones: [PHONE] or [PHONE]\n      Email: [EMAIL] or [EMAIL]\n    "
            got: nil
       
       (compared using ==)
     # /tmp/d20130203-23049-5ks0mz/spec.rb:119:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  13) PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
     Failure/Error: filter.filtered.should eq filtered
       
       expected: "Phone: +359 [FILTERED]"
            got: nil
       
       (compared using ==)
     # /tmp/d20130203-23049-5ks0mz/spec.rb:132:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-5ks0mz/spec.rb:129:in `each'
     # /tmp/d20130203-23049-5ks0mz/spec.rb:129:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  14) PrivacyFilter separates preserved country code from filtered phone with a space
     Failure/Error: filter.filtered.should eq filtered
       
       expected: "Phone: 0025 [FILTERED]"
            got: nil
       
       (compared using ==)
     # /tmp/d20130203-23049-5ks0mz/spec.rb:144:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-5ks0mz/spec.rb:141:in `each'
     # /tmp/d20130203-23049-5ks0mz/spec.rb:141:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  15) Validations does not break on emails in multiline strings
     Failure/Error: Validations.email?("foo@bar.com\nwat?").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-5ks0mz/spec.rb:176:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  16) Validations can validate more complex phone numbers
     Failure/Error: Validations.phone?(phone).should be(valid)
       
       expected #<TrueClass:2> => true
            got #<FalseClass:0> => false
       
       Compared using equal?, which compares object identity,
       but expected and actual are not the same object. Use
       'actual.should eq(expected)' if you don't care about
       object identity in this example.
     # /tmp/d20130203-23049-5ks0mz/spec.rb:210:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-5ks0mz/spec.rb:209:in `each'
     # /tmp/d20130203-23049-5ks0mz/spec.rb:209:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  17) Validations does not break on phones in multiline strings
     Failure/Error: Validations.phone?("0885123123\nwat?").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-5ks0mz/spec.rb:215:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  18) Validations handles multiline strings in hostname validation properly
     Failure/Error: Validations.hostname?("foo.com\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-5ks0mz/spec.rb:233:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  19) Validations handles multiline strings in IP validation properly
     Failure/Error: Validations.ip_address?("8.8.8.8\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-5ks0mz/spec.rb:245:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  20) Validations handles multiline strings in numbers validation properly
     Failure/Error: Validations.number?("42\n24").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-5ks0mz/spec.rb:274:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  21) Validations handles multiline strings in integer validation properly
     Failure/Error: Validations.number?("42\n24").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-5ks0mz/spec.rb:295:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  22) Validations handles newlines in date validation
     Failure/Error: Validations.date?("2012-11-19\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-5ks0mz/spec.rb:327:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  23) Validations handles newlines in time and datetime validation
     Failure/Error: Validations.time?("12:01:01\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-5ks0mz/spec.rb:360:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

Finished in 0.0581 seconds
41 examples, 23 failures

Failed examples:

rspec /tmp/d20130203-23049-5ks0mz/spec.rb:20 # PrivacyFilter works with blank or whitespace strings and preserves whitespace
rspec /tmp/d20130203-23049-5ks0mz/spec.rb:26 # PrivacyFilter obfuscates simple emails
rspec /tmp/d20130203-23049-5ks0mz/spec.rb:30 # PrivacyFilter obfuscates more complicated emails
rspec /tmp/d20130203-23049-5ks0mz/spec.rb:44 # PrivacyFilter does not filter invalid emails
rspec /tmp/d20130203-23049-5ks0mz/spec.rb:59 # PrivacyFilter allows email hostname to be preserved
rspec /tmp/d20130203-23049-5ks0mz/spec.rb:64 # PrivacyFilter allows email usernames to be partially preserved
rspec /tmp/d20130203-23049-5ks0mz/spec.rb:68 # PrivacyFilter filters whole email usernames if too short
rspec /tmp/d20130203-23049-5ks0mz/spec.rb:72 # PrivacyFilter does not brake with unicode
rspec /tmp/d20130203-23049-5ks0mz/spec.rb:76 # PrivacyFilter filters more complex phone numbers
rspec /tmp/d20130203-23049-5ks0mz/spec.rb:89 # PrivacyFilter does not filter invalid phone numbers
rspec /tmp/d20130203-23049-5ks0mz/spec.rb:100 # PrivacyFilter preserves whitespace around phones
rspec /tmp/d20130203-23049-5ks0mz/spec.rb:104 # PrivacyFilter filters more than one phone or email
rspec /tmp/d20130203-23049-5ks0mz/spec.rb:122 # PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
rspec /tmp/d20130203-23049-5ks0mz/spec.rb:136 # PrivacyFilter separates preserved country code from filtered phone with a space
rspec /tmp/d20130203-23049-5ks0mz/spec.rb:175 # Validations does not break on emails in multiline strings
rspec /tmp/d20130203-23049-5ks0mz/spec.rb:184 # Validations can validate more complex phone numbers
rspec /tmp/d20130203-23049-5ks0mz/spec.rb:214 # Validations does not break on phones in multiline strings
rspec /tmp/d20130203-23049-5ks0mz/spec.rb:232 # Validations handles multiline strings in hostname validation properly
rspec /tmp/d20130203-23049-5ks0mz/spec.rb:244 # Validations handles multiline strings in IP validation properly
rspec /tmp/d20130203-23049-5ks0mz/spec.rb:273 # Validations handles multiline strings in numbers validation properly
rspec /tmp/d20130203-23049-5ks0mz/spec.rb:294 # Validations handles multiline strings in integer validation properly
rspec /tmp/d20130203-23049-5ks0mz/spec.rb:326 # Validations handles newlines in date validation
rspec /tmp/d20130203-23049-5ks0mz/spec.rb:359 # Validations handles newlines in time and datetime validation

История (1 версия и 0 коментара)

Христо обнови решението на 28.11.2012 16:53 (преди над 11 години)

+class PrivacyFilter
+ attr_accessor :preserve_phone_country_code,
+ :preserve_email_hostname,
+ :partially_preserve_email_username
+
+ def initialize(text)
+ @text = text
+
+ @preserve_phone_country_code = false
+ @preserve_email_hostname = false
+ @partially_preserve_email_username = false
+ end
+
+ def filtered
+
+ end
+
+ def to_s
+ "#{@text}"
+ end
+end
+
+class Validations
+ class << self
+ def email?(value)
+ !!(value =~ /^[a-zA-Z0-9][a-zA-Z0-9_+.-]{0,200}@(.*)$/) and hostname?($1)
+ end
+
+ def hostname?(value)
+ !!(value =~ /^(([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9-]{0,60}[a-zA-Z0-9])\.)+([a-zA-Z]{2,3})$/)
+ end
+
+ def phone?(value)
+ !!(value =~ /^(0|(00|\+)[1-9]{1,3})([ ()-]{0,2}\d){6,11}$/)
+ end
+
+ def ip_address?(value)
+ !!(value =~ /^(([0-9]|[1-9][0-9]|1[0-9]{2}|2([0-4][0-9]|5[0-5]))\.){3}\g<2>$/)
+ end
+
+ def number?(value)
+ !!(value =~ /^-?(0|[1-9][0-9]*)(\.[0-9]+)?$/)
+ end
+
+ def integer?(value)
+ !!(value =~ /^-?(0|[1-9][0-9]*)$/)
+ end
+
+ def date?(value)
+ !!(value =~ /^[0-9]{4}-(0[1-9]|1[0-2])-(0[1-9]|[1-2][0-9]|3[0-1])$/)
+ end
+
+ def time?(value)
+ !!(value =~ /^([0-1][0-9]|2[0-3])(:[0-5][0-9]){2}$/)
+ end
+
+ def date_time?(value)
+ !!(value =~ /^(.*)[ T](.*)$/) and date?($1) and time?($2)
+ end
+ end
+end