Решение на Четвърта задача от Филарета Йорданова
Обратно към всички решения
Към профила на Филарета Йорданова
Резултати
- 2 точки от тестове
- 0 бонус точки
- 2 точки общо
- 12 успешни тест(а)
- 29 неуспешни тест(а)
Код
Лог от изпълнението
F.FFF.FFFFFFFF..FF.FFFF.FFFF.FF.F.F.F..FF
Failures:
1) PrivacyFilter works with blank or whitespace strings and preserves whitespace
Failure/Error: filter('').should eq ''
expected: ""
got: nil
(compared using ==)
# /tmp/d20130203-23049-19a7c8g/spec.rb:21:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
2) PrivacyFilter obfuscates more complicated emails
Failure/Error: PrivacyFilter.new(text).filtered
NoMethodError:
undefined method `+' for nil:NilClass
# /tmp/d20130203-23049-19a7c8g/solution.rb:93:in `filter_email_all'
# /tmp/d20130203-23049-19a7c8g/solution.rb:87:in `filter_email'
# /tmp/d20130203-23049-19a7c8g/solution.rb:126:in `filtered'
# /tmp/d20130203-23049-19a7c8g/spec.rb:5:in `filter'
# /tmp/d20130203-23049-19a7c8g/spec.rb:40:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-19a7c8g/spec.rb:39:in `each'
# /tmp/d20130203-23049-19a7c8g/spec.rb:39:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
3) PrivacyFilter does not filter invalid emails
Failure/Error: filter(text_with_invalid_emails).should eq text_with_invalid_emails
expected: "Contact me here: _invalid@email.com"
got: "Contact me here: [EMAIL]"
(compared using ==)
# /tmp/d20130203-23049-19a7c8g/spec.rb:52:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-19a7c8g/spec.rb:46:in `each'
# /tmp/d20130203-23049-19a7c8g/spec.rb:46:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
4) PrivacyFilter allows email hostname to be preserved
Failure/Error: filter_email_usernames('some12-+3@exa.mple.com').should eq '[FILTERED]@exa.mple.com'
expected: "[FILTERED]@exa.mple.com"
got: nil
(compared using ==)
# /tmp/d20130203-23049-19a7c8g/spec.rb:61:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
5) PrivacyFilter filters whole email usernames if too short
Failure/Error: filter.filtered
NoMethodError:
undefined method `+' for nil:NilClass
# /tmp/d20130203-23049-19a7c8g/solution.rb:98:in `filter_email_partially'
# /tmp/d20130203-23049-19a7c8g/solution.rb:85:in `filter_email'
# /tmp/d20130203-23049-19a7c8g/solution.rb:126:in `filtered'
# /tmp/d20130203-23049-19a7c8g/spec.rb:17:in `partially_filter_email_usernames'
# /tmp/d20130203-23049-19a7c8g/spec.rb:69:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
6) PrivacyFilter does not brake with unicode
Failure/Error: partially_filter_email_usernames('За връзка: me@example.com').should eq 'За връзка: [FILTERED]@example.com'
expected: "За връзка: [FILTERED]@example.com"
got: "За [FILTERED]@example.com"
(compared using ==)
# /tmp/d20130203-23049-19a7c8g/spec.rb:73:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
7) PrivacyFilter filters more complex phone numbers
Failure/Error: PrivacyFilter.new(text).filtered
NoMethodError:
undefined method `+' for nil:NilClass
# /tmp/d20130203-23049-19a7c8g/solution.rb:113:in `filter_phone_all'
# /tmp/d20130203-23049-19a7c8g/solution.rb:120:in `filter_phone'
# /tmp/d20130203-23049-19a7c8g/solution.rb:125:in `filtered'
# /tmp/d20130203-23049-19a7c8g/spec.rb:5:in `filter'
# /tmp/d20130203-23049-19a7c8g/spec.rb:85:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-19a7c8g/spec.rb:84:in `each'
# /tmp/d20130203-23049-19a7c8g/spec.rb:84:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
8) PrivacyFilter does not filter invalid phone numbers
Failure/Error: filter(text).should eq filtered
expected: "Reach me at: 0885123"
got: "Reach me at: [PHONE]"
(compared using ==)
# /tmp/d20130203-23049-19a7c8g/spec.rb:96:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-19a7c8g/spec.rb:95:in `each'
# /tmp/d20130203-23049-19a7c8g/spec.rb:95:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
9) PrivacyFilter preserves whitespace around phones
Failure/Error: filter(' +359881212-12-1 2 or...').should eq ' [PHONE] or...'
expected: " [PHONE] or..."
got: nil
(compared using ==)
# /tmp/d20130203-23049-19a7c8g/spec.rb:101:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
10) PrivacyFilter filters more than one phone or email
Failure/Error: filter(text).should eq filtered
expected: "\n Contacts\n\n Phones: [PHONE] or [PHONE]\n Email: [EMAIL] or [EMAIL]\n "
got: " Phones: +1 (555) 123-456-99 or [PHONE]"
(compared using ==)
Diff:
@@ -1,7 +1,2 @@
-
- Contacts
-
- Phones: [PHONE] or [PHONE]
- Email: [EMAIL] or [EMAIL]
-
+ Phones: +1 (555) 123-456-99 or [PHONE]
# /tmp/d20130203-23049-19a7c8g/spec.rb:119:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
11) PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
Failure/Error: filter.filtered.should eq filtered
expected: "Phone: [PHONE]"
got: "Phone: 0882 [FILTERED]"
(compared using ==)
# /tmp/d20130203-23049-19a7c8g/spec.rb:132:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-19a7c8g/spec.rb:129:in `each'
# /tmp/d20130203-23049-19a7c8g/spec.rb:129:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
12) PrivacyFilter separates preserved country code from filtered phone with a space
Failure/Error: filter.filtered.should eq filtered
NoMethodError:
undefined method `+' for nil:NilClass
# /tmp/d20130203-23049-19a7c8g/solution.rb:113:in `filter_phone_all'
# /tmp/d20130203-23049-19a7c8g/solution.rb:120:in `filter_phone'
# /tmp/d20130203-23049-19a7c8g/solution.rb:125:in `filtered'
# /tmp/d20130203-23049-19a7c8g/spec.rb:144:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-19a7c8g/spec.rb:141:in `each'
# /tmp/d20130203-23049-19a7c8g/spec.rb:141:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
13) Validations can validate more complex emails
Failure/Error: Validations.email?(email).should be(valid)
expected #<FalseClass:0> => false
got #<TrueClass:2> => true
Compared using equal?, which compares object identity,
but expected and actual are not the same object. Use
'actual.should eq(expected)' if you don't care about
object identity in this example.
# /tmp/d20130203-23049-19a7c8g/spec.rb:171:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-19a7c8g/spec.rb:170:in `each'
# /tmp/d20130203-23049-19a7c8g/spec.rb:170:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
14) Validations does not break on emails in multiline strings
Failure/Error: Validations.email?("foo@bar.com\nwat?").should be_false
expected: false value
got: true
# /tmp/d20130203-23049-19a7c8g/spec.rb:176:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
15) Validations can validate more complex phone numbers
Failure/Error: Validations.phone?(phone).should be(valid)
expected #<FalseClass:0> => false
got #<TrueClass:2> => true
Compared using equal?, which compares object identity,
but expected and actual are not the same object. Use
'actual.should eq(expected)' if you don't care about
object identity in this example.
# /tmp/d20130203-23049-19a7c8g/spec.rb:210:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-19a7c8g/spec.rb:209:in `each'
# /tmp/d20130203-23049-19a7c8g/spec.rb:209:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
16) Validations does not break on phones in multiline strings
Failure/Error: Validations.phone?("0885123123\nwat?").should be_false
expected: false value
got: true
# /tmp/d20130203-23049-19a7c8g/spec.rb:215:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
17) Validations validates hostnames
Failure/Error: Validations.hostname?('x.io').should be_true
expected: true value
got: false
# /tmp/d20130203-23049-19a7c8g/spec.rb:223:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
18) Validations handles multiline strings in hostname validation properly
Failure/Error: Validations.hostname?("foo.com\n").should be_false
expected: false value
got: true
# /tmp/d20130203-23049-19a7c8g/spec.rb:233:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
19) Validations handles multiline strings in IP validation properly
Failure/Error: Validations.ip_address?("8.8.8.8\n").should be_false
expected: false value
got: true
# /tmp/d20130203-23049-19a7c8g/spec.rb:245:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
20) Validations validates numbers
Failure/Error: Validations.number?('9').should be_true
expected: true value
got: false
# /tmp/d20130203-23049-19a7c8g/spec.rb:254:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
21) Validations validates more complex numbers
Failure/Error: Validations.number?('0').should be_true
expected: true value
got: false
# /tmp/d20130203-23049-19a7c8g/spec.rb:262:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
22) Validations handles multiline strings in numbers validation properly
Failure/Error: Validations.number?("42\n24").should be_false
expected: false value
got: true
# /tmp/d20130203-23049-19a7c8g/spec.rb:274:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
23) Validations validates more complex integers
Failure/Error: Validations.integer?('00').should be_false
expected: false value
got: true
# /tmp/d20130203-23049-19a7c8g/spec.rb:286:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
24) Validations handles multiline strings in integer validation properly
Failure/Error: Validations.number?("42\n24").should be_false
expected: false value
got: true
# /tmp/d20130203-23049-19a7c8g/spec.rb:295:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
25) Validations allows zero years in date validation
Failure/Error: Validations.date?('0000-01-01').should be_true
expected: true value
got: false
# /tmp/d20130203-23049-19a7c8g/spec.rb:307:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
26) Validations does not allow zero months or days in dates
Failure/Error: Validations.date?('1000-01-00').should be_false
expected: false value
got: true
# /tmp/d20130203-23049-19a7c8g/spec.rb:316:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
27) Validations handles newlines in date validation
Failure/Error: Validations.date?("2012-11-19\n").should be_false
expected: false value
got: true
# /tmp/d20130203-23049-19a7c8g/spec.rb:327:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
28) Validations validates datetime values
Failure/Error: Validations.date_time?('2012-01-00T23:59:00').should be_false
expected: false value
got: true
# /tmp/d20130203-23049-19a7c8g/spec.rb:353:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
29) Validations handles newlines in time and datetime validation
Failure/Error: Validations.time?("12:01:01\n").should be_false
expected: false value
got: true
# /tmp/d20130203-23049-19a7c8g/spec.rb:360:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
Finished in 0.05091 seconds
41 examples, 29 failures
Failed examples:
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:20 # PrivacyFilter works with blank or whitespace strings and preserves whitespace
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:30 # PrivacyFilter obfuscates more complicated emails
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:44 # PrivacyFilter does not filter invalid emails
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:59 # PrivacyFilter allows email hostname to be preserved
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:68 # PrivacyFilter filters whole email usernames if too short
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:72 # PrivacyFilter does not brake with unicode
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:76 # PrivacyFilter filters more complex phone numbers
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:89 # PrivacyFilter does not filter invalid phone numbers
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:100 # PrivacyFilter preserves whitespace around phones
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:104 # PrivacyFilter filters more than one phone or email
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:122 # PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:136 # PrivacyFilter separates preserved country code from filtered phone with a space
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:160 # Validations can validate more complex emails
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:175 # Validations does not break on emails in multiline strings
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:184 # Validations can validate more complex phone numbers
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:214 # Validations does not break on phones in multiline strings
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:218 # Validations validates hostnames
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:232 # Validations handles multiline strings in hostname validation properly
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:244 # Validations handles multiline strings in IP validation properly
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:250 # Validations validates numbers
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:257 # Validations validates more complex numbers
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:273 # Validations handles multiline strings in numbers validation properly
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:283 # Validations validates more complex integers
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:294 # Validations handles multiline strings in integer validation properly
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:306 # Validations allows zero years in date validation
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:314 # Validations does not allow zero months or days in dates
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:326 # Validations handles newlines in date validation
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:347 # Validations validates datetime values
rspec /tmp/d20130203-23049-19a7c8g/spec.rb:359 # Validations handles newlines in time and datetime validation
История (1 версия и 0 коментара)
Филарета обнови решението на 24.11.2012 00:59 (преди почти 12 години)