Програмиране с Ruby

Курс във Факултета по Математика и Информатика към СУ

Решение на Четвърта задача от Виктория Христова

Обратно към всички решения

Към профила на Виктория Христова

Резултати

  • 4 точки от тестове
  • 0 бонус точки
  • 4 точки общо
  • 28 успешни тест(а)
  • 13 неуспешни тест(а)

Код

module Validations
def self.email?(value)
value =~ /\A[a-zA-Z\d][\w\+\.-]{,200}@(.*)\z/
hostname? $1
end
def self.phone?(value)
value =~ /\A(((00|\+)[1-9]\d\d[- \(\)]{,2}\d)|0{1}[- \(\)]{,2}[1-9])([- \(\)]{,2}\d){5,10}\z/ ? true : false
end
def self.hostname?(value)
value =~ /\A([a-zA-Z\d]([a-zA-Z\d-]{,61}[a-zA-Z\d])?\.)+[a-zA-Z]{2,3}(\.[a-zA-Z]{2})?\z/ ? true : false
end
def self.ip_address?(value)
value =~ /\A((\d|\d\d|1\d\d|2([0-4]\d|5[0-5]))\.){3}(\d|\d\d|1\d\d|2([0-4]\d|5[0-5]))\z/ ? true : false
end
def self.number?(value)
value =~ /\A-?(0|[1-9][0-9]*)(\.\d+)?\z/ ? true : false
end
def self.integer?(value)
value =~ /\A-?(0|[1-9][0-9]*)\z/ ? true : false
end
def self.date?(value)
value =~ /\A\d{4}\-(0\d|1[0-2])\-([0-2]\d|3[01])\z/ ? true : false
end
def self.time?(value)
value =~ /\A([01]\d|2[0-3])(:[0-5]\d){2}\z/ ? true : false
end
def self.date_time?(value)
value =~ /(.*)[ T](.*)/
date? $1 and time? $2
end
end
class PrivacyFilter
attr_accessor :text, :preserve_phone_country_code, :preserve_email_hostname, :partially_preserve_email_username
def initialize(text)
@text = text
@preserve_phone_country_code = false
@preserve_email_hostname = false
@partially_preserve_email_username = false
end
def filtered
filter_emails
filter_emails_partially
filter_phones
end
def filter_emails
email = /[a-zA-Z\d][\w\+\.-]{,200}@(([a-zA-Z\d]([a-zA-Z\d-]{,61}[a-zA-Z\d])?\.)+[a-zA-Z]{2,3}(\.[a-zA-Z]{2})?)/
text.gsub!(email, '[EMAIL]') if preserve_email_hostname == false and partially_preserve_email_username == false
if partially_preserve_email_username == false and preserve_email_hostname == true
text.gsub!(email, '[FILTERED]@\1')
end
end
def filter_emails_partially
e = /(\p{Alnum}[+\w.-]{2})[+\w.-]{4,198}@((\p{Alnum}([a-zA-Z\d-]{,61}\p{Alnum})?\.)+[a-zA-Z]{2,3}(\.[a-zA-Z]{2})?)/
text.gsub!(e, '\1[FILTERED]@\2')
email = /[a-zA-Z\d][\w\+\.-]{,5}@(([a-zA-Z\d]([a-zA-Z\d-]{,61}[a-zA-Z\d])?\.)+[a-zA-Z]{2,3}(\.[a-zA-Z]{2})?)/
text.gsub!(email, ' [FILTERED]@\1')
end
def filter_phones
text.gsub!(/([^@](00|\+)[1-9]\d\d)([- \(\)]{,2}\d){6,11}/,'\1 [FILTERED]') if preserve_phone_country_code == true
text.gsub!(/([^@](00|\+)[1-9]\d\d)([- \(\)]{,2}\d){6,11}/,'[PHONE]')
text.gsub!(/([^@])0([- \(\)]{,2}[1-9])([- \(\)]{,2}\d){5,10}/,'\1[PHONE]') or text
end
end

Лог от изпълнението

..F...FFFFFFFF.....F..............F....FF

Failures:

  1) PrivacyFilter obfuscates more complicated emails
     Failure/Error: PrivacyFilter.new(text).filtered
     RuntimeError:
       can't modify frozen String
     # /tmp/d20130203-23049-eyqv5n/solution.rb:59:in `gsub!'
     # /tmp/d20130203-23049-eyqv5n/solution.rb:59:in `filter_emails'
     # /tmp/d20130203-23049-eyqv5n/solution.rb:52:in `filtered'
     # /tmp/d20130203-23049-eyqv5n/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-eyqv5n/spec.rb:40:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-eyqv5n/spec.rb:39:in `each'
     # /tmp/d20130203-23049-eyqv5n/spec.rb:39:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  2) PrivacyFilter filters whole email usernames if too short
     Failure/Error: partially_filter_email_usernames('me@example.com').should eq '[FILTERED]@example.com'
       
       expected: "[FILTERED]@example.com"
            got: " [FILTERED]@example.com"
       
       (compared using ==)
     # /tmp/d20130203-23049-eyqv5n/spec.rb:69:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  3) PrivacyFilter does not brake with unicode
     Failure/Error: filter.filtered
     Encoding::CompatibilityError:
       incompatible encoding regexp match (ASCII-8BIT regexp with UTF-8 string)
     # /tmp/d20130203-23049-eyqv5n/solution.rb:67:in `gsub!'
     # /tmp/d20130203-23049-eyqv5n/solution.rb:67:in `filter_emails_partially'
     # /tmp/d20130203-23049-eyqv5n/solution.rb:53:in `filtered'
     # /tmp/d20130203-23049-eyqv5n/spec.rb:17:in `partially_filter_email_usernames'
     # /tmp/d20130203-23049-eyqv5n/spec.rb:73:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  4) PrivacyFilter filters more complex phone numbers
     Failure/Error: PrivacyFilter.new(text).filtered
     RuntimeError:
       can't modify frozen String
     # /tmp/d20130203-23049-eyqv5n/solution.rb:59:in `gsub!'
     # /tmp/d20130203-23049-eyqv5n/solution.rb:59:in `filter_emails'
     # /tmp/d20130203-23049-eyqv5n/solution.rb:52:in `filtered'
     # /tmp/d20130203-23049-eyqv5n/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-eyqv5n/spec.rb:85:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-eyqv5n/spec.rb:84:in `each'
     # /tmp/d20130203-23049-eyqv5n/spec.rb:84:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  5) PrivacyFilter does not filter invalid phone numbers
     Failure/Error: PrivacyFilter.new(text).filtered
     RuntimeError:
       can't modify frozen String
     # /tmp/d20130203-23049-eyqv5n/solution.rb:59:in `gsub!'
     # /tmp/d20130203-23049-eyqv5n/solution.rb:59:in `filter_emails'
     # /tmp/d20130203-23049-eyqv5n/solution.rb:52:in `filtered'
     # /tmp/d20130203-23049-eyqv5n/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-eyqv5n/spec.rb:96:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-eyqv5n/spec.rb:95:in `each'
     # /tmp/d20130203-23049-eyqv5n/spec.rb:95:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  6) PrivacyFilter preserves whitespace around phones
     Failure/Error: filter(' +359881212-12-1 2 or...').should eq ' [PHONE] or...'
       
       expected: " [PHONE] or..."
            got: "[PHONE] or..."
       
       (compared using ==)
     # /tmp/d20130203-23049-eyqv5n/spec.rb:101:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  7) PrivacyFilter filters more than one phone or email
     Failure/Error: filter(text).should eq filtered
       
       expected: "\n      Contacts\n\n      Phones: [PHONE] or [PHONE]\n      Email: [EMAIL] or [EMAIL]\n    "
            got: "\n      Contacts\n\n      Phones: +1 (555) 123-456-99 or[PHONE]\n      Email: [EMAIL] or [EMAIL]\n    "
       
       (compared using ==)
       
       Diff:
       @@ -1,7 +1,7 @@
        
              Contacts
        
       -      Phones: [PHONE] or [PHONE]
       +      Phones: +1 (555) 123-456-99 or[PHONE]
              Email: [EMAIL] or [EMAIL]
            
     # /tmp/d20130203-23049-eyqv5n/spec.rb:119:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  8) PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
     Failure/Error: filter.filtered.should eq filtered
     RuntimeError:
       can't modify frozen String
     # /tmp/d20130203-23049-eyqv5n/solution.rb:59:in `gsub!'
     # /tmp/d20130203-23049-eyqv5n/solution.rb:59:in `filter_emails'
     # /tmp/d20130203-23049-eyqv5n/solution.rb:52:in `filtered'
     # /tmp/d20130203-23049-eyqv5n/spec.rb:132:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-eyqv5n/spec.rb:129:in `each'
     # /tmp/d20130203-23049-eyqv5n/spec.rb:129:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  9) PrivacyFilter separates preserved country code from filtered phone with a space
     Failure/Error: filter.filtered.should eq filtered
     RuntimeError:
       can't modify frozen String
     # /tmp/d20130203-23049-eyqv5n/solution.rb:59:in `gsub!'
     # /tmp/d20130203-23049-eyqv5n/solution.rb:59:in `filter_emails'
     # /tmp/d20130203-23049-eyqv5n/solution.rb:52:in `filtered'
     # /tmp/d20130203-23049-eyqv5n/spec.rb:144:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-eyqv5n/spec.rb:141:in `each'
     # /tmp/d20130203-23049-eyqv5n/spec.rb:141:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  10) Validations can validate more complex phone numbers
     Failure/Error: Validations.phone?(phone).should be(valid)
       
       expected #<TrueClass:2> => true
            got #<FalseClass:0> => false
       
       Compared using equal?, which compares object identity,
       but expected and actual are not the same object. Use
       'actual.should eq(expected)' if you don't care about
       object identity in this example.
     # /tmp/d20130203-23049-eyqv5n/spec.rb:210:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-eyqv5n/spec.rb:209:in `each'
     # /tmp/d20130203-23049-eyqv5n/spec.rb:209:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  11) Validations does not allow zero months or days in dates
     Failure/Error: Validations.date?('1000-00-01').should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-eyqv5n/spec.rb:315:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  12) Validations validates datetime values
     Failure/Error: Validations.date_time?('2012-00-19T23:59:00').should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-eyqv5n/spec.rb:352:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  13) Validations handles newlines in time and datetime validation
     Failure/Error: Validations.date_time?("2012-11-19 12:01:01\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-eyqv5n/spec.rb:362:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

Finished in 0.05686 seconds
41 examples, 13 failures

Failed examples:

rspec /tmp/d20130203-23049-eyqv5n/spec.rb:30 # PrivacyFilter obfuscates more complicated emails
rspec /tmp/d20130203-23049-eyqv5n/spec.rb:68 # PrivacyFilter filters whole email usernames if too short
rspec /tmp/d20130203-23049-eyqv5n/spec.rb:72 # PrivacyFilter does not brake with unicode
rspec /tmp/d20130203-23049-eyqv5n/spec.rb:76 # PrivacyFilter filters more complex phone numbers
rspec /tmp/d20130203-23049-eyqv5n/spec.rb:89 # PrivacyFilter does not filter invalid phone numbers
rspec /tmp/d20130203-23049-eyqv5n/spec.rb:100 # PrivacyFilter preserves whitespace around phones
rspec /tmp/d20130203-23049-eyqv5n/spec.rb:104 # PrivacyFilter filters more than one phone or email
rspec /tmp/d20130203-23049-eyqv5n/spec.rb:122 # PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
rspec /tmp/d20130203-23049-eyqv5n/spec.rb:136 # PrivacyFilter separates preserved country code from filtered phone with a space
rspec /tmp/d20130203-23049-eyqv5n/spec.rb:184 # Validations can validate more complex phone numbers
rspec /tmp/d20130203-23049-eyqv5n/spec.rb:314 # Validations does not allow zero months or days in dates
rspec /tmp/d20130203-23049-eyqv5n/spec.rb:347 # Validations validates datetime values
rspec /tmp/d20130203-23049-eyqv5n/spec.rb:359 # Validations handles newlines in time and datetime validation

История (2 версии и 0 коментара)

Виктория обнови решението на 25.11.2012 13:56 (преди почти 12 години)

+module Validations
+ def self.email?(value)
+ value =~ /\A[a-zA-Z\d][\w\+\.-]{,200}@(.*)\z/
+ hostname? $1
+ end
+
+ def self.phone?(value)
+ value =~ /\A(((00|\+)[1-9]\d\d[- \(\)]{,2}\d)|0{1}[- \(\)]{,2}[1-9])([- \(\)]{,2}\d){5,10}\z/ ? true : false
+ end
+
+ def self.hostname?(value)
+ value =~ /\A([a-zA-Z\d]([a-zA-Z\d-]{,60}[a-zA-Z\d])?\.)+[a-zA-Z]{2,3}(\.[a-zA-Z]{2})?\z/ ? true : false
+ end
+
+ def self.ip_address?(value)
+ value =~ /\A((\d|\d\d|1\d\d|2([0-4]\d|5[0-5]))\.){3}(\d|\d\d|1\d\d|2([0-4]\d|5[0-5]))\z/ ? true : false
+ end
+
+ def self.number?(value)
+ value =~ /\A-?(0|[1-9][0-9]*)(\.\d+)?\z/ ? true : false
+ end
+
+ def self.integer?(value)
+ value =~ /\A-?(0|[1-9][0-9]*)\z/ ? true : false
+ end
+
+ def self.date?(value)
+ value =~ /\A\d{4}\-(0\d|1[0-2])\-([0-2]\d|3[01])\z/ ? true : false
+ end
+
+ def self.time?(value)
+ value =~ /\A([01]\d|2[0-3])(:[0-5]\d){2}\z/ ? true : false
+ end
+
+ def self.date_time?(value)
+ value =~ /(.*)[ T](.*)/
+ date? $1 and time? $2
+ end
+end
+
+class PrivacyFilter
+ include Validations
+
+ attr_accessor :text, :preserve_phone_country_code, :preserve_email_hostname, :partially_preserve_email_username
+
+ def initialize(text)
+ @text = text
+ @preserve_phone_country_code = false
+ @preserve_email_hostname = false
+ @partially_preserve_email_username = false
+ end
+
+ def filtered
+ filter_emails
+ filter_emails_partially
+ filter_phones
+ end
+
+ def filter_emails
+ email = /[a-zA-Z\d][\w\+\.-]{,200}@(([a-zA-Z\d]([a-zA-Z\d-]{,60}[a-zA-Z\d])?\.)+[a-zA-Z]{2,3}(\.[a-zA-Z]{2})?)/
+ text.gsub!(email, '[EMAIL]') if preserve_email_hostname == false and partially_preserve_email_username == false
+ if partially_preserve_email_username == false and preserve_email_hostname == true
+ text.gsub!(email, '[FILTERED]@\1')
+ end
+ end
+
+ def filter_emails_partially
+ e = /(\p{Alnum}[+\w.-]{2})[+\w.-]{4,198}@((\p{Alnum}([a-zA-Z\d-]{,60}\p{Alnum})?\.)+[a-zA-Z]{2,3}(\.[a-zA-Z]{2})?)/
+ text.gsub!(e, '\1[FILTERED]@\2')
+ email = /[a-zA-Z\d][\w\+\.-]{,5}@(([a-zA-Z\d]([a-zA-Z\d-]{,60}[a-zA-Z\d])?\.)+[a-zA-Z]{2,3}(\.[a-zA-Z]{2})?)/
+ text.gsub!(email, ' [FILTERED]@\1')
+ end
+
+ def filter_phones
+ text.gsub!(/([^@](00|\+)[1-9]\d\d)([- \(\)]{,2}\d){6,11}/,'\1 [FILTERED]') if preserve_phone_country_code == true
+ text.gsub!(/([^@](00|\+)[1-9]\d\d)([- \(\)]{,2}\d){6,11}/,'[PHONE]')
+ text.gsub!(/([^@])0([- \(\)]{,2}[1-9])([- \(\)]{,2}\d){5,10}/,'\1[PHONE]') or text
+ end
+end

Виктория обнови решението на 28.11.2012 13:12 (преди почти 12 години)

module Validations
def self.email?(value)
value =~ /\A[a-zA-Z\d][\w\+\.-]{,200}@(.*)\z/
hostname? $1
end
def self.phone?(value)
value =~ /\A(((00|\+)[1-9]\d\d[- \(\)]{,2}\d)|0{1}[- \(\)]{,2}[1-9])([- \(\)]{,2}\d){5,10}\z/ ? true : false
end
def self.hostname?(value)
- value =~ /\A([a-zA-Z\d]([a-zA-Z\d-]{,60}[a-zA-Z\d])?\.)+[a-zA-Z]{2,3}(\.[a-zA-Z]{2})?\z/ ? true : false
+ value =~ /\A([a-zA-Z\d]([a-zA-Z\d-]{,61}[a-zA-Z\d])?\.)+[a-zA-Z]{2,3}(\.[a-zA-Z]{2})?\z/ ? true : false
end
def self.ip_address?(value)
value =~ /\A((\d|\d\d|1\d\d|2([0-4]\d|5[0-5]))\.){3}(\d|\d\d|1\d\d|2([0-4]\d|5[0-5]))\z/ ? true : false
end
def self.number?(value)
value =~ /\A-?(0|[1-9][0-9]*)(\.\d+)?\z/ ? true : false
end
def self.integer?(value)
value =~ /\A-?(0|[1-9][0-9]*)\z/ ? true : false
end
def self.date?(value)
value =~ /\A\d{4}\-(0\d|1[0-2])\-([0-2]\d|3[01])\z/ ? true : false
end
def self.time?(value)
value =~ /\A([01]\d|2[0-3])(:[0-5]\d){2}\z/ ? true : false
end
def self.date_time?(value)
value =~ /(.*)[ T](.*)/
date? $1 and time? $2
end
end
class PrivacyFilter
- include Validations
-
attr_accessor :text, :preserve_phone_country_code, :preserve_email_hostname, :partially_preserve_email_username
def initialize(text)
@text = text
@preserve_phone_country_code = false
@preserve_email_hostname = false
@partially_preserve_email_username = false
end
def filtered
filter_emails
filter_emails_partially
filter_phones
end
def filter_emails
- email = /[a-zA-Z\d][\w\+\.-]{,200}@(([a-zA-Z\d]([a-zA-Z\d-]{,60}[a-zA-Z\d])?\.)+[a-zA-Z]{2,3}(\.[a-zA-Z]{2})?)/
+ email = /[a-zA-Z\d][\w\+\.-]{,200}@(([a-zA-Z\d]([a-zA-Z\d-]{,61}[a-zA-Z\d])?\.)+[a-zA-Z]{2,3}(\.[a-zA-Z]{2})?)/
text.gsub!(email, '[EMAIL]') if preserve_email_hostname == false and partially_preserve_email_username == false
if partially_preserve_email_username == false and preserve_email_hostname == true
text.gsub!(email, '[FILTERED]@\1')
end
end
def filter_emails_partially
- e = /(\p{Alnum}[+\w.-]{2})[+\w.-]{4,198}@((\p{Alnum}([a-zA-Z\d-]{,60}\p{Alnum})?\.)+[a-zA-Z]{2,3}(\.[a-zA-Z]{2})?)/
+ e = /(\p{Alnum}[+\w.-]{2})[+\w.-]{4,198}@((\p{Alnum}([a-zA-Z\d-]{,61}\p{Alnum})?\.)+[a-zA-Z]{2,3}(\.[a-zA-Z]{2})?)/
text.gsub!(e, '\1[FILTERED]@\2')
- email = /[a-zA-Z\d][\w\+\.-]{,5}@(([a-zA-Z\d]([a-zA-Z\d-]{,60}[a-zA-Z\d])?\.)+[a-zA-Z]{2,3}(\.[a-zA-Z]{2})?)/
+ email = /[a-zA-Z\d][\w\+\.-]{,5}@(([a-zA-Z\d]([a-zA-Z\d-]{,61}[a-zA-Z\d])?\.)+[a-zA-Z]{2,3}(\.[a-zA-Z]{2})?)/
text.gsub!(email, ' [FILTERED]@\1')
end
def filter_phones
text.gsub!(/([^@](00|\+)[1-9]\d\d)([- \(\)]{,2}\d){6,11}/,'\1 [FILTERED]') if preserve_phone_country_code == true
text.gsub!(/([^@](00|\+)[1-9]\d\d)([- \(\)]{,2}\d){6,11}/,'[PHONE]')
text.gsub!(/([^@])0([- \(\)]{,2}[1-9])([- \(\)]{,2}\d){5,10}/,'\1[PHONE]') or text
end
end