Решение на Четвърта задача от Николай Колев

Обратно към всички решения

Към профила на Николай Колев

Резултати

  • 4 точки от тестове
  • 0 бонус точки
  • 4 точки общо
  • 28 успешни тест(а)
  • 13 неуспешни тест(а)

Код

class Regexp
def +(other)
Regexp.new(source + other.source)
end
def exact_regex
/\A/ + self + /\z/
end
end
class Validations
HOSTNAME_REGEX = /((\w(\w|-){,61}\w?\.)+[[:alpha:]]{2,3}(\.[[:alpha:]]{2,3})?)/
EMAIL_USERNAME = /\w(\w|_|\+|\.|-){,200}/
EMAIL_REGEX = EMAIL_USERNAME + /(@)/ + HOSTNAME_REGEX
EMAIL_SHORT_USERNAME = /(\b\w(\w|_|\+|\.|-){,4})/ + /@/ + HOSTNAME_REGEX
EMAIL_LONG_USERNAME = /(\w(\w|_|\+|\.|-){2})((\w|_|\+|\.|-){3,197})/ + /(@)/ + HOSTNAME_REGEX
MAIN_PHONE_REGEX = /(( ,-,(,)){,2}\d){6,11}/
INTERNATIONAL_PHONE_REGEX = /((00|\+)[1-9]\d{,2})/ + MAIN_PHONE_REGEX
LOCAL_PHONE_REGEX = /0/ + MAIN_PHONE_REGEX
INTEGER_REGEX = /-?(0|[1-9]\d*)/
NUMBER_REGEX = INTEGER_REGEX + /(\.\d+)?/
IP_REGEX = /(\d+)\.(\d+)\.(\d+)\.(\d+)/
DATE_REGEX = /\d{4}-(\d{2})-(\d{2})/
TIME_REGEX = /(\d{2}):(\d{2}):(\d{2})/
DATETIME_REGEX = /(?<date>.*)( |T)(?<time>.*)/
def Validations.email?(value)
EMAIL_REGEX.exact_regex === value
end
def Validations.hostname?(value)
HOSTNAME_REGEX.exact_regex === value
end
def Validations.phone?(value)
INTERNATIONAL_PHONE_REGEX.exact_regex === value or
LOCAL_PHONE_REGEX.exact_regex === value
end
def Validations.number?(value)
NUMBER_REGEX.exact_regex === value
end
def Validations.integer?(value)
INTEGER_REGEX.exact_regex.match(value)
end
def Validations.ip_address?(value)
match = IP_REGEX.exact_regex.match(value)
match != nil and match.captures.all? { |group| group.to_i < 256 }
end
def Validations.date?(value)
(DATE_REGEX.exact_regex =~ value) != nil and $1.to_i.between?(1, 12) and $2.to_i.between?(1, 31)
end
def Validations.time?(value)
match = TIME_REGEX.exact_regex.match(value)
match != nil and $1.to_i.between?(0, 23) and $2.to_i.between?(0, 59) and $3.to_i.between?(0, 59)
end
def Validations.date_time?(value)
match = DATETIME_REGEX.match(value)
match != nil and date? match[:date] and time? match[:time]
end
end
class PrivacyFilter
EMAIL_MARKER = '[EMAIL]'
PHONE_MARKER = '[PHONE]'
SECRET_MARKER = '[FILTERED]'
attr_accessor :preserve_phone_country_code
attr_accessor :preserve_email_hostname
attr_accessor :partially_preserve_email_username
def initialize(text)
@preserve_phone_country_code = false
@preserve_email_hostname = false
@partially_preserve_email_username = false
@text = text
end
def filtered
filter_email
filter_phone
@text
end
private
def filter_email
if @partially_preserve_email_username then partially_filter_email_username
elsif @preserve_email_hostname then filter_email_username
else fully_filter_email
end
end
def partially_filter_email_username
@text.gsub!(Validations::EMAIL_SHORT_USERNAME, SECRET_MARKER)
@text.gsub!(Validations::EMAIL_LONG_USERNAME, '\1' + SECRET_MARKER + '\5\6')
end
def filter_email_username
@text.gsub!(Validations::EMAIL_REGEX, SECRET_MARKER + '\2\3')
end
def fully_filter_email
@text.gsub!(Validations::EMAIL_REGEX, EMAIL_MARKER)
end
def filter_phone
if @preserve_phone_country_code then partially_filter_phone
else fully_filter_phone
end
end
def partially_filter_phone
@text.gsub!(Validations::LOCAL_PHONE_REGEX, PHONE_MARKER)
@text.gsub!(Validations::INTERNATIONAL_PHONE_REGEX, '\1 ' + SECRET_MARKER)
end
def fully_filter_phone
@text.gsub!(Validations::INTERNATIONAL_PHONE_REGEX, PHONE_MARKER)
@text.gsub!(Validations::LOCAL_PHONE_REGEX, PHONE_MARKER)
end
end

Лог от изпълнението

..F...FFFFFFFF..F..F.F..................F

Failures:

  1) PrivacyFilter obfuscates more complicated emails
     Failure/Error: PrivacyFilter.new(text).filtered
     RuntimeError:
       can't modify frozen String
     # /tmp/d20130203-23049-l850t1/solution.rb:112:in `gsub!'
     # /tmp/d20130203-23049-l850t1/solution.rb:112:in `fully_filter_email'
     # /tmp/d20130203-23049-l850t1/solution.rb:98:in `filter_email'
     # /tmp/d20130203-23049-l850t1/solution.rb:89:in `filtered'
     # /tmp/d20130203-23049-l850t1/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-l850t1/spec.rb:40:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-l850t1/spec.rb:39:in `each'
     # /tmp/d20130203-23049-l850t1/spec.rb:39:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  2) PrivacyFilter filters whole email usernames if too short
     Failure/Error: partially_filter_email_usernames('me@example.com').should eq '[FILTERED]@example.com'
       
       expected: "[FILTERED]@example.com"
            got: "[FILTERED]"
       
       (compared using ==)
     # /tmp/d20130203-23049-l850t1/spec.rb:69:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  3) PrivacyFilter does not brake with unicode
     Failure/Error: partially_filter_email_usernames('За връзка: me@example.com').should eq 'За връзка: [FILTERED]@example.com'
       
       expected: "За връзка: [FILTERED]@example.com"
            got: "За връзка: [FILTERED]"
       
       (compared using ==)
     # /tmp/d20130203-23049-l850t1/spec.rb:73:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  4) PrivacyFilter filters more complex phone numbers
     Failure/Error: PrivacyFilter.new(text).filtered
     RuntimeError:
       can't modify frozen String
     # /tmp/d20130203-23049-l850t1/solution.rb:112:in `gsub!'
     # /tmp/d20130203-23049-l850t1/solution.rb:112:in `fully_filter_email'
     # /tmp/d20130203-23049-l850t1/solution.rb:98:in `filter_email'
     # /tmp/d20130203-23049-l850t1/solution.rb:89:in `filtered'
     # /tmp/d20130203-23049-l850t1/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-l850t1/spec.rb:85:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-l850t1/spec.rb:84:in `each'
     # /tmp/d20130203-23049-l850t1/spec.rb:84:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  5) PrivacyFilter does not filter invalid phone numbers
     Failure/Error: PrivacyFilter.new(text).filtered
     RuntimeError:
       can't modify frozen String
     # /tmp/d20130203-23049-l850t1/solution.rb:112:in `gsub!'
     # /tmp/d20130203-23049-l850t1/solution.rb:112:in `fully_filter_email'
     # /tmp/d20130203-23049-l850t1/solution.rb:98:in `filter_email'
     # /tmp/d20130203-23049-l850t1/solution.rb:89:in `filtered'
     # /tmp/d20130203-23049-l850t1/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-l850t1/spec.rb:96:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-l850t1/spec.rb:95:in `each'
     # /tmp/d20130203-23049-l850t1/spec.rb:95:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  6) PrivacyFilter preserves whitespace around phones
     Failure/Error: filter(' +359881212-12-1 2 or...').should eq ' [PHONE] or...'
       
       expected: " [PHONE] or..."
            got: " [PHONE]-12-1 2 or..."
       
       (compared using ==)
     # /tmp/d20130203-23049-l850t1/spec.rb:101:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  7) PrivacyFilter filters more than one phone or email
     Failure/Error: filter(text).should eq filtered
       
       expected: "\n      Contacts\n\n      Phones: [PHONE] or [PHONE]\n      Email: [EMAIL] or [EMAIL]\n    "
            got: "\n      Contacts\n\n      Phones: +1 (555) 123-456-99 or [PHONE]\n      Email: [EMAIL] or [EMAIL]\n    "
       
       (compared using ==)
       
       Diff:
       @@ -1,7 +1,7 @@
        
              Contacts
        
       -      Phones: [PHONE] or [PHONE]
       +      Phones: +1 (555) 123-456-99 or [PHONE]
              Email: [EMAIL] or [EMAIL]
            
     # /tmp/d20130203-23049-l850t1/spec.rb:119:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  8) PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
     Failure/Error: filter.filtered.should eq filtered
     RuntimeError:
       can't modify frozen String
     # /tmp/d20130203-23049-l850t1/solution.rb:112:in `gsub!'
     # /tmp/d20130203-23049-l850t1/solution.rb:112:in `fully_filter_email'
     # /tmp/d20130203-23049-l850t1/solution.rb:98:in `filter_email'
     # /tmp/d20130203-23049-l850t1/solution.rb:89:in `filtered'
     # /tmp/d20130203-23049-l850t1/spec.rb:132:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-l850t1/spec.rb:129:in `each'
     # /tmp/d20130203-23049-l850t1/spec.rb:129:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  9) PrivacyFilter separates preserved country code from filtered phone with a space
     Failure/Error: filter.filtered.should eq filtered
     RuntimeError:
       can't modify frozen String
     # /tmp/d20130203-23049-l850t1/solution.rb:112:in `gsub!'
     # /tmp/d20130203-23049-l850t1/solution.rb:112:in `fully_filter_email'
     # /tmp/d20130203-23049-l850t1/solution.rb:98:in `filter_email'
     # /tmp/d20130203-23049-l850t1/solution.rb:89:in `filtered'
     # /tmp/d20130203-23049-l850t1/spec.rb:144:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-l850t1/spec.rb:141:in `each'
     # /tmp/d20130203-23049-l850t1/spec.rb:141:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  10) Validations can validate more complex emails
     Failure/Error: Validations.email?(email).should be(valid)
       
       expected #<FalseClass:0> => false
            got #<TrueClass:2> => true
       
       Compared using equal?, which compares object identity,
       but expected and actual are not the same object. Use
       'actual.should eq(expected)' if you don't care about
       object identity in this example.
     # /tmp/d20130203-23049-l850t1/spec.rb:171:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-l850t1/spec.rb:170:in `each'
     # /tmp/d20130203-23049-l850t1/spec.rb:170:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  11) Validations can validate more complex phone numbers
     Failure/Error: Validations.phone?(phone).should be(valid)
       
       expected #<TrueClass:2> => true
            got #<FalseClass:0> => false
       
       Compared using equal?, which compares object identity,
       but expected and actual are not the same object. Use
       'actual.should eq(expected)' if you don't care about
       object identity in this example.
     # /tmp/d20130203-23049-l850t1/spec.rb:210:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-l850t1/spec.rb:209:in `each'
     # /tmp/d20130203-23049-l850t1/spec.rb:209:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  12) Validations validates hostnames
     Failure/Error: Validations.hostname?('not-a-hostname-.com').should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-l850t1/spec.rb:227:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  13) Validations handles newlines in time and datetime validation
     Failure/Error: Validations.date_time?("2012-11-19 12:01:01\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-l850t1/spec.rb:362:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

Finished in 0.07509 seconds
41 examples, 13 failures

Failed examples:

rspec /tmp/d20130203-23049-l850t1/spec.rb:30 # PrivacyFilter obfuscates more complicated emails
rspec /tmp/d20130203-23049-l850t1/spec.rb:68 # PrivacyFilter filters whole email usernames if too short
rspec /tmp/d20130203-23049-l850t1/spec.rb:72 # PrivacyFilter does not brake with unicode
rspec /tmp/d20130203-23049-l850t1/spec.rb:76 # PrivacyFilter filters more complex phone numbers
rspec /tmp/d20130203-23049-l850t1/spec.rb:89 # PrivacyFilter does not filter invalid phone numbers
rspec /tmp/d20130203-23049-l850t1/spec.rb:100 # PrivacyFilter preserves whitespace around phones
rspec /tmp/d20130203-23049-l850t1/spec.rb:104 # PrivacyFilter filters more than one phone or email
rspec /tmp/d20130203-23049-l850t1/spec.rb:122 # PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
rspec /tmp/d20130203-23049-l850t1/spec.rb:136 # PrivacyFilter separates preserved country code from filtered phone with a space
rspec /tmp/d20130203-23049-l850t1/spec.rb:160 # Validations can validate more complex emails
rspec /tmp/d20130203-23049-l850t1/spec.rb:184 # Validations can validate more complex phone numbers
rspec /tmp/d20130203-23049-l850t1/spec.rb:218 # Validations validates hostnames
rspec /tmp/d20130203-23049-l850t1/spec.rb:359 # Validations handles newlines in time and datetime validation

История (1 версия и 0 коментара)

Николай обнови решението на 25.11.2012 16:54 (преди почти 12 години)

+class Regexp
+ def +(other)
+ Regexp.new(source + other.source)
+ end
+
+ def exact_regex
+ /\A/ + self + /\z/
+ end
+end
+
+class Validations
+
+ HOSTNAME_REGEX = /((\w(\w|-){,61}\w?\.)+[[:alpha:]]{2,3}(\.[[:alpha:]]{2,3})?)/
+ EMAIL_USERNAME = /\w(\w|_|\+|\.|-){,200}/
+ EMAIL_REGEX = EMAIL_USERNAME + /(@)/ + HOSTNAME_REGEX
+
+ EMAIL_SHORT_USERNAME = /(\b\w(\w|_|\+|\.|-){,4})/ + /@/ + HOSTNAME_REGEX
+ EMAIL_LONG_USERNAME = /(\w(\w|_|\+|\.|-){2})((\w|_|\+|\.|-){3,197})/ + /(@)/ + HOSTNAME_REGEX
+
+ MAIN_PHONE_REGEX = /(( ,-,(,)){,2}\d){6,11}/
+ INTERNATIONAL_PHONE_REGEX = /((00|\+)[1-9]\d{,2})/ + MAIN_PHONE_REGEX
+ LOCAL_PHONE_REGEX = /0/ + MAIN_PHONE_REGEX
+
+ INTEGER_REGEX = /-?(0|[1-9]\d*)/
+ NUMBER_REGEX = INTEGER_REGEX + /(\.\d+)?/
+ IP_REGEX = /(\d+)\.(\d+)\.(\d+)\.(\d+)/
+ DATE_REGEX = /\d{4}-(\d{2})-(\d{2})/
+ TIME_REGEX = /(\d{2}):(\d{2}):(\d{2})/
+ DATETIME_REGEX = /(?<date>.*)( |T)(?<time>.*)/
+
+ def Validations.email?(value)
+ EMAIL_REGEX.exact_regex === value
+ end
+
+ def Validations.hostname?(value)
+ HOSTNAME_REGEX.exact_regex === value
+ end
+
+ def Validations.phone?(value)
+ INTERNATIONAL_PHONE_REGEX.exact_regex === value or
+ LOCAL_PHONE_REGEX.exact_regex === value
+ end
+
+ def Validations.number?(value)
+ NUMBER_REGEX.exact_regex === value
+ end
+
+ def Validations.integer?(value)
+ INTEGER_REGEX.exact_regex.match(value)
+ end
+
+ def Validations.ip_address?(value)
+ match = IP_REGEX.exact_regex.match(value)
+ match != nil and match.captures.all? { |group| group.to_i < 256 }
+ end
+
+ def Validations.date?(value)
+ (DATE_REGEX.exact_regex =~ value) != nil and $1.to_i.between?(1, 12) and $2.to_i.between?(1, 31)
+ end
+
+ def Validations.time?(value)
+ match = TIME_REGEX.exact_regex.match(value)
+ match != nil and $1.to_i.between?(0, 23) and $2.to_i.between?(0, 59) and $3.to_i.between?(0, 59)
+ end
+
+ def Validations.date_time?(value)
+ match = DATETIME_REGEX.match(value)
+ match != nil and date? match[:date] and time? match[:time]
+ end
+end
+
+class PrivacyFilter
+ EMAIL_MARKER = '[EMAIL]'
+ PHONE_MARKER = '[PHONE]'
+ SECRET_MARKER = '[FILTERED]'
+
+ attr_accessor :preserve_phone_country_code
+ attr_accessor :preserve_email_hostname
+ attr_accessor :partially_preserve_email_username
+
+ def initialize(text)
+ @preserve_phone_country_code = false
+ @preserve_email_hostname = false
+ @partially_preserve_email_username = false
+ @text = text
+ end
+
+ def filtered
+ filter_email
+ filter_phone
+ @text
+ end
+
+ private
+ def filter_email
+ if @partially_preserve_email_username then partially_filter_email_username
+ elsif @preserve_email_hostname then filter_email_username
+ else fully_filter_email
+ end
+ end
+
+ def partially_filter_email_username
+ @text.gsub!(Validations::EMAIL_SHORT_USERNAME, SECRET_MARKER)
+ @text.gsub!(Validations::EMAIL_LONG_USERNAME, '\1' + SECRET_MARKER + '\5\6')
+ end
+
+ def filter_email_username
+ @text.gsub!(Validations::EMAIL_REGEX, SECRET_MARKER + '\2\3')
+ end
+
+ def fully_filter_email
+ @text.gsub!(Validations::EMAIL_REGEX, EMAIL_MARKER)
+ end
+
+ def filter_phone
+ if @preserve_phone_country_code then partially_filter_phone
+ else fully_filter_phone
+ end
+ end
+
+ def partially_filter_phone
+ @text.gsub!(Validations::LOCAL_PHONE_REGEX, PHONE_MARKER)
+ @text.gsub!(Validations::INTERNATIONAL_PHONE_REGEX, '\1 ' + SECRET_MARKER)
+ end
+
+ def fully_filter_phone
+ @text.gsub!(Validations::INTERNATIONAL_PHONE_REGEX, PHONE_MARKER)
+ @text.gsub!(Validations::LOCAL_PHONE_REGEX, PHONE_MARKER)
+ end
+end