Решение на Четвърта задача от Георги Гърдев

Обратно към всички решения

Към профила на Георги Гърдев

Резултати

  • 3 точки от тестове
  • 0 бонус точки
  • 3 точки общо
  • 18 успешни тест(а)
  • 23 неуспешни тест(а)

Код

module ValidationExpressions
VALID_HOSTNAME = /(([0-9a-zA-Z]|[0-9a-zA-Z][0-9a-zA-Z-]{,60}[0-9a-zA-Z]\.)+)([a-zA-Z]{2,3}(\.[a-zA-Z]{2,3}))/
VALID_EMAIL_NAME = /([0-9a-zA-Z][0-9a-zA-Z_.+-]{,200})@/
VALID_EMAIL = Regexp.new VALID_EMAIL_NAME.to_s + VALID_HOSTNAME.to_s
VALID_IP = /((\d|[1-9]\d|1\d\d|2[0-4]\d|25[0-5])\.){3}(\d|[1-9]\d|1\d\d|2[0-4]\d|25[0-5])/
VALID_NUMBER = /-?(0(\.\d+)?|[1-9]|[1-9][0-9.]*\d)/
VALID_INTEGER = /-?(0|[1-9]\d*)/
VALID_DATE = /(\d{4})-(0[1-9]|1[0-2])-(0[1-9]|[12]\d|3[01])/
VALID_TIME = /([01]\d|2[0-3]):([0-5]\d):([0-5]\d)/
VALID_PHONE = /(0|((00|\+)[1-9]\d{,2}))([ ()-]*?)((\d([ ()-]{,2})){6,10}\d)/
def self.full_match(regexp)
Regexp.new("^" + regexp.to_s + "$")
end
end
class Validations
include ValidationExpressions
def self.email?(value)
expression = ValidationExpressions.full_match VALID_EMAIL_NAME.to_s + VALID_HOSTNAME.to_s
not value.match(expression).nil?
end
def self.hostname?(value)
expression = ValidationExpressions.full_match VALID_HOSTNAME
not value.match(expression).nil?
end
def self.phone?(value)
expression = ValidationExpressions.full_match VALID_PHONE
not value.match(expression).nil?
end
def self.ip_address?(value)
expression = ValidationExpressions.full_match VALID_IP
not value.match(expression).nil?
end
def self.number?(value)
expression = ValidationExpressions.full_match VALID_NUMBER
not value.match(expression).nil?
end
def self.integer?(value)
expression = ValidationExpressions.full_match VALID_INTEGER
not value.match(expression).nil?
end
def self.date?(value)
expression = ValidationExpressions.full_match VALID_DATE
not value.match(expression).nil?
end
def self.time?(value)
expression = ValidationExpressions.full_match VALID_TIME
not value.match(expression).nil?
end
def self.date_time?(value)
expression = ValidationExpressions.full_match VALID_DATE.to_s + "[T ]" + VALID_TIME.to_s
not value.match(expression).nil?
end
end

Лог от изпълнението

FFFFFFFFFFFFFF...F..FFF.F..F..F.....F...F

Failures:

  1) PrivacyFilter works with blank or whitespace strings and preserves whitespace
     Failure/Error: PrivacyFilter.new(text).filtered
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-zsbzf7/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-zsbzf7/spec.rb:21:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  2) PrivacyFilter obfuscates simple emails
     Failure/Error: PrivacyFilter.new(text).filtered
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-zsbzf7/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-zsbzf7/spec.rb:27:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  3) PrivacyFilter obfuscates more complicated emails
     Failure/Error: PrivacyFilter.new(text).filtered
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-zsbzf7/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-zsbzf7/spec.rb:40:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-zsbzf7/spec.rb:39:in `each'
     # /tmp/d20130203-23049-zsbzf7/spec.rb:39:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  4) PrivacyFilter does not filter invalid emails
     Failure/Error: PrivacyFilter.new(text).filtered
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-zsbzf7/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-zsbzf7/spec.rb:52:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-zsbzf7/spec.rb:46:in `each'
     # /tmp/d20130203-23049-zsbzf7/spec.rb:46:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  5) PrivacyFilter allows email hostname to be preserved
     Failure/Error: filter = PrivacyFilter.new(text)
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-zsbzf7/spec.rb:9:in `filter_email_usernames'
     # /tmp/d20130203-23049-zsbzf7/spec.rb:60:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  6) PrivacyFilter allows email usernames to be partially preserved
     Failure/Error: filter = PrivacyFilter.new(text)
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-zsbzf7/spec.rb:15:in `partially_filter_email_usernames'
     # /tmp/d20130203-23049-zsbzf7/spec.rb:65:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  7) PrivacyFilter filters whole email usernames if too short
     Failure/Error: filter = PrivacyFilter.new(text)
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-zsbzf7/spec.rb:15:in `partially_filter_email_usernames'
     # /tmp/d20130203-23049-zsbzf7/spec.rb:69:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  8) PrivacyFilter does not brake with unicode
     Failure/Error: filter = PrivacyFilter.new(text)
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-zsbzf7/spec.rb:15:in `partially_filter_email_usernames'
     # /tmp/d20130203-23049-zsbzf7/spec.rb:73:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  9) PrivacyFilter filters more complex phone numbers
     Failure/Error: PrivacyFilter.new(text).filtered
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-zsbzf7/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-zsbzf7/spec.rb:85:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-zsbzf7/spec.rb:84:in `each'
     # /tmp/d20130203-23049-zsbzf7/spec.rb:84:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  10) PrivacyFilter does not filter invalid phone numbers
     Failure/Error: PrivacyFilter.new(text).filtered
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-zsbzf7/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-zsbzf7/spec.rb:96:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-zsbzf7/spec.rb:95:in `each'
     # /tmp/d20130203-23049-zsbzf7/spec.rb:95:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  11) PrivacyFilter preserves whitespace around phones
     Failure/Error: PrivacyFilter.new(text).filtered
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-zsbzf7/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-zsbzf7/spec.rb:101:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  12) PrivacyFilter filters more than one phone or email
     Failure/Error: PrivacyFilter.new(text).filtered
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-zsbzf7/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-zsbzf7/spec.rb:119:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  13) PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
     Failure/Error: filter = PrivacyFilter.new(text)
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-zsbzf7/spec.rb:130:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-zsbzf7/spec.rb:129:in `each'
     # /tmp/d20130203-23049-zsbzf7/spec.rb:129:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  14) PrivacyFilter separates preserved country code from filtered phone with a space
     Failure/Error: filter = PrivacyFilter.new(text)
     NameError:
       uninitialized constant PrivacyFilter
     # /tmp/d20130203-23049-zsbzf7/spec.rb:142:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-zsbzf7/spec.rb:141:in `each'
     # /tmp/d20130203-23049-zsbzf7/spec.rb:141:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  15) Validations does not break on emails in multiline strings
     Failure/Error: Validations.email?("foo@bar.com\nwat?").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-zsbzf7/spec.rb:176:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  16) Validations does not break on phones in multiline strings
     Failure/Error: Validations.phone?("0885123123\nwat?").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-zsbzf7/spec.rb:215:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  17) Validations validates hostnames
     Failure/Error: Validations.hostname?('1.2.3.4.xip.io').should be_true
       expected: true value
            got: false
     # /tmp/d20130203-23049-zsbzf7/spec.rb:222:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  18) Validations handles multiline strings in hostname validation properly
     Failure/Error: Validations.hostname?("foo.com\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-zsbzf7/spec.rb:233:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  19) Validations handles multiline strings in IP validation properly
     Failure/Error: Validations.ip_address?("8.8.8.8\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-zsbzf7/spec.rb:245:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  20) Validations handles multiline strings in numbers validation properly
     Failure/Error: Validations.number?("42\n24").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-zsbzf7/spec.rb:274:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  21) Validations handles multiline strings in integer validation properly
     Failure/Error: Validations.number?("42\n24").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-zsbzf7/spec.rb:295:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  22) Validations handles newlines in date validation
     Failure/Error: Validations.date?("2012-11-19\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-zsbzf7/spec.rb:327:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  23) Validations handles newlines in time and datetime validation
     Failure/Error: Validations.time?("12:01:01\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-zsbzf7/spec.rb:360:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

Finished in 0.0817 seconds
41 examples, 23 failures

Failed examples:

rspec /tmp/d20130203-23049-zsbzf7/spec.rb:20 # PrivacyFilter works with blank or whitespace strings and preserves whitespace
rspec /tmp/d20130203-23049-zsbzf7/spec.rb:26 # PrivacyFilter obfuscates simple emails
rspec /tmp/d20130203-23049-zsbzf7/spec.rb:30 # PrivacyFilter obfuscates more complicated emails
rspec /tmp/d20130203-23049-zsbzf7/spec.rb:44 # PrivacyFilter does not filter invalid emails
rspec /tmp/d20130203-23049-zsbzf7/spec.rb:59 # PrivacyFilter allows email hostname to be preserved
rspec /tmp/d20130203-23049-zsbzf7/spec.rb:64 # PrivacyFilter allows email usernames to be partially preserved
rspec /tmp/d20130203-23049-zsbzf7/spec.rb:68 # PrivacyFilter filters whole email usernames if too short
rspec /tmp/d20130203-23049-zsbzf7/spec.rb:72 # PrivacyFilter does not brake with unicode
rspec /tmp/d20130203-23049-zsbzf7/spec.rb:76 # PrivacyFilter filters more complex phone numbers
rspec /tmp/d20130203-23049-zsbzf7/spec.rb:89 # PrivacyFilter does not filter invalid phone numbers
rspec /tmp/d20130203-23049-zsbzf7/spec.rb:100 # PrivacyFilter preserves whitespace around phones
rspec /tmp/d20130203-23049-zsbzf7/spec.rb:104 # PrivacyFilter filters more than one phone or email
rspec /tmp/d20130203-23049-zsbzf7/spec.rb:122 # PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
rspec /tmp/d20130203-23049-zsbzf7/spec.rb:136 # PrivacyFilter separates preserved country code from filtered phone with a space
rspec /tmp/d20130203-23049-zsbzf7/spec.rb:175 # Validations does not break on emails in multiline strings
rspec /tmp/d20130203-23049-zsbzf7/spec.rb:214 # Validations does not break on phones in multiline strings
rspec /tmp/d20130203-23049-zsbzf7/spec.rb:218 # Validations validates hostnames
rspec /tmp/d20130203-23049-zsbzf7/spec.rb:232 # Validations handles multiline strings in hostname validation properly
rspec /tmp/d20130203-23049-zsbzf7/spec.rb:244 # Validations handles multiline strings in IP validation properly
rspec /tmp/d20130203-23049-zsbzf7/spec.rb:273 # Validations handles multiline strings in numbers validation properly
rspec /tmp/d20130203-23049-zsbzf7/spec.rb:294 # Validations handles multiline strings in integer validation properly
rspec /tmp/d20130203-23049-zsbzf7/spec.rb:326 # Validations handles newlines in date validation
rspec /tmp/d20130203-23049-zsbzf7/spec.rb:359 # Validations handles newlines in time and datetime validation

История (1 версия и 0 коментара)

Георги обнови решението на 27.11.2012 23:52 (преди почти 12 години)

+module ValidationExpressions
+ VALID_HOSTNAME = /(([0-9a-zA-Z]|[0-9a-zA-Z][0-9a-zA-Z-]{,60}[0-9a-zA-Z]\.)+)([a-zA-Z]{2,3}(\.[a-zA-Z]{2,3}))/
+ VALID_EMAIL_NAME = /([0-9a-zA-Z][0-9a-zA-Z_.+-]{,200})@/
+ VALID_EMAIL = Regexp.new VALID_EMAIL_NAME.to_s + VALID_HOSTNAME.to_s
+ VALID_IP = /((\d|[1-9]\d|1\d\d|2[0-4]\d|25[0-5])\.){3}(\d|[1-9]\d|1\d\d|2[0-4]\d|25[0-5])/
+ VALID_NUMBER = /-?(0(\.\d+)?|[1-9]|[1-9][0-9.]*\d)/
+ VALID_INTEGER = /-?(0|[1-9]\d*)/
+ VALID_DATE = /(\d{4})-(0[1-9]|1[0-2])-(0[1-9]|[12]\d|3[01])/
+ VALID_TIME = /([01]\d|2[0-3]):([0-5]\d):([0-5]\d)/
+ VALID_PHONE = /(0|((00|\+)[1-9]\d{,2}))([ ()-]*?)((\d([ ()-]{,2})){6,10}\d)/
+
+ def self.full_match(regexp)
+ Regexp.new("^" + regexp.to_s + "$")
+ end
+end
+
+class Validations
+ include ValidationExpressions
+
+ def self.email?(value)
+ expression = ValidationExpressions.full_match VALID_EMAIL_NAME.to_s + VALID_HOSTNAME.to_s
+ not value.match(expression).nil?
+ end
+
+ def self.hostname?(value)
+ expression = ValidationExpressions.full_match VALID_HOSTNAME
+ not value.match(expression).nil?
+ end
+
+ def self.phone?(value)
+ expression = ValidationExpressions.full_match VALID_PHONE
+ not value.match(expression).nil?
+ end
+
+ def self.ip_address?(value)
+ expression = ValidationExpressions.full_match VALID_IP
+ not value.match(expression).nil?
+ end
+
+ def self.number?(value)
+ expression = ValidationExpressions.full_match VALID_NUMBER
+ not value.match(expression).nil?
+ end
+
+ def self.integer?(value)
+ expression = ValidationExpressions.full_match VALID_INTEGER
+ not value.match(expression).nil?
+ end
+
+ def self.date?(value)
+ expression = ValidationExpressions.full_match VALID_DATE
+ not value.match(expression).nil?
+ end
+
+ def self.time?(value)
+ expression = ValidationExpressions.full_match VALID_TIME
+ not value.match(expression).nil?
+ end
+
+ def self.date_time?(value)
+ expression = ValidationExpressions.full_match VALID_DATE.to_s + "[T ]" + VALID_TIME.to_s
+ not value.match(expression).nil?
+ end
+end