Решение на Четвърта задача от Илиан Маджаров
Обратно към всички решения
Към профила на Илиан Маджаров
Резултати
- 4 точки от тестове
- 0 бонус точки
- 4 точки общо
- 29 успешни тест(а)
- 12 неуспешни тест(а)
Код
Лог от изпълнението
..F.FFFFFF..FF.....F....F...............F
Failures:
1) PrivacyFilter obfuscates more complicated emails
Failure/Error: PrivacyFilter.new(text).filtered
RuntimeError:
can't modify frozen String
# /tmp/d20130203-23049-1f9jzmu/solution.rb:32:in `gsub!'
# /tmp/d20130203-23049-1f9jzmu/solution.rb:32:in `block in filter_emails'
# /tmp/d20130203-23049-1f9jzmu/solution.rb:29:in `each'
# /tmp/d20130203-23049-1f9jzmu/solution.rb:29:in `filter_emails'
# /tmp/d20130203-23049-1f9jzmu/solution.rb:24:in `filtered'
# /tmp/d20130203-23049-1f9jzmu/spec.rb:5:in `filter'
# /tmp/d20130203-23049-1f9jzmu/spec.rb:40:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-1f9jzmu/spec.rb:39:in `each'
# /tmp/d20130203-23049-1f9jzmu/spec.rb:39:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
2) PrivacyFilter allows email hostname to be preserved
Failure/Error: filter_email_usernames('someone@example.com').should eq '[FILTERED]@example.com'
expected: "[FILTERED]@example.com"
got: "[EMAIL]@example.com"
(compared using ==)
# /tmp/d20130203-23049-1f9jzmu/spec.rb:60:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
3) PrivacyFilter allows email usernames to be partially preserved
Failure/Error: partially_filter_email_usernames('someone@example.com').should eq 'som[FILTERED]@example.com'
expected: "som[FILTERED]@example.com"
got: "som[EMAIL]@example.com"
(compared using ==)
# /tmp/d20130203-23049-1f9jzmu/spec.rb:65:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
4) PrivacyFilter filters whole email usernames if too short
Failure/Error: partially_filter_email_usernames('me@example.com').should eq '[FILTERED]@example.com'
expected: "[FILTERED]@example.com"
got: "[EMAIL]@example.com"
(compared using ==)
# /tmp/d20130203-23049-1f9jzmu/spec.rb:69:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
5) PrivacyFilter does not brake with unicode
Failure/Error: partially_filter_email_usernames('За връзка: me@example.com').should eq 'За връзка: [FILTERED]@example.com'
expected: "За връзка: [FILTERED]@example.com"
got: "За връзка: [EMAIL]@example.com"
(compared using ==)
# /tmp/d20130203-23049-1f9jzmu/spec.rb:73:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
6) PrivacyFilter filters more complex phone numbers
Failure/Error: PrivacyFilter.new(text).filtered
RuntimeError:
can't modify frozen String
# /tmp/d20130203-23049-1f9jzmu/solution.rb:55:in `gsub!'
# /tmp/d20130203-23049-1f9jzmu/solution.rb:55:in `block in filter_phones'
# /tmp/d20130203-23049-1f9jzmu/solution.rb:54:in `each'
# /tmp/d20130203-23049-1f9jzmu/solution.rb:54:in `filter_phones'
# /tmp/d20130203-23049-1f9jzmu/solution.rb:24:in `filtered'
# /tmp/d20130203-23049-1f9jzmu/spec.rb:5:in `filter'
# /tmp/d20130203-23049-1f9jzmu/spec.rb:85:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-1f9jzmu/spec.rb:84:in `each'
# /tmp/d20130203-23049-1f9jzmu/spec.rb:84:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
7) PrivacyFilter does not filter invalid phone numbers
Failure/Error: PrivacyFilter.new(text).filtered
RuntimeError:
can't modify frozen String
# /tmp/d20130203-23049-1f9jzmu/solution.rb:55:in `gsub!'
# /tmp/d20130203-23049-1f9jzmu/solution.rb:55:in `block in filter_phones'
# /tmp/d20130203-23049-1f9jzmu/solution.rb:54:in `each'
# /tmp/d20130203-23049-1f9jzmu/solution.rb:54:in `filter_phones'
# /tmp/d20130203-23049-1f9jzmu/solution.rb:24:in `filtered'
# /tmp/d20130203-23049-1f9jzmu/spec.rb:5:in `filter'
# /tmp/d20130203-23049-1f9jzmu/spec.rb:96:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-1f9jzmu/spec.rb:95:in `each'
# /tmp/d20130203-23049-1f9jzmu/spec.rb:95:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
8) PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
Failure/Error: filter.filtered.should eq filtered
RuntimeError:
can't modify frozen String
# /tmp/d20130203-23049-1f9jzmu/solution.rb:56:in `gsub!'
# /tmp/d20130203-23049-1f9jzmu/solution.rb:56:in `block in filter_phones'
# /tmp/d20130203-23049-1f9jzmu/solution.rb:54:in `each'
# /tmp/d20130203-23049-1f9jzmu/solution.rb:54:in `filter_phones'
# /tmp/d20130203-23049-1f9jzmu/solution.rb:24:in `filtered'
# /tmp/d20130203-23049-1f9jzmu/spec.rb:132:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-1f9jzmu/spec.rb:129:in `each'
# /tmp/d20130203-23049-1f9jzmu/spec.rb:129:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
9) PrivacyFilter separates preserved country code from filtered phone with a space
Failure/Error: filter.filtered.should eq filtered
RuntimeError:
can't modify frozen String
# /tmp/d20130203-23049-1f9jzmu/solution.rb:56:in `gsub!'
# /tmp/d20130203-23049-1f9jzmu/solution.rb:56:in `block in filter_phones'
# /tmp/d20130203-23049-1f9jzmu/solution.rb:54:in `each'
# /tmp/d20130203-23049-1f9jzmu/solution.rb:54:in `filter_phones'
# /tmp/d20130203-23049-1f9jzmu/solution.rb:24:in `filtered'
# /tmp/d20130203-23049-1f9jzmu/spec.rb:144:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-1f9jzmu/spec.rb:141:in `each'
# /tmp/d20130203-23049-1f9jzmu/spec.rb:141:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
10) Validations can validate more complex phone numbers
Failure/Error: Validations.phone?(phone).should be(valid)
expected #<FalseClass:0> => false
got #<TrueClass:2> => true
Compared using equal?, which compares object identity,
but expected and actual are not the same object. Use
'actual.should eq(expected)' if you don't care about
object identity in this example.
# /tmp/d20130203-23049-1f9jzmu/spec.rb:210:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-1f9jzmu/spec.rb:209:in `each'
# /tmp/d20130203-23049-1f9jzmu/spec.rb:209:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
11) Validations handles multiline strings in IP validation properly
Failure/Error: Validations.ip_address?("8.8.8.8\n").should be_false
NoMethodError:
undefined method `all?' for nil:NilClass
# /tmp/d20130203-23049-1f9jzmu/solution.rb:80:in `ip_address?'
# /tmp/d20130203-23049-1f9jzmu/spec.rb:245:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
12) Validations handles newlines in time and datetime validation
Failure/Error: Validations.date_time?("2012-11-19 12:01:01\n").should be_false
expected: false value
got: true
# /tmp/d20130203-23049-1f9jzmu/spec.rb:362:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
Finished in 0.04806 seconds
41 examples, 12 failures
Failed examples:
rspec /tmp/d20130203-23049-1f9jzmu/spec.rb:30 # PrivacyFilter obfuscates more complicated emails
rspec /tmp/d20130203-23049-1f9jzmu/spec.rb:59 # PrivacyFilter allows email hostname to be preserved
rspec /tmp/d20130203-23049-1f9jzmu/spec.rb:64 # PrivacyFilter allows email usernames to be partially preserved
rspec /tmp/d20130203-23049-1f9jzmu/spec.rb:68 # PrivacyFilter filters whole email usernames if too short
rspec /tmp/d20130203-23049-1f9jzmu/spec.rb:72 # PrivacyFilter does not brake with unicode
rspec /tmp/d20130203-23049-1f9jzmu/spec.rb:76 # PrivacyFilter filters more complex phone numbers
rspec /tmp/d20130203-23049-1f9jzmu/spec.rb:89 # PrivacyFilter does not filter invalid phone numbers
rspec /tmp/d20130203-23049-1f9jzmu/spec.rb:122 # PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
rspec /tmp/d20130203-23049-1f9jzmu/spec.rb:136 # PrivacyFilter separates preserved country code from filtered phone with a space
rspec /tmp/d20130203-23049-1f9jzmu/spec.rb:184 # Validations can validate more complex phone numbers
rspec /tmp/d20130203-23049-1f9jzmu/spec.rb:244 # Validations handles multiline strings in IP validation properly
rspec /tmp/d20130203-23049-1f9jzmu/spec.rb:359 # Validations handles newlines in time and datetime validation
История (1 версия и 0 коментара)
Илиан обнови решението на 28.11.2012 03:03 (преди почти 12 години)