Решение на Четвърта задача от Румен Палетов

Обратно към всички решения

Към профила на Румен Палетов

Резултати

  • 2 точки от тестове
  • 0 бонус точки
  • 2 точки общо
  • 17 успешни тест(а)
  • 24 неуспешни тест(а)

Код

module RegExPatterns
EMAIL_PREFIX_PATTERN = /^[a-zA-Z0-9][\w+.-]{0,200}\z/
HOSTNAME_PATTERN = /^([a-zA-Z0-9](\w{0,60}[a-zA-Z0-9])?\.)+[a-zA-Z0-9]?(.[a-zA-Z]{1,2})\z/
IP_ADDRESS_PATTERN = /^(?:(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){3}?(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)$/
NUMBER_PATTERN = /^-?(0|[1-9])[0-9]*(\.[0-9]+)?\z/
INTEGER_PATTERN = /^-?[1-9][0-9]*\z/
PHONE_PATTERN = /^(0|((00|\+)[1-9][0-9]{0,2}))([ \-\(\)]{0,2}[0-9]{1}){6,11}\z/
DATE_PATTERN = /^([0-9]{4})-(0[1-9]|1[012])-(0[1-9]|[1-2][0-9]|3[0-1])\z/
TIME_PATTERN = /^([0-1][0-9]|2[0-3]):([0-4][0-9]|5[0-9]):([0-4][0-9]|5[0-9])\z/
end
class Validations
def Validations.email?(value)
splitted_email = value.split("@")
if splitted_email.length == 2 then
Validations.email_prefix?(splitted_email[0]) && Validations.hostname?(splitted_email[1])
else false
end
end
def Validations.email_prefix?(value)
match(RegExPatterns::EMAIL_PREFIX_PATTERN, value)
end
def Validations.phone?(value)
match(RegExPatterns::PHONE_PATTERN, value)
end
def Validations.hostname?(value)
match(RegExPatterns::HOSTNAME_PATTERN, value)
end
def Validations.ip_address?(value)
match(RegExPatterns::IP_ADDRESS_PATTERN, value)
end
def Validations.number?(value)
match(RegExPatterns::NUMBER_PATTERN, value)
end
def Validations.integer?(value)
match(RegExPatterns::INTEGER_PATTERN, value)
end
def Validations.date?(value)
match(RegExPatterns::DATE_PATTERN, value)
end
def Validations.time?(value)
match(RegExPatterns::TIME_PATTERN, value)
end
def Validations.date_time?(value)
if Validations.date?(value[0, 10]) == false then false
elsif Validations.time?(value[11, value.length - 11]) == false then false
else true
end
end
def Validations.match(pattern, value)
pattern.match(value) != nil
end
end
class PrivacyFilter
attr_reader :preserve_phone_country_code
attr_reader :preserve_email_hostname
attr_reader :partially_preserve_email_username
def initialize(text)
@text = text
end
def filtered
end
def filter_email_addresses
end
end

Лог от изпълнението

FFFFFFFFFFFFFF.....F.FF.F.FF.FF.....F...F

Failures:

  1) PrivacyFilter works with blank or whitespace strings and preserves whitespace
     Failure/Error: filter('').should eq ''
       
       expected: ""
            got: nil
       
       (compared using ==)
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:21:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  2) PrivacyFilter obfuscates simple emails
     Failure/Error: filter('Contact: someone@example.com').should eq 'Contact: [EMAIL]'
       
       expected: "Contact: [EMAIL]"
            got: nil
       
       (compared using ==)
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:27:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  3) PrivacyFilter obfuscates more complicated emails
     Failure/Error: filter(text).should eq filtered
       
       expected: "[EMAIL]"
            got: nil
       
       (compared using ==)
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:40:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:39:in `each'
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:39:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  4) PrivacyFilter does not filter invalid emails
     Failure/Error: filter(text_with_invalid_emails).should eq text_with_invalid_emails
       
       expected: "Contact me here: _invalid@email.com"
            got: nil
       
       (compared using ==)
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:52:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:46:in `each'
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:46:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  5) PrivacyFilter allows email hostname to be preserved
     Failure/Error: filter.preserve_email_hostname = true
     NoMethodError:
       undefined method `preserve_email_hostname=' for #<PrivacyFilter:0x93fb4bc @text="someone@example.com">
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:10:in `filter_email_usernames'
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:60:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  6) PrivacyFilter allows email usernames to be partially preserved
     Failure/Error: filter.partially_preserve_email_username = true
     NoMethodError:
       undefined method `partially_preserve_email_username=' for #<PrivacyFilter:0x93fa508 @text="someone@example.com">
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:16:in `partially_filter_email_usernames'
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:65:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  7) PrivacyFilter filters whole email usernames if too short
     Failure/Error: filter.partially_preserve_email_username = true
     NoMethodError:
       undefined method `partially_preserve_email_username=' for #<PrivacyFilter:0x93f93b0 @text="me@example.com">
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:16:in `partially_filter_email_usernames'
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:69:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  8) PrivacyFilter does not brake with unicode
     Failure/Error: filter.partially_preserve_email_username = true
     NoMethodError:
       undefined method `partially_preserve_email_username=' for #<PrivacyFilter:0x9bce838>
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:16:in `partially_filter_email_usernames'
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:73:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  9) PrivacyFilter filters more complex phone numbers
     Failure/Error: filter(text).should eq filtered
       
       expected: "Reach me at: [PHONE]"
            got: nil
       
       (compared using ==)
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:85:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:84:in `each'
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:84:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  10) PrivacyFilter does not filter invalid phone numbers
     Failure/Error: filter(text).should eq filtered
       
       expected: "Reach me at: 0885123"
            got: nil
       
       (compared using ==)
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:96:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:95:in `each'
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:95:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  11) PrivacyFilter preserves whitespace around phones
     Failure/Error: filter(' +359881212-12-1 2 or...').should eq ' [PHONE] or...'
       
       expected: " [PHONE] or..."
            got: nil
       
       (compared using ==)
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:101:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  12) PrivacyFilter filters more than one phone or email
     Failure/Error: filter(text).should eq filtered
       
       expected: "\n      Contacts\n\n      Phones: [PHONE] or [PHONE]\n      Email: [EMAIL] or [EMAIL]\n    "
            got: nil
       
       (compared using ==)
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:119:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  13) PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
     Failure/Error: filter.preserve_phone_country_code = true
     NoMethodError:
       undefined method `preserve_phone_country_code=' for #<PrivacyFilter:0x9bcf990 @text="Phone: +359 2 555-1212">
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:131:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:129:in `each'
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:129:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  14) PrivacyFilter separates preserved country code from filtered phone with a space
     Failure/Error: filter.preserve_phone_country_code = true
     NoMethodError:
       undefined method `preserve_phone_country_code=' for #<PrivacyFilter:0x9bd57a0 @text="Phone: 0025 (55) 12 12255">
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:143:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:141:in `each'
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:141:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  15) Validations can validate more complex phone numbers
     Failure/Error: Validations.phone?(phone).should be(valid)
       
       expected #<FalseClass:0> => false
            got #<TrueClass:2> => true
       
       Compared using equal?, which compares object identity,
       but expected and actual are not the same object. Use
       'actual.should eq(expected)' if you don't care about
       object identity in this example.
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:210:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:209:in `each'
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:209:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  16) Validations validates hostnames
     Failure/Error: Validations.hostname?('some.long-subdomain.domain.co.ul').should be_true
       expected: true value
            got: false
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:220:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  17) Validations handles multiline strings in hostname validation properly
     Failure/Error: Validations.hostname?("foo.com\nbar.com").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:234:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  18) Validations handles multiline strings in IP validation properly
     Failure/Error: Validations.ip_address?("8.8.8.8\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:245:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  19) Validations validates more complex numbers
     Failure/Error: Validations.number?('00').should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:263:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  20) Validations handles multiline strings in numbers validation properly
     Failure/Error: Validations.number?("42\n24").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:274:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  21) Validations validates more complex integers
     Failure/Error: Validations.integer?('0').should be_true
       expected: true value
            got: false
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:287:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  22) Validations handles multiline strings in integer validation properly
     Failure/Error: Validations.number?("42\n24").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:295:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  23) Validations handles newlines in date validation
     Failure/Error: Validations.date?("2012-11-19\n2012-10-10").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:328:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  24) Validations handles newlines in time and datetime validation
     Failure/Error: Validations.time?("12:01:01\n12:02:02").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-1kzwmx1/spec.rb:361:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

Finished in 0.04788 seconds
41 examples, 24 failures

Failed examples:

rspec /tmp/d20130203-23049-1kzwmx1/spec.rb:20 # PrivacyFilter works with blank or whitespace strings and preserves whitespace
rspec /tmp/d20130203-23049-1kzwmx1/spec.rb:26 # PrivacyFilter obfuscates simple emails
rspec /tmp/d20130203-23049-1kzwmx1/spec.rb:30 # PrivacyFilter obfuscates more complicated emails
rspec /tmp/d20130203-23049-1kzwmx1/spec.rb:44 # PrivacyFilter does not filter invalid emails
rspec /tmp/d20130203-23049-1kzwmx1/spec.rb:59 # PrivacyFilter allows email hostname to be preserved
rspec /tmp/d20130203-23049-1kzwmx1/spec.rb:64 # PrivacyFilter allows email usernames to be partially preserved
rspec /tmp/d20130203-23049-1kzwmx1/spec.rb:68 # PrivacyFilter filters whole email usernames if too short
rspec /tmp/d20130203-23049-1kzwmx1/spec.rb:72 # PrivacyFilter does not brake with unicode
rspec /tmp/d20130203-23049-1kzwmx1/spec.rb:76 # PrivacyFilter filters more complex phone numbers
rspec /tmp/d20130203-23049-1kzwmx1/spec.rb:89 # PrivacyFilter does not filter invalid phone numbers
rspec /tmp/d20130203-23049-1kzwmx1/spec.rb:100 # PrivacyFilter preserves whitespace around phones
rspec /tmp/d20130203-23049-1kzwmx1/spec.rb:104 # PrivacyFilter filters more than one phone or email
rspec /tmp/d20130203-23049-1kzwmx1/spec.rb:122 # PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
rspec /tmp/d20130203-23049-1kzwmx1/spec.rb:136 # PrivacyFilter separates preserved country code from filtered phone with a space
rspec /tmp/d20130203-23049-1kzwmx1/spec.rb:184 # Validations can validate more complex phone numbers
rspec /tmp/d20130203-23049-1kzwmx1/spec.rb:218 # Validations validates hostnames
rspec /tmp/d20130203-23049-1kzwmx1/spec.rb:232 # Validations handles multiline strings in hostname validation properly
rspec /tmp/d20130203-23049-1kzwmx1/spec.rb:244 # Validations handles multiline strings in IP validation properly
rspec /tmp/d20130203-23049-1kzwmx1/spec.rb:257 # Validations validates more complex numbers
rspec /tmp/d20130203-23049-1kzwmx1/spec.rb:273 # Validations handles multiline strings in numbers validation properly
rspec /tmp/d20130203-23049-1kzwmx1/spec.rb:283 # Validations validates more complex integers
rspec /tmp/d20130203-23049-1kzwmx1/spec.rb:294 # Validations handles multiline strings in integer validation properly
rspec /tmp/d20130203-23049-1kzwmx1/spec.rb:326 # Validations handles newlines in date validation
rspec /tmp/d20130203-23049-1kzwmx1/spec.rb:359 # Validations handles newlines in time and datetime validation

История (1 версия и 0 коментара)

Румен обнови решението на 28.11.2012 03:55 (преди почти 12 години)

+module RegExPatterns
+ EMAIL_PREFIX_PATTERN = /^[a-zA-Z0-9][\w+.-]{0,200}\z/
+ HOSTNAME_PATTERN = /^([a-zA-Z0-9](\w{0,60}[a-zA-Z0-9])?\.)+[a-zA-Z0-9]?(.[a-zA-Z]{1,2})\z/
+ IP_ADDRESS_PATTERN = /^(?:(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){3}?(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)$/
+ NUMBER_PATTERN = /^-?(0|[1-9])[0-9]*(\.[0-9]+)?\z/
+ INTEGER_PATTERN = /^-?[1-9][0-9]*\z/
+ PHONE_PATTERN = /^(0|((00|\+)[1-9][0-9]{0,2}))([ \-\(\)]{0,2}[0-9]{1}){6,11}\z/
+ DATE_PATTERN = /^([0-9]{4})-(0[1-9]|1[012])-(0[1-9]|[1-2][0-9]|3[0-1])\z/
+ TIME_PATTERN = /^([0-1][0-9]|2[0-3]):([0-4][0-9]|5[0-9]):([0-4][0-9]|5[0-9])\z/
+end
+
+class Validations
+ def Validations.email?(value)
+ splitted_email = value.split("@")
+ if splitted_email.length == 2 then
+ Validations.email_prefix?(splitted_email[0]) && Validations.hostname?(splitted_email[1])
+ else false
+ end
+ end
+
+ def Validations.email_prefix?(value)
+ match(RegExPatterns::EMAIL_PREFIX_PATTERN, value)
+ end
+
+ def Validations.phone?(value)
+ match(RegExPatterns::PHONE_PATTERN, value)
+ end
+
+ def Validations.hostname?(value)
+ match(RegExPatterns::HOSTNAME_PATTERN, value)
+ end
+
+ def Validations.ip_address?(value)
+ match(RegExPatterns::IP_ADDRESS_PATTERN, value)
+ end
+
+ def Validations.number?(value)
+ match(RegExPatterns::NUMBER_PATTERN, value)
+ end
+
+ def Validations.integer?(value)
+ match(RegExPatterns::INTEGER_PATTERN, value)
+ end
+
+ def Validations.date?(value)
+ match(RegExPatterns::DATE_PATTERN, value)
+ end
+
+ def Validations.time?(value)
+ match(RegExPatterns::TIME_PATTERN, value)
+ end
+
+ def Validations.date_time?(value)
+ if Validations.date?(value[0, 10]) == false then false
+ elsif Validations.time?(value[11, value.length - 11]) == false then false
+ else true
+ end
+ end
+
+ def Validations.match(pattern, value)
+ pattern.match(value) != nil
+ end
+end
+
+class PrivacyFilter
+ attr_reader :preserve_phone_country_code
+ attr_reader :preserve_email_hostname
+ attr_reader :partially_preserve_email_username
+
+ def initialize(text)
+ @text = text
+ end
+
+ def filtered
+ end
+
+ def filter_email_addresses
+ end
+end