Решение на Четвърта задача от Мирослав Крамолински
Обратно към всички решения
Към профила на Мирослав Крамолински
Резултати
- 4 точки от тестове
- 0 бонус точки
- 4 точки общо
- 28 успешни тест(а)
- 13 неуспешни тест(а)
Код
Лог от изпълнението
..F....FFFFFFF.....F...F..F.......F....F.
Failures:
1) PrivacyFilter obfuscates more complicated emails
Failure/Error: PrivacyFilter.new(text).filtered
RuntimeError:
can't modify frozen String
# /tmp/d20130203-23049-n8mhx/solution.rb:60:in `gsub!'
# /tmp/d20130203-23049-n8mhx/solution.rb:60:in `filter_email'
# /tmp/d20130203-23049-n8mhx/solution.rb:92:in `filtered'
# /tmp/d20130203-23049-n8mhx/spec.rb:5:in `filter'
# /tmp/d20130203-23049-n8mhx/spec.rb:40:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-n8mhx/spec.rb:39:in `each'
# /tmp/d20130203-23049-n8mhx/spec.rb:39:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
2) PrivacyFilter does not brake with unicode
Failure/Error: filter.filtered
Encoding::CompatibilityError:
incompatible encoding regexp match (ASCII-8BIT regexp with UTF-8 string)
# /tmp/d20130203-23049-n8mhx/solution.rb:60:in `gsub!'
# /tmp/d20130203-23049-n8mhx/solution.rb:60:in `filter_email'
# /tmp/d20130203-23049-n8mhx/solution.rb:92:in `filtered'
# /tmp/d20130203-23049-n8mhx/spec.rb:17:in `partially_filter_email_usernames'
# /tmp/d20130203-23049-n8mhx/spec.rb:73:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
3) PrivacyFilter filters more complex phone numbers
Failure/Error: PrivacyFilter.new(text).filtered
RuntimeError:
can't modify frozen String
# /tmp/d20130203-23049-n8mhx/solution.rb:60:in `gsub!'
# /tmp/d20130203-23049-n8mhx/solution.rb:60:in `filter_email'
# /tmp/d20130203-23049-n8mhx/solution.rb:92:in `filtered'
# /tmp/d20130203-23049-n8mhx/spec.rb:5:in `filter'
# /tmp/d20130203-23049-n8mhx/spec.rb:85:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-n8mhx/spec.rb:84:in `each'
# /tmp/d20130203-23049-n8mhx/spec.rb:84:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
4) PrivacyFilter does not filter invalid phone numbers
Failure/Error: PrivacyFilter.new(text).filtered
RuntimeError:
can't modify frozen String
# /tmp/d20130203-23049-n8mhx/solution.rb:60:in `gsub!'
# /tmp/d20130203-23049-n8mhx/solution.rb:60:in `filter_email'
# /tmp/d20130203-23049-n8mhx/solution.rb:92:in `filtered'
# /tmp/d20130203-23049-n8mhx/spec.rb:5:in `filter'
# /tmp/d20130203-23049-n8mhx/spec.rb:96:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-n8mhx/spec.rb:95:in `each'
# /tmp/d20130203-23049-n8mhx/spec.rb:95:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
5) PrivacyFilter preserves whitespace around phones
Failure/Error: filter(' +359881212-12-1 2 or...').should eq ' [PHONE] or...'
expected: " [PHONE] or..."
got: " +359881212-12-1 2 or..."
(compared using ==)
# /tmp/d20130203-23049-n8mhx/spec.rb:101:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
6) PrivacyFilter filters more than one phone or email
Failure/Error: filter(text).should eq filtered
expected: "\n Contacts\n\n Phones: [PHONE] or [PHONE]\n Email: [EMAIL] or [EMAIL]\n "
got: "\n Contacts\n\n Phones: +1 (555) 123-456-99 or 004412125543\n Email: [EMAIL] or [EMAIL]\n "
(compared using ==)
Diff:
@@ -1,7 +1,7 @@
Contacts
- Phones: [PHONE] or [PHONE]
+ Phones: +1 (555) 123-456-99 or 004412125543
Email: [EMAIL] or [EMAIL]
# /tmp/d20130203-23049-n8mhx/spec.rb:119:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
7) PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
Failure/Error: filter.filtered.should eq filtered
RuntimeError:
can't modify frozen String
# /tmp/d20130203-23049-n8mhx/solution.rb:60:in `gsub!'
# /tmp/d20130203-23049-n8mhx/solution.rb:60:in `filter_email'
# /tmp/d20130203-23049-n8mhx/solution.rb:92:in `filtered'
# /tmp/d20130203-23049-n8mhx/spec.rb:132:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-n8mhx/spec.rb:129:in `each'
# /tmp/d20130203-23049-n8mhx/spec.rb:129:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
8) PrivacyFilter separates preserved country code from filtered phone with a space
Failure/Error: filter.filtered.should eq filtered
RuntimeError:
can't modify frozen String
# /tmp/d20130203-23049-n8mhx/solution.rb:60:in `gsub!'
# /tmp/d20130203-23049-n8mhx/solution.rb:60:in `filter_email'
# /tmp/d20130203-23049-n8mhx/solution.rb:92:in `filtered'
# /tmp/d20130203-23049-n8mhx/spec.rb:144:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-n8mhx/spec.rb:141:in `each'
# /tmp/d20130203-23049-n8mhx/spec.rb:141:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
9) Validations can validate more complex phone numbers
Failure/Error: Validations.phone?(phone).should be(valid)
expected #<FalseClass:0> => false
got #<TrueClass:2> => true
Compared using equal?, which compares object identity,
but expected and actual are not the same object. Use
'actual.should eq(expected)' if you don't care about
object identity in this example.
# /tmp/d20130203-23049-n8mhx/spec.rb:210:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-n8mhx/spec.rb:209:in `each'
# /tmp/d20130203-23049-n8mhx/spec.rb:209:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
10) Validations validates IP addresses
Failure/Error: Validations.ip_address?('0.0.0.0').should be_true
expected: true value
got: false
# /tmp/d20130203-23049-n8mhx/spec.rb:240:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
11) Validations validates more complex numbers
Failure/Error: Validations.number?('00').should be_false
expected: false value
got: true
# /tmp/d20130203-23049-n8mhx/spec.rb:263:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
12) Validations does not allow zero months or days in dates
Failure/Error: Validations.date?('1000-00-01').should be_false
expected: false value
got: true
# /tmp/d20130203-23049-n8mhx/spec.rb:315:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
13) Validations validates datetime values
Failure/Error: Validations.date_time?('2012-00-19T23:59:00').should be_false
expected: false value
got: true
# /tmp/d20130203-23049-n8mhx/spec.rb:352:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
Finished in 0.04926 seconds
41 examples, 13 failures
Failed examples:
rspec /tmp/d20130203-23049-n8mhx/spec.rb:30 # PrivacyFilter obfuscates more complicated emails
rspec /tmp/d20130203-23049-n8mhx/spec.rb:72 # PrivacyFilter does not brake with unicode
rspec /tmp/d20130203-23049-n8mhx/spec.rb:76 # PrivacyFilter filters more complex phone numbers
rspec /tmp/d20130203-23049-n8mhx/spec.rb:89 # PrivacyFilter does not filter invalid phone numbers
rspec /tmp/d20130203-23049-n8mhx/spec.rb:100 # PrivacyFilter preserves whitespace around phones
rspec /tmp/d20130203-23049-n8mhx/spec.rb:104 # PrivacyFilter filters more than one phone or email
rspec /tmp/d20130203-23049-n8mhx/spec.rb:122 # PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
rspec /tmp/d20130203-23049-n8mhx/spec.rb:136 # PrivacyFilter separates preserved country code from filtered phone with a space
rspec /tmp/d20130203-23049-n8mhx/spec.rb:184 # Validations can validate more complex phone numbers
rspec /tmp/d20130203-23049-n8mhx/spec.rb:237 # Validations validates IP addresses
rspec /tmp/d20130203-23049-n8mhx/spec.rb:257 # Validations validates more complex numbers
rspec /tmp/d20130203-23049-n8mhx/spec.rb:314 # Validations does not allow zero months or days in dates
rspec /tmp/d20130203-23049-n8mhx/spec.rb:347 # Validations validates datetime values
История (1 версия и 0 коментара)
Мирослав обнови решението на 28.11.2012 14:55 (преди почти 12 години)