Решение на Четвърта задача от Явор Лилянов
Обратно към всички решения
Към профила на Явор Лилянов
Резултати
- 2 точки от тестове
- 0 бонус точки
- 2 точки общо
- 16 успешни тест(а)
- 25 неуспешни тест(а)
Код
Лог от изпълнението
..F...FFFF.FFF..FF.FFFFFF.FF.FF...F.F.FFF
Failures:
1) PrivacyFilter obfuscates more complicated emails
Failure/Error: PrivacyFilter.new(text).filtered
RuntimeError:
can't modify frozen String
# /tmp/d20130203-23049-cqy1el/solution.rb:33:in `gsub!'
# /tmp/d20130203-23049-cqy1el/solution.rb:33:in `filtered_emails'
# /tmp/d20130203-23049-cqy1el/solution.rb:45:in `filtered'
# /tmp/d20130203-23049-cqy1el/spec.rb:5:in `filter'
# /tmp/d20130203-23049-cqy1el/spec.rb:40:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-cqy1el/spec.rb:39:in `each'
# /tmp/d20130203-23049-cqy1el/spec.rb:39:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
2) PrivacyFilter filters whole email usernames if too short
Failure/Error: partially_filter_email_usernames('me@example.com').should eq '[FILTERED]@example.com'
expected: "[FILTERED]@example.com"
got: "me@example.com"
(compared using ==)
# /tmp/d20130203-23049-cqy1el/spec.rb:69:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
3) PrivacyFilter does not brake with unicode
Failure/Error: partially_filter_email_usernames('За връзка: me@example.com').should eq 'За връзка: [FILTERED]@example.com'
expected: "За връзка: [FILTERED]@example.com"
got: "За връзка: me@example.com"
(compared using ==)
# /tmp/d20130203-23049-cqy1el/spec.rb:73:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
4) PrivacyFilter filters more complex phone numbers
Failure/Error: PrivacyFilter.new(text).filtered
RuntimeError:
can't modify frozen String
# /tmp/d20130203-23049-cqy1el/solution.rb:33:in `gsub!'
# /tmp/d20130203-23049-cqy1el/solution.rb:33:in `filtered_emails'
# /tmp/d20130203-23049-cqy1el/solution.rb:45:in `filtered'
# /tmp/d20130203-23049-cqy1el/spec.rb:5:in `filter'
# /tmp/d20130203-23049-cqy1el/spec.rb:85:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-cqy1el/spec.rb:84:in `each'
# /tmp/d20130203-23049-cqy1el/spec.rb:84:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
5) PrivacyFilter does not filter invalid phone numbers
Failure/Error: PrivacyFilter.new(text).filtered
RuntimeError:
can't modify frozen String
# /tmp/d20130203-23049-cqy1el/solution.rb:33:in `gsub!'
# /tmp/d20130203-23049-cqy1el/solution.rb:33:in `filtered_emails'
# /tmp/d20130203-23049-cqy1el/solution.rb:45:in `filtered'
# /tmp/d20130203-23049-cqy1el/spec.rb:5:in `filter'
# /tmp/d20130203-23049-cqy1el/spec.rb:96:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-cqy1el/spec.rb:95:in `each'
# /tmp/d20130203-23049-cqy1el/spec.rb:95:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
6) PrivacyFilter filters more than one phone or email
Failure/Error: filter(text).should eq filtered
expected: "\n Contacts\n\n Phones: [PHONE] or [PHONE]\n Email: [EMAIL] or [EMAIL]\n "
got: "\n Contacts\n\n Phones: +1 (555) 123-456-99 or [PHONE]\n Email: [EMAIL] or [EMAIL]\n "
(compared using ==)
Diff:
@@ -1,7 +1,7 @@
Contacts
- Phones: [PHONE] or [PHONE]
+ Phones: +1 (555) 123-456-99 or [PHONE]
Email: [EMAIL] or [EMAIL]
# /tmp/d20130203-23049-cqy1el/spec.rb:119:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
7) PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
Failure/Error: filter.filtered.should eq filtered
RuntimeError:
can't modify frozen String
# /tmp/d20130203-23049-cqy1el/solution.rb:33:in `gsub!'
# /tmp/d20130203-23049-cqy1el/solution.rb:33:in `filtered_emails'
# /tmp/d20130203-23049-cqy1el/solution.rb:45:in `filtered'
# /tmp/d20130203-23049-cqy1el/spec.rb:132:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-cqy1el/spec.rb:129:in `each'
# /tmp/d20130203-23049-cqy1el/spec.rb:129:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
8) PrivacyFilter separates preserved country code from filtered phone with a space
Failure/Error: filter.filtered.should eq filtered
RuntimeError:
can't modify frozen String
# /tmp/d20130203-23049-cqy1el/solution.rb:33:in `gsub!'
# /tmp/d20130203-23049-cqy1el/solution.rb:33:in `filtered_emails'
# /tmp/d20130203-23049-cqy1el/solution.rb:45:in `filtered'
# /tmp/d20130203-23049-cqy1el/spec.rb:144:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-cqy1el/spec.rb:141:in `each'
# /tmp/d20130203-23049-cqy1el/spec.rb:141:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
9) Validations can validate more complex emails
Failure/Error: Validations.email?(email).should be(valid)
expected #<FalseClass:0> => false
got #<TrueClass:2> => true
Compared using equal?, which compares object identity,
but expected and actual are not the same object. Use
'actual.should eq(expected)' if you don't care about
object identity in this example.
# /tmp/d20130203-23049-cqy1el/spec.rb:171:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-cqy1el/spec.rb:170:in `each'
# /tmp/d20130203-23049-cqy1el/spec.rb:170:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
10) Validations does not break on emails in multiline strings
Failure/Error: Validations.email?("foo@bar.com\nwat?").should be_false
expected: false value
got: true
# /tmp/d20130203-23049-cqy1el/spec.rb:176:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
11) Validations can validate more complex phone numbers
Failure/Error: Validations.phone?(phone).should be(valid)
expected #<TrueClass:2> => true
got #<FalseClass:0> => false
Compared using equal?, which compares object identity,
but expected and actual are not the same object. Use
'actual.should eq(expected)' if you don't care about
object identity in this example.
# /tmp/d20130203-23049-cqy1el/spec.rb:210:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-cqy1el/spec.rb:209:in `each'
# /tmp/d20130203-23049-cqy1el/spec.rb:209:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
12) Validations does not break on phones in multiline strings
Failure/Error: Validations.phone?("0885123123\nwat?").should be_false
expected: false value
got: true
# /tmp/d20130203-23049-cqy1el/spec.rb:215:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
13) Validations validates hostnames
Failure/Error: Validations.hostname?('x.io').should be_true
expected: true value
got: false
# /tmp/d20130203-23049-cqy1el/spec.rb:223:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
14) Validations handles multiline strings in hostname validation properly
Failure/Error: Validations.hostname?("foo.com\n").should be_false
expected: false value
got: true
# /tmp/d20130203-23049-cqy1el/spec.rb:233:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
15) Validations validates IP addresses
Failure/Error: Validations.ip_address?('300.2.3.4').should be_false
expected: false value
got: true
# /tmp/d20130203-23049-cqy1el/spec.rb:239:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
16) Validations handles multiline strings in IP validation properly
Failure/Error: Validations.ip_address?("8.8.8.8\n").should be_false
expected: false value
got: true
# /tmp/d20130203-23049-cqy1el/spec.rb:245:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
17) Validations validates more complex numbers
Failure/Error: Validations.number?(' 42 ').should be_false
expected: false value
got: true
# /tmp/d20130203-23049-cqy1el/spec.rb:258:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
18) Validations handles multiline strings in numbers validation properly
Failure/Error: Validations.number?("42\n24").should be_false
expected: false value
got: true
# /tmp/d20130203-23049-cqy1el/spec.rb:274:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
19) Validations validates more complex integers
Failure/Error: Validations.integer?(' 42 ').should be_false
expected: false value
got: true
# /tmp/d20130203-23049-cqy1el/spec.rb:284:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
20) Validations handles multiline strings in integer validation properly
Failure/Error: Validations.number?("42\n24").should be_false
expected: false value
got: true
# /tmp/d20130203-23049-cqy1el/spec.rb:295:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
21) Validations does not allow zero months or days in dates
Failure/Error: Validations.date?('1000-00-01').should be_false
expected: false value
got: true
# /tmp/d20130203-23049-cqy1el/spec.rb:315:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
22) Validations handles newlines in date validation
Failure/Error: Validations.date?("2012-11-19\n").should be_false
expected: false value
got: true
# /tmp/d20130203-23049-cqy1el/spec.rb:327:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
23) Validations does not allow invalid hours, minutes or seconds
Failure/Error: Validations.time?(' 12:01:09 ').should be_false
expected: false value
got: true
# /tmp/d20130203-23049-cqy1el/spec.rb:344:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
24) Validations validates datetime values
Failure/Error: Validations.date_time?('2012-00-19T23:59:00').should be_false
expected: false value
got: true
# /tmp/d20130203-23049-cqy1el/spec.rb:352:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
25) Validations handles newlines in time and datetime validation
Failure/Error: Validations.time?("12:01:01\n").should be_false
expected: false value
got: true
# /tmp/d20130203-23049-cqy1el/spec.rb:360:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
Finished in 0.0493 seconds
41 examples, 25 failures
Failed examples:
rspec /tmp/d20130203-23049-cqy1el/spec.rb:30 # PrivacyFilter obfuscates more complicated emails
rspec /tmp/d20130203-23049-cqy1el/spec.rb:68 # PrivacyFilter filters whole email usernames if too short
rspec /tmp/d20130203-23049-cqy1el/spec.rb:72 # PrivacyFilter does not brake with unicode
rspec /tmp/d20130203-23049-cqy1el/spec.rb:76 # PrivacyFilter filters more complex phone numbers
rspec /tmp/d20130203-23049-cqy1el/spec.rb:89 # PrivacyFilter does not filter invalid phone numbers
rspec /tmp/d20130203-23049-cqy1el/spec.rb:104 # PrivacyFilter filters more than one phone or email
rspec /tmp/d20130203-23049-cqy1el/spec.rb:122 # PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
rspec /tmp/d20130203-23049-cqy1el/spec.rb:136 # PrivacyFilter separates preserved country code from filtered phone with a space
rspec /tmp/d20130203-23049-cqy1el/spec.rb:160 # Validations can validate more complex emails
rspec /tmp/d20130203-23049-cqy1el/spec.rb:175 # Validations does not break on emails in multiline strings
rspec /tmp/d20130203-23049-cqy1el/spec.rb:184 # Validations can validate more complex phone numbers
rspec /tmp/d20130203-23049-cqy1el/spec.rb:214 # Validations does not break on phones in multiline strings
rspec /tmp/d20130203-23049-cqy1el/spec.rb:218 # Validations validates hostnames
rspec /tmp/d20130203-23049-cqy1el/spec.rb:232 # Validations handles multiline strings in hostname validation properly
rspec /tmp/d20130203-23049-cqy1el/spec.rb:237 # Validations validates IP addresses
rspec /tmp/d20130203-23049-cqy1el/spec.rb:244 # Validations handles multiline strings in IP validation properly
rspec /tmp/d20130203-23049-cqy1el/spec.rb:257 # Validations validates more complex numbers
rspec /tmp/d20130203-23049-cqy1el/spec.rb:273 # Validations handles multiline strings in numbers validation properly
rspec /tmp/d20130203-23049-cqy1el/spec.rb:283 # Validations validates more complex integers
rspec /tmp/d20130203-23049-cqy1el/spec.rb:294 # Validations handles multiline strings in integer validation properly
rspec /tmp/d20130203-23049-cqy1el/spec.rb:314 # Validations does not allow zero months or days in dates
rspec /tmp/d20130203-23049-cqy1el/spec.rb:326 # Validations handles newlines in date validation
rspec /tmp/d20130203-23049-cqy1el/spec.rb:339 # Validations does not allow invalid hours, minutes or seconds
rspec /tmp/d20130203-23049-cqy1el/spec.rb:347 # Validations validates datetime values
rspec /tmp/d20130203-23049-cqy1el/spec.rb:359 # Validations handles newlines in time and datetime validation
История (1 версия и 0 коментара)
Явор обнови решението на 28.11.2012 15:00 (преди почти 12 години)