Решение на Четвърта задача от Елена Миронова
Обратно към всички решения
Към профила на Елена Миронова
Резултати
- 4 точки от тестове
- 0 бонус точки
- 4 точки общо
- 24 успешни тест(а)
- 17 неуспешни тест(а)
Код
Лог от изпълнението
F.FF.....F.FFF..FF.FF.F.F..F..F.....F...F
Failures:
1) PrivacyFilter works with blank or whitespace strings and preserves whitespace
Failure/Error: filter('').should eq ''
expected: ""
got: nil
(compared using ==)
# /tmp/d20130203-23049-1tdd36s/spec.rb:21:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
2) PrivacyFilter obfuscates more complicated emails
Failure/Error: filter(text).should eq filtered
expected: "Contact: [EMAIL],[EMAIL]"
got: "Contact: [EMAIL],someone.new@sub.example123.co.uk"
(compared using ==)
# /tmp/d20130203-23049-1tdd36s/spec.rb:40:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-1tdd36s/spec.rb:39:in `each'
# /tmp/d20130203-23049-1tdd36s/spec.rb:39:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
3) PrivacyFilter does not filter invalid emails
Failure/Error: filter(text_with_invalid_emails).should eq text_with_invalid_emails
expected: "Contact me here: _invalid@email.com"
got: "Contact me here: _[EMAIL]"
(compared using ==)
# /tmp/d20130203-23049-1tdd36s/spec.rb:52:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-1tdd36s/spec.rb:46:in `each'
# /tmp/d20130203-23049-1tdd36s/spec.rb:46:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
4) PrivacyFilter does not filter invalid phone numbers
Failure/Error: filter(text).should eq filtered
expected: "Reach me at: 0885123"
got: "Reach me at: [PHONE]"
(compared using ==)
# /tmp/d20130203-23049-1tdd36s/spec.rb:96:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-1tdd36s/spec.rb:95:in `each'
# /tmp/d20130203-23049-1tdd36s/spec.rb:95:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
5) PrivacyFilter filters more than one phone or email
Failure/Error: filter(text).should eq filtered
expected: "\n Contacts\n\n Phones: [PHONE] or [PHONE]\n Email: [EMAIL] or [EMAIL]\n "
got: "\n Contacts\n\n Phones: +1 (555) 123-456-99 or 004412125543\n Email: [EMAIL] or sales@office.us\n "
(compared using ==)
Diff:
@@ -1,7 +1,7 @@
Contacts
- Phones: [PHONE] or [PHONE]
- Email: [EMAIL] or [EMAIL]
+ Phones: +1 (555) 123-456-99 or 004412125543
+ Email: [EMAIL] or sales@office.us
# /tmp/d20130203-23049-1tdd36s/spec.rb:119:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
6) PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
Failure/Error: filter.filtered.should eq filtered
expected: "Phone: 0025 [FILTERED]"
got: "Phone: 0025 [FILTERED]5"
(compared using ==)
# /tmp/d20130203-23049-1tdd36s/spec.rb:132:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-1tdd36s/spec.rb:129:in `each'
# /tmp/d20130203-23049-1tdd36s/spec.rb:129:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
7) PrivacyFilter separates preserved country code from filtered phone with a space
Failure/Error: filter.filtered.should eq filtered
expected: "Phone: 0025 [FILTERED]"
got: "Phone: 0025 [FILTERED]5"
(compared using ==)
# /tmp/d20130203-23049-1tdd36s/spec.rb:144:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-1tdd36s/spec.rb:141:in `each'
# /tmp/d20130203-23049-1tdd36s/spec.rb:141:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
8) Validations can validate more complex emails
Failure/Error: Validations.email?(email).should be(valid)
expected #<FalseClass:0> => false
got #<TrueClass:2> => true
Compared using equal?, which compares object identity,
but expected and actual are not the same object. Use
'actual.should eq(expected)' if you don't care about
object identity in this example.
# /tmp/d20130203-23049-1tdd36s/spec.rb:171:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-1tdd36s/spec.rb:170:in `each'
# /tmp/d20130203-23049-1tdd36s/spec.rb:170:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
9) Validations does not break on emails in multiline strings
Failure/Error: Validations.email?("foo@bar.com\nwat?").should be_false
expected: false value
got: true
# /tmp/d20130203-23049-1tdd36s/spec.rb:176:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
10) Validations can validate more complex phone numbers
Failure/Error: Validations.phone?(phone).should be(valid)
expected #<FalseClass:0> => false
got #<TrueClass:2> => true
Compared using equal?, which compares object identity,
but expected and actual are not the same object. Use
'actual.should eq(expected)' if you don't care about
object identity in this example.
# /tmp/d20130203-23049-1tdd36s/spec.rb:210:in `block (3 levels) in <top (required)>'
# /tmp/d20130203-23049-1tdd36s/spec.rb:209:in `each'
# /tmp/d20130203-23049-1tdd36s/spec.rb:209:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
11) Validations does not break on phones in multiline strings
Failure/Error: Validations.phone?("0885123123\nwat?").should be_false
expected: false value
got: true
# /tmp/d20130203-23049-1tdd36s/spec.rb:215:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
12) Validations handles multiline strings in hostname validation properly
Failure/Error: Validations.hostname?("foo.com\n").should be_false
expected: false value
got: true
# /tmp/d20130203-23049-1tdd36s/spec.rb:233:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
13) Validations handles multiline strings in IP validation properly
Failure/Error: Validations.ip_address?("8.8.8.8\n").should be_false
expected: false value
got: true
# /tmp/d20130203-23049-1tdd36s/spec.rb:245:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
14) Validations handles multiline strings in numbers validation properly
Failure/Error: Validations.number?("42\n24").should be_false
expected: false value
got: true
# /tmp/d20130203-23049-1tdd36s/spec.rb:274:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
15) Validations handles multiline strings in integer validation properly
Failure/Error: Validations.number?("42\n24").should be_false
expected: false value
got: true
# /tmp/d20130203-23049-1tdd36s/spec.rb:295:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
16) Validations handles newlines in date validation
Failure/Error: Validations.date?("2012-11-19\n").should be_false
expected: false value
got: true
# /tmp/d20130203-23049-1tdd36s/spec.rb:327:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
17) Validations handles newlines in time and datetime validation
Failure/Error: Validations.time?("12:01:01\n").should be_false
expected: false value
got: true
# /tmp/d20130203-23049-1tdd36s/spec.rb:360:in `block (2 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
# ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'
Finished in 0.05719 seconds
41 examples, 17 failures
Failed examples:
rspec /tmp/d20130203-23049-1tdd36s/spec.rb:20 # PrivacyFilter works with blank or whitespace strings and preserves whitespace
rspec /tmp/d20130203-23049-1tdd36s/spec.rb:30 # PrivacyFilter obfuscates more complicated emails
rspec /tmp/d20130203-23049-1tdd36s/spec.rb:44 # PrivacyFilter does not filter invalid emails
rspec /tmp/d20130203-23049-1tdd36s/spec.rb:89 # PrivacyFilter does not filter invalid phone numbers
rspec /tmp/d20130203-23049-1tdd36s/spec.rb:104 # PrivacyFilter filters more than one phone or email
rspec /tmp/d20130203-23049-1tdd36s/spec.rb:122 # PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
rspec /tmp/d20130203-23049-1tdd36s/spec.rb:136 # PrivacyFilter separates preserved country code from filtered phone with a space
rspec /tmp/d20130203-23049-1tdd36s/spec.rb:160 # Validations can validate more complex emails
rspec /tmp/d20130203-23049-1tdd36s/spec.rb:175 # Validations does not break on emails in multiline strings
rspec /tmp/d20130203-23049-1tdd36s/spec.rb:184 # Validations can validate more complex phone numbers
rspec /tmp/d20130203-23049-1tdd36s/spec.rb:214 # Validations does not break on phones in multiline strings
rspec /tmp/d20130203-23049-1tdd36s/spec.rb:232 # Validations handles multiline strings in hostname validation properly
rspec /tmp/d20130203-23049-1tdd36s/spec.rb:244 # Validations handles multiline strings in IP validation properly
rspec /tmp/d20130203-23049-1tdd36s/spec.rb:273 # Validations handles multiline strings in numbers validation properly
rspec /tmp/d20130203-23049-1tdd36s/spec.rb:294 # Validations handles multiline strings in integer validation properly
rspec /tmp/d20130203-23049-1tdd36s/spec.rb:326 # Validations handles newlines in date validation
rspec /tmp/d20130203-23049-1tdd36s/spec.rb:359 # Validations handles newlines in time and datetime validation
История (1 версия и 0 коментара)
Елена обнови решението на 28.11.2012 15:07 (преди почти 12 години)