Решение на Четвърта задача от Нели Хатева

Обратно към всички решения

Към профила на Нели Хатева

Резултати

  • 3 точки от тестове
  • 0 бонус точки
  • 3 точки общо
  • 20 успешни тест(а)
  • 21 неуспешни тест(а)

Код

class PrivacyFilter
attr_accessor :preserve_phone_country_code, :preserve_email_hostname, :partially_preserve_email_username
def initialize(text)
@filtered_text = text
@preserve_phone_country_code = false
@preserve_email_hostname = false
@partially_preserve_email_username = false
end
def filtered
filter_email
filter_phone
@filtered_text
end
def filter_email
@filtered_text.sub!(/([[:alnum:]]([A-Z0-9\-][^-]){0,61}\.)+[A-Z]{2,3}(\.[A-Z]{2})?/i, "Host")
@filtered_text.sub!(/\b[A-Z0-9][A-Z0-9_+.-]{0,200}@Host/i, "[EMAIL]")
end
def filter_phone
phone = /(0|00|\+[1-9]\d{0,2})(?<phone_number>\d{6,11})/.match @filtered_text
if phone == nil then return
elsif preserve_phone_country_code then @filtered_text.sub!(phone[:phone_number], " [FILTERED]")
else @filtered_text.sub!(/(0|00|\+[1-9]\d{0,2})\d{6,11}/, "[PHONE]")
end
end
end
class Validations
def Validations.email?(value)
if /^[A-Z0-9][A-Z0-9_+.-]{0,200}@[A-Z0-9.-]+\.[A-Z]{2,4}$/i.match value
true
else
false
end
end
def Validations.hostname?(value)
if /^([[:alnum:]]([A-Z0-9\-][^-]){0,62}\.)+[A-Z]{2,3}(\.[A-Z]{2})?$/i.match value
true
else
false
end
end
def Validations.phone?(value)
if /^(0|00|\+[1-9]\d{0,2})\d{6,11}$/.match value
true
else
false
end
end
def Validations.ip_address?(value)
if /^(?:(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){3}(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)$/.match value
true
else
false
end
end
def Validations.number?(value)
if /^\-?(0|[1-9][0-9]*)(\.[0-9]+)?$/.match value
true
else
false
end
end
def Validations.integer?(value)
Validations.number?(value)
if /^\-?(0|[1-9][0-9]*)$/.match value
true
else
false
end
end
def Validations.date?(value)
if /^\d\d\d\d\-(0[1-9]|1[012])\-(0[1-9]|[12][0-9]|3[01])$/.match value
true
else
false
end
end
def Validations.time?(value)
if /^([01][0-9]|2[0-3])(:[0-5][0-9]){2}$/.match value
true
else
false
end
end
def Validations.date_time?(value)
date_and_separator = /^\d\d\d\d\-(0[1-9]|1[012])\-(0[1-9]|[12][0-9]|3[01])( |T)/.match value
remaining_text = date_and_separator.post_match unless date_and_separator == nil
if /^([01][0-9]|2[0-3])(:[0-5][0-9]){2}$/.match remaining_text then true
else
false
end
end
end

Лог от изпълнението

..F.FFFFFFFFFF...F.FFFF.F..F..F.....F...F

Failures:

  1) PrivacyFilter obfuscates more complicated emails
     Failure/Error: PrivacyFilter.new(text).filtered
     RuntimeError:
       can't modify frozen String
     # /tmp/d20130203-23049-t9g66q/solution.rb:18:in `sub!'
     # /tmp/d20130203-23049-t9g66q/solution.rb:18:in `filter_email'
     # /tmp/d20130203-23049-t9g66q/solution.rb:12:in `filtered'
     # /tmp/d20130203-23049-t9g66q/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-t9g66q/spec.rb:40:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-t9g66q/spec.rb:39:in `each'
     # /tmp/d20130203-23049-t9g66q/spec.rb:39:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  2) PrivacyFilter allows email hostname to be preserved
     Failure/Error: filter_email_usernames('someone@example.com').should eq '[FILTERED]@example.com'
       
       expected: "[FILTERED]@example.com"
            got: "[EMAIL]"
       
       (compared using ==)
     # /tmp/d20130203-23049-t9g66q/spec.rb:60:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  3) PrivacyFilter allows email usernames to be partially preserved
     Failure/Error: partially_filter_email_usernames('someone@example.com').should eq 'som[FILTERED]@example.com'
       
       expected: "som[FILTERED]@example.com"
            got: "[EMAIL]"
       
       (compared using ==)
     # /tmp/d20130203-23049-t9g66q/spec.rb:65:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  4) PrivacyFilter filters whole email usernames if too short
     Failure/Error: partially_filter_email_usernames('me@example.com').should eq '[FILTERED]@example.com'
       
       expected: "[FILTERED]@example.com"
            got: "[EMAIL]"
       
       (compared using ==)
     # /tmp/d20130203-23049-t9g66q/spec.rb:69:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  5) PrivacyFilter does not brake with unicode
     Failure/Error: partially_filter_email_usernames('За връзка: me@example.com').should eq 'За връзка: [FILTERED]@example.com'
       
       expected: "За връзка: [FILTERED]@example.com"
            got: "За връзка: [EMAIL]"
       
       (compared using ==)
     # /tmp/d20130203-23049-t9g66q/spec.rb:73:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  6) PrivacyFilter filters more complex phone numbers
     Failure/Error: PrivacyFilter.new(text).filtered
     RuntimeError:
       can't modify frozen String
     # /tmp/d20130203-23049-t9g66q/solution.rb:18:in `sub!'
     # /tmp/d20130203-23049-t9g66q/solution.rb:18:in `filter_email'
     # /tmp/d20130203-23049-t9g66q/solution.rb:12:in `filtered'
     # /tmp/d20130203-23049-t9g66q/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-t9g66q/spec.rb:85:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-t9g66q/spec.rb:84:in `each'
     # /tmp/d20130203-23049-t9g66q/spec.rb:84:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  7) PrivacyFilter does not filter invalid phone numbers
     Failure/Error: PrivacyFilter.new(text).filtered
     RuntimeError:
       can't modify frozen String
     # /tmp/d20130203-23049-t9g66q/solution.rb:18:in `sub!'
     # /tmp/d20130203-23049-t9g66q/solution.rb:18:in `filter_email'
     # /tmp/d20130203-23049-t9g66q/solution.rb:12:in `filtered'
     # /tmp/d20130203-23049-t9g66q/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-t9g66q/spec.rb:96:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-t9g66q/spec.rb:95:in `each'
     # /tmp/d20130203-23049-t9g66q/spec.rb:95:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  8) PrivacyFilter preserves whitespace around phones
     Failure/Error: filter(' +359881212-12-1 2 or...').should eq ' [PHONE] or...'
       
       expected: " [PHONE] or..."
            got: " [PHONE]-12-1 2 or..."
       
       (compared using ==)
     # /tmp/d20130203-23049-t9g66q/spec.rb:101:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  9) PrivacyFilter filters more than one phone or email
     Failure/Error: filter(text).should eq filtered
       
       expected: "\n      Contacts\n\n      Phones: [PHONE] or [PHONE]\n      Email: [EMAIL] or [EMAIL]\n    "
            got: "\n      Contacts\n\n      Phones: +1 (555) 123-456-99 or [PHONE]\n      Email: cHost or sales@office.us\n    "
       
       (compared using ==)
       
       Diff:
       @@ -1,7 +1,7 @@
        
              Contacts
        
       -      Phones: [PHONE] or [PHONE]
       -      Email: [EMAIL] or [EMAIL]
       +      Phones: +1 (555) 123-456-99 or [PHONE]
       +      Email: cHost or sales@office.us
            
     # /tmp/d20130203-23049-t9g66q/spec.rb:119:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  10) PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
     Failure/Error: filter.filtered.should eq filtered
     RuntimeError:
       can't modify frozen String
     # /tmp/d20130203-23049-t9g66q/solution.rb:18:in `sub!'
     # /tmp/d20130203-23049-t9g66q/solution.rb:18:in `filter_email'
     # /tmp/d20130203-23049-t9g66q/solution.rb:12:in `filtered'
     # /tmp/d20130203-23049-t9g66q/spec.rb:132:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-t9g66q/spec.rb:129:in `each'
     # /tmp/d20130203-23049-t9g66q/spec.rb:129:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  11) PrivacyFilter separates preserved country code from filtered phone with a space
     Failure/Error: filter.filtered.should eq filtered
     RuntimeError:
       can't modify frozen String
     # /tmp/d20130203-23049-t9g66q/solution.rb:18:in `sub!'
     # /tmp/d20130203-23049-t9g66q/solution.rb:18:in `filter_email'
     # /tmp/d20130203-23049-t9g66q/solution.rb:12:in `filtered'
     # /tmp/d20130203-23049-t9g66q/spec.rb:144:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-t9g66q/spec.rb:141:in `each'
     # /tmp/d20130203-23049-t9g66q/spec.rb:141:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  12) Validations does not break on emails in multiline strings
     Failure/Error: Validations.email?("foo@bar.com\nwat?").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-t9g66q/spec.rb:176:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  13) Validations can validate more complex phone numbers
     Failure/Error: Validations.phone?(phone).should be(valid)
       
       expected #<TrueClass:2> => true
            got #<FalseClass:0> => false
       
       Compared using equal?, which compares object identity,
       but expected and actual are not the same object. Use
       'actual.should eq(expected)' if you don't care about
       object identity in this example.
     # /tmp/d20130203-23049-t9g66q/spec.rb:210:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-t9g66q/spec.rb:209:in `each'
     # /tmp/d20130203-23049-t9g66q/spec.rb:209:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  14) Validations does not break on phones in multiline strings
     Failure/Error: Validations.phone?("0885123123\nwat?").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-t9g66q/spec.rb:215:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  15) Validations validates hostnames
     Failure/Error: Validations.hostname?('domain.tld').should be_true
       expected: true value
            got: false
     # /tmp/d20130203-23049-t9g66q/spec.rb:219:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  16) Validations handles multiline strings in hostname validation properly
     Failure/Error: Validations.hostname?("foo.com\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-t9g66q/spec.rb:233:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  17) Validations handles multiline strings in IP validation properly
     Failure/Error: Validations.ip_address?("8.8.8.8\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-t9g66q/spec.rb:245:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  18) Validations handles multiline strings in numbers validation properly
     Failure/Error: Validations.number?("42\n24").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-t9g66q/spec.rb:274:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  19) Validations handles multiline strings in integer validation properly
     Failure/Error: Validations.number?("42\n24").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-t9g66q/spec.rb:295:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  20) Validations handles newlines in date validation
     Failure/Error: Validations.date?("2012-11-19\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-t9g66q/spec.rb:327:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  21) Validations handles newlines in time and datetime validation
     Failure/Error: Validations.time?("12:01:01\n").should be_false
       expected: false value
            got: true
     # /tmp/d20130203-23049-t9g66q/spec.rb:360:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

Finished in 0.05258 seconds
41 examples, 21 failures

Failed examples:

rspec /tmp/d20130203-23049-t9g66q/spec.rb:30 # PrivacyFilter obfuscates more complicated emails
rspec /tmp/d20130203-23049-t9g66q/spec.rb:59 # PrivacyFilter allows email hostname to be preserved
rspec /tmp/d20130203-23049-t9g66q/spec.rb:64 # PrivacyFilter allows email usernames to be partially preserved
rspec /tmp/d20130203-23049-t9g66q/spec.rb:68 # PrivacyFilter filters whole email usernames if too short
rspec /tmp/d20130203-23049-t9g66q/spec.rb:72 # PrivacyFilter does not brake with unicode
rspec /tmp/d20130203-23049-t9g66q/spec.rb:76 # PrivacyFilter filters more complex phone numbers
rspec /tmp/d20130203-23049-t9g66q/spec.rb:89 # PrivacyFilter does not filter invalid phone numbers
rspec /tmp/d20130203-23049-t9g66q/spec.rb:100 # PrivacyFilter preserves whitespace around phones
rspec /tmp/d20130203-23049-t9g66q/spec.rb:104 # PrivacyFilter filters more than one phone or email
rspec /tmp/d20130203-23049-t9g66q/spec.rb:122 # PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
rspec /tmp/d20130203-23049-t9g66q/spec.rb:136 # PrivacyFilter separates preserved country code from filtered phone with a space
rspec /tmp/d20130203-23049-t9g66q/spec.rb:175 # Validations does not break on emails in multiline strings
rspec /tmp/d20130203-23049-t9g66q/spec.rb:184 # Validations can validate more complex phone numbers
rspec /tmp/d20130203-23049-t9g66q/spec.rb:214 # Validations does not break on phones in multiline strings
rspec /tmp/d20130203-23049-t9g66q/spec.rb:218 # Validations validates hostnames
rspec /tmp/d20130203-23049-t9g66q/spec.rb:232 # Validations handles multiline strings in hostname validation properly
rspec /tmp/d20130203-23049-t9g66q/spec.rb:244 # Validations handles multiline strings in IP validation properly
rspec /tmp/d20130203-23049-t9g66q/spec.rb:273 # Validations handles multiline strings in numbers validation properly
rspec /tmp/d20130203-23049-t9g66q/spec.rb:294 # Validations handles multiline strings in integer validation properly
rspec /tmp/d20130203-23049-t9g66q/spec.rb:326 # Validations handles newlines in date validation
rspec /tmp/d20130203-23049-t9g66q/spec.rb:359 # Validations handles newlines in time and datetime validation

История (1 версия и 0 коментара)

Нели обнови решението на 28.11.2012 16:37 (преди почти 12 години)

+class PrivacyFilter
+ attr_accessor :preserve_phone_country_code, :preserve_email_hostname, :partially_preserve_email_username
+
+ def initialize(text)
+ @filtered_text = text
+ @preserve_phone_country_code = false
+ @preserve_email_hostname = false
+ @partially_preserve_email_username = false
+ end
+
+ def filtered
+ filter_email
+ filter_phone
+ @filtered_text
+ end
+
+ def filter_email
+ @filtered_text.sub!(/([[:alnum:]]([A-Z0-9\-][^-]){0,61}\.)+[A-Z]{2,3}(\.[A-Z]{2})?/i, "Host")
+ @filtered_text.sub!(/\b[A-Z0-9][A-Z0-9_+.-]{0,200}@Host/i, "[EMAIL]")
+ end
+
+ def filter_phone
+ phone = /(0|00|\+[1-9]\d{0,2})(?<phone_number>\d{6,11})/.match @filtered_text
+ if phone == nil then return
+ elsif preserve_phone_country_code then @filtered_text.sub!(phone[:phone_number], " [FILTERED]")
+ else @filtered_text.sub!(/(0|00|\+[1-9]\d{0,2})\d{6,11}/, "[PHONE]")
+ end
+ end
+end
+
+class Validations
+ def Validations.email?(value)
+ if /^[A-Z0-9][A-Z0-9_+.-]{0,200}@[A-Z0-9.-]+\.[A-Z]{2,4}$/i.match value
+ true
+ else
+ false
+ end
+ end
+
+ def Validations.hostname?(value)
+ if /^([[:alnum:]]([A-Z0-9\-][^-]){0,62}\.)+[A-Z]{2,3}(\.[A-Z]{2})?$/i.match value
+ true
+ else
+ false
+ end
+ end
+
+ def Validations.phone?(value)
+ if /^(0|00|\+[1-9]\d{0,2})\d{6,11}$/.match value
+ true
+ else
+ false
+ end
+ end
+
+ def Validations.ip_address?(value)
+ if /^(?:(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){3}(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)$/.match value
+ true
+ else
+ false
+ end
+ end
+
+ def Validations.number?(value)
+ if /^\-?(0|[1-9][0-9]*)(\.[0-9]+)?$/.match value
+ true
+ else
+ false
+ end
+ end
+
+ def Validations.integer?(value)
+ Validations.number?(value)
+ if /^\-?(0|[1-9][0-9]*)$/.match value
+ true
+ else
+ false
+ end
+ end
+
+ def Validations.date?(value)
+ if /^\d\d\d\d\-(0[1-9]|1[012])\-(0[1-9]|[12][0-9]|3[01])$/.match value
+ true
+ else
+ false
+ end
+ end
+
+ def Validations.time?(value)
+ if /^([01][0-9]|2[0-3])(:[0-5][0-9]){2}$/.match value
+ true
+ else
+ false
+ end
+ end
+
+ def Validations.date_time?(value)
+ date_and_separator = /^\d\d\d\d\-(0[1-9]|1[012])\-(0[1-9]|[12][0-9]|3[01])( |T)/.match value
+ remaining_text = date_and_separator.post_match unless date_and_separator == nil
+ if /^([01][0-9]|2[0-3])(:[0-5][0-9]){2}$/.match remaining_text then true
+ else
+ false
+ end
+ end
+end