Решение на Четвърта задача от Тихомир Янев

Обратно към всички решения

Към профила на Тихомир Янев

Резултати

  • 1 точка от тестове
  • 0 бонус точки
  • 1 точка общо
  • 5 успешни тест(а)
  • 36 неуспешни тест(а)

Код

class Pattern
def self.user_name
/[a-zA-Z0-9][\.\+\-a-zA-Z0-9_]{,200}/
end
def self.host
/([a-zA-Z0-9])[\-a-zA-Z0-9]{,61}\g<1>(\.[a-zA-Z]{2,3})\g<2>?/
end
def self.phone
/(0|(\+|00)[1-9][0-9]{0,2})([\s\-\(\)]{0,2}[0-9]){6,11}/
end
def self.ip_address
/([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])(\.\g<1>){3}}/
end
def self.number
/\-?(0|[1-9][0-9]+)\.?[0-9]+/
end
def self.integer
/\-?(0|[1-9][0-9]+)/
end
def self.date
/[0-9]{4}\-(0[1-9]|1[0-2])\-(0[1-9]|[1-2][0-9]|3[01])/
end
def self.time
/([0-1][0-9]|2[0-3])(:[0-5][0-9]){2}/
end
def self.concat(pattern_1, pattern_2, string = '')
Regexp.new(pattern_1.to_s + string + pattern_2.to_s)
end
end
class Validation
def self.email? (value)
return false unless value.include? '@'
user_name, host_name = value.split('@')
Pattern.user_name =~ user_name and self.host? host_name
end
def self.host? (value)
Pattern.host =~ value
end
def self.phone? (value)
Pattern.phone =~ value
end
def self.ip_address? (value)
Pattern.ip_address =~ value
end
def self.number? (value)
Pattern.number =~ value
end
def self.integer? (value)
Pattern.integer =~ value
end
def self.date? (value)
Pattern.date =~ value
end
def self.time? (value)
Pattern.time =~ value
end
def self.date_time? (value)
self.date? value[0, 10] and self.time? value[-8, 8]
end
end
class PrivacyFilter
attr_writer :preserve_phone_country_code,
:preserve_email_hostname,
:partially_preserve_email_username
def initialize(text)
@preserve_phone_country_code,
@preserve_email_hostname,
@partially_preserve_email_username,
@text, @filter_string = false, false, false, text, '[FILTERED]'
end
def filtered
@partially_preserve_email_username or @preserve_email_hostname ? email_filter : simple_email_filter
@preserve_phone_country_code ? phone_filter : simple_phone_filter
@text
end
def email_filter
@text.gsub!(Pattern.concat(Pattern.user_name, Pattern.host, '@')) do |match|
email = match.split('@')
filtered_email = @filter_string << '@' << email[1]
email[0][0, 3] << filtered_email if @partially_preserve_email_username and email[0].size > 5
end
end
def phone_filter
@text.gsub!(Pattern.phone) do |match|
size = match[0, 2] == '00' ? 5 : 4 # ugly, stupid and even...incorrect!
match[0, size] << @filter_string unless /\A0[\s\-\(\)1-9]/ =~ match
end
end
def simple_email_filter
@text.gsub!(Regexp.new(Pattern.user_name.to_s + '@' + Pattern.host.to_s), '[EMAIL]')
end
def simple_phone_filter
@text.gsub!(Pattern.phone, '[PHONE]')
end
end

Лог от изпълнението

..F.FFFFFF..FFFFFFFFFFFFFFFFFFFFFFFFFFFFF

Failures:

  1) PrivacyFilter obfuscates more complicated emails
     Failure/Error: PrivacyFilter.new(text).filtered
     RuntimeError:
       can't modify frozen String
     # /tmp/d20130203-23049-2qqrun/solution.rb:113:in `gsub!'
     # /tmp/d20130203-23049-2qqrun/solution.rb:113:in `simple_email_filter'
     # /tmp/d20130203-23049-2qqrun/solution.rb:92:in `filtered'
     # /tmp/d20130203-23049-2qqrun/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-2qqrun/spec.rb:40:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-2qqrun/spec.rb:39:in `each'
     # /tmp/d20130203-23049-2qqrun/spec.rb:39:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  2) PrivacyFilter allows email hostname to be preserved
     Failure/Error: filter_email_usernames('someone@example.com').should eq '[FILTERED]@example.com'
       
       expected: "[FILTERED]@example.com"
            got: ""
       
       (compared using ==)
     # /tmp/d20130203-23049-2qqrun/spec.rb:60:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  3) PrivacyFilter allows email usernames to be partially preserved
     Failure/Error: partially_filter_email_usernames('someone@example.com').should eq 'som[FILTERED]@example.com'
       
       expected: "som[FILTERED]@example.com"
            got: "someone@example.com"
       
       (compared using ==)
     # /tmp/d20130203-23049-2qqrun/spec.rb:65:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  4) PrivacyFilter filters whole email usernames if too short
     Failure/Error: partially_filter_email_usernames('me@example.com').should eq '[FILTERED]@example.com'
       
       expected: "[FILTERED]@example.com"
            got: "me@example.com"
       
       (compared using ==)
     # /tmp/d20130203-23049-2qqrun/spec.rb:69:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  5) PrivacyFilter does not brake with unicode
     Failure/Error: partially_filter_email_usernames('За връзка: me@example.com').should eq 'За връзка: [FILTERED]@example.com'
       
       expected: "За връзка: [FILTERED]@example.com"
            got: "За връзка: me@example.com"
       
       (compared using ==)
     # /tmp/d20130203-23049-2qqrun/spec.rb:73:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  6) PrivacyFilter filters more complex phone numbers
     Failure/Error: PrivacyFilter.new(text).filtered
     RuntimeError:
       can't modify frozen String
     # /tmp/d20130203-23049-2qqrun/solution.rb:113:in `gsub!'
     # /tmp/d20130203-23049-2qqrun/solution.rb:113:in `simple_email_filter'
     # /tmp/d20130203-23049-2qqrun/solution.rb:92:in `filtered'
     # /tmp/d20130203-23049-2qqrun/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-2qqrun/spec.rb:85:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-2qqrun/spec.rb:84:in `each'
     # /tmp/d20130203-23049-2qqrun/spec.rb:84:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  7) PrivacyFilter does not filter invalid phone numbers
     Failure/Error: PrivacyFilter.new(text).filtered
     RuntimeError:
       can't modify frozen String
     # /tmp/d20130203-23049-2qqrun/solution.rb:113:in `gsub!'
     # /tmp/d20130203-23049-2qqrun/solution.rb:113:in `simple_email_filter'
     # /tmp/d20130203-23049-2qqrun/solution.rb:92:in `filtered'
     # /tmp/d20130203-23049-2qqrun/spec.rb:5:in `filter'
     # /tmp/d20130203-23049-2qqrun/spec.rb:96:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-2qqrun/spec.rb:95:in `each'
     # /tmp/d20130203-23049-2qqrun/spec.rb:95:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  8) PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
     Failure/Error: filter.filtered.should eq filtered
     RuntimeError:
       can't modify frozen String
     # /tmp/d20130203-23049-2qqrun/solution.rb:113:in `gsub!'
     # /tmp/d20130203-23049-2qqrun/solution.rb:113:in `simple_email_filter'
     # /tmp/d20130203-23049-2qqrun/solution.rb:92:in `filtered'
     # /tmp/d20130203-23049-2qqrun/spec.rb:132:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-2qqrun/spec.rb:129:in `each'
     # /tmp/d20130203-23049-2qqrun/spec.rb:129:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  9) PrivacyFilter separates preserved country code from filtered phone with a space
     Failure/Error: filter.filtered.should eq filtered
     RuntimeError:
       can't modify frozen String
     # /tmp/d20130203-23049-2qqrun/solution.rb:113:in `gsub!'
     # /tmp/d20130203-23049-2qqrun/solution.rb:113:in `simple_email_filter'
     # /tmp/d20130203-23049-2qqrun/solution.rb:92:in `filtered'
     # /tmp/d20130203-23049-2qqrun/spec.rb:144:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-2qqrun/spec.rb:141:in `each'
     # /tmp/d20130203-23049-2qqrun/spec.rb:141:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  10) Validations allows validation for emails
     Failure/Error: Validations.email?('foo@bar.com').should be_true
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:151:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  11) Validations returns boolean true or false
     Failure/Error: Validations.email?('foo@bar.com').should be(true)
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:156:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  12) Validations can validate more complex emails
     Failure/Error: Validations.email?(email).should be(valid)
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:171:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-2qqrun/spec.rb:170:in `each'
     # /tmp/d20130203-23049-2qqrun/spec.rb:170:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  13) Validations does not break on emails in multiline strings
     Failure/Error: Validations.email?("foo@bar.com\nwat?").should be_false
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:176:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  14) Validations validates phone numbers
     Failure/Error: Validations.phone?('+35929555111').should be_true
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:180:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  15) Validations can validate more complex phone numbers
     Failure/Error: Validations.phone?(phone).should be(valid)
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:210:in `block (3 levels) in <top (required)>'
     # /tmp/d20130203-23049-2qqrun/spec.rb:209:in `each'
     # /tmp/d20130203-23049-2qqrun/spec.rb:209:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  16) Validations does not break on phones in multiline strings
     Failure/Error: Validations.phone?("0885123123\nwat?").should be_false
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:215:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  17) Validations validates hostnames
     Failure/Error: Validations.hostname?('domain.tld').should be_true
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:219:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  18) Validations handles multiline strings in hostname validation properly
     Failure/Error: Validations.hostname?("foo.com\n").should be_false
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:233:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  19) Validations validates IP addresses
     Failure/Error: Validations.ip_address?('1.2.3.4').should be_true
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:238:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  20) Validations handles multiline strings in IP validation properly
     Failure/Error: Validations.ip_address?("8.8.8.8\n").should be_false
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:245:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  21) Validations validates numbers
     Failure/Error: Validations.number?('42').should be_true
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:251:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  22) Validations validates more complex numbers
     Failure/Error: Validations.number?(' 42 ').should be_false
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:258:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  23) Validations handles multiline strings in numbers validation properly
     Failure/Error: Validations.number?("42\n24").should be_false
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:274:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  24) Validations validates integers
     Failure/Error: Validations.integer?('42').should be_true
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:279:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  25) Validations validates more complex integers
     Failure/Error: Validations.integer?(' 42 ').should be_false
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:284:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  26) Validations handles multiline strings in integer validation properly
     Failure/Error: Validations.number?("42\n24").should be_false
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:295:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  27) Validations validates dates
     Failure/Error: Validations.date?('2012-11-19').should be_true
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:300:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  28) Validations allows zero years in date validation
     Failure/Error: Validations.date?('0000-01-01').should be_true
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:307:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  29) Validations allows huge years in date validation
     Failure/Error: Validations.date?('9999-01-01').should be_true
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:311:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  30) Validations does not allow zero months or days in dates
     Failure/Error: Validations.date?('1000-00-01').should be_false
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:315:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  31) Validations does not allow invalid months or days in dates
     Failure/Error: Validations.date?('2012-13-01').should be_false
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:321:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  32) Validations handles newlines in date validation
     Failure/Error: Validations.date?("2012-11-19\n").should be_false
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:327:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  33) Validations validates times
     Failure/Error: Validations.time?('12:00:00').should be_true
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:332:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  34) Validations does not allow invalid hours, minutes or seconds
     Failure/Error: Validations.time?('24:00:00').should be_false
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:340:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  35) Validations validates datetime values
     Failure/Error: Validations.date_time?('2012-11-19 19:00:00').should be_true
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:348:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  36) Validations handles newlines in time and datetime validation
     Failure/Error: Validations.time?("12:01:01\n").should be_false
     NameError:
       uninitialized constant Validations
     # /tmp/d20130203-23049-2qqrun/spec.rb:360:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

Finished in 0.058 seconds
41 examples, 36 failures

Failed examples:

rspec /tmp/d20130203-23049-2qqrun/spec.rb:30 # PrivacyFilter obfuscates more complicated emails
rspec /tmp/d20130203-23049-2qqrun/spec.rb:59 # PrivacyFilter allows email hostname to be preserved
rspec /tmp/d20130203-23049-2qqrun/spec.rb:64 # PrivacyFilter allows email usernames to be partially preserved
rspec /tmp/d20130203-23049-2qqrun/spec.rb:68 # PrivacyFilter filters whole email usernames if too short
rspec /tmp/d20130203-23049-2qqrun/spec.rb:72 # PrivacyFilter does not brake with unicode
rspec /tmp/d20130203-23049-2qqrun/spec.rb:76 # PrivacyFilter filters more complex phone numbers
rspec /tmp/d20130203-23049-2qqrun/spec.rb:89 # PrivacyFilter does not filter invalid phone numbers
rspec /tmp/d20130203-23049-2qqrun/spec.rb:122 # PrivacyFilter allows country code to be preserved for internationally-formatted phone numbers
rspec /tmp/d20130203-23049-2qqrun/spec.rb:136 # PrivacyFilter separates preserved country code from filtered phone with a space
rspec /tmp/d20130203-23049-2qqrun/spec.rb:150 # Validations allows validation for emails
rspec /tmp/d20130203-23049-2qqrun/spec.rb:155 # Validations returns boolean true or false
rspec /tmp/d20130203-23049-2qqrun/spec.rb:160 # Validations can validate more complex emails
rspec /tmp/d20130203-23049-2qqrun/spec.rb:175 # Validations does not break on emails in multiline strings
rspec /tmp/d20130203-23049-2qqrun/spec.rb:179 # Validations validates phone numbers
rspec /tmp/d20130203-23049-2qqrun/spec.rb:184 # Validations can validate more complex phone numbers
rspec /tmp/d20130203-23049-2qqrun/spec.rb:214 # Validations does not break on phones in multiline strings
rspec /tmp/d20130203-23049-2qqrun/spec.rb:218 # Validations validates hostnames
rspec /tmp/d20130203-23049-2qqrun/spec.rb:232 # Validations handles multiline strings in hostname validation properly
rspec /tmp/d20130203-23049-2qqrun/spec.rb:237 # Validations validates IP addresses
rspec /tmp/d20130203-23049-2qqrun/spec.rb:244 # Validations handles multiline strings in IP validation properly
rspec /tmp/d20130203-23049-2qqrun/spec.rb:250 # Validations validates numbers
rspec /tmp/d20130203-23049-2qqrun/spec.rb:257 # Validations validates more complex numbers
rspec /tmp/d20130203-23049-2qqrun/spec.rb:273 # Validations handles multiline strings in numbers validation properly
rspec /tmp/d20130203-23049-2qqrun/spec.rb:278 # Validations validates integers
rspec /tmp/d20130203-23049-2qqrun/spec.rb:283 # Validations validates more complex integers
rspec /tmp/d20130203-23049-2qqrun/spec.rb:294 # Validations handles multiline strings in integer validation properly
rspec /tmp/d20130203-23049-2qqrun/spec.rb:299 # Validations validates dates
rspec /tmp/d20130203-23049-2qqrun/spec.rb:306 # Validations allows zero years in date validation
rspec /tmp/d20130203-23049-2qqrun/spec.rb:310 # Validations allows huge years in date validation
rspec /tmp/d20130203-23049-2qqrun/spec.rb:314 # Validations does not allow zero months or days in dates
rspec /tmp/d20130203-23049-2qqrun/spec.rb:320 # Validations does not allow invalid months or days in dates
rspec /tmp/d20130203-23049-2qqrun/spec.rb:326 # Validations handles newlines in date validation
rspec /tmp/d20130203-23049-2qqrun/spec.rb:331 # Validations validates times
rspec /tmp/d20130203-23049-2qqrun/spec.rb:339 # Validations does not allow invalid hours, minutes or seconds
rspec /tmp/d20130203-23049-2qqrun/spec.rb:347 # Validations validates datetime values
rspec /tmp/d20130203-23049-2qqrun/spec.rb:359 # Validations handles newlines in time and datetime validation

История (2 версии и 1 коментар)

Тихомир обнови решението на 28.11.2012 03:18 (преди над 11 години)

+class Pattern
+ def self.user_name
+ /[a-zA-Z0-9][\.\+\-a-zA-Z0-9_]{,200}/
+ end
+
+ def self.host
+ /([a-zA-Z0-9])[\-a-zA-Z0-9]{,61}\g<1>(\.[a-zA-Z]{2,3})\g<2>?/
+ end
+
+ def self.phone
+ /(0|(\+|00)[1-9][0-9]{0,2})([\s\-\(\)]{0,2}[0-9]){6,11}/
+ end
+
+ def self.ip_address
+ /([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])(\.\g<1>){3}}/
+ end
+
+ def self.number
+ /\-?(0|[1-9][0-9]+)\.?[0-9]+/
+ end
+
+ def self.integer
+ /\-?(0|[1-9][0-9]+)/
+ end
+
+ def self.date
+ /[0-9]{4}\-(0[1-9]|1[0-2])\-(0[1-9]|[1-2][0-9]|3[01])/
+ end
+
+ def self.time
+ /([0-1][0-9]|2[0-3])(:[0-5][0-9]){2}/
+ end
+end
+
+class Validation
+ def self.email? (value)
+ return false unless value.include? '@'
+ user_name, host_name = value.split('@')
+ Pattern.user_name =~ user_name and self.host? host_name
+ end
+
+ def self.host? (value)
+ Pattern.host =~ value
+ end
+
+ def self.phone? (value)
+ Pattern.phone =~ value
+ end
+
+ def self.ip_address? (value)
+ Pattern.ip_address =~ value
+ end
+
+ def self.number? (value)
+ Pattern.number =~ value
+ end
+
+ def self.integer? (value)
+ Pattern.integer =~ value
+ end
+
+ def self.date? (value)
+ Pattern.date =~ value
+ end
+
+ def self.time? (value)
+ Pattern.time =~ value
+ end
+
+ def self.date_time? (value)
+ self.date? value[0, 10] and self.time? value[-8, 8]
+ end
+end
+
+class PrivacyFilter
+ attr_writer :preserve_phone_country_code,
+ :preserve_email_hostname,
+ :partially_preserve_email_username
+
+ def initialize(text)
+ @preserve_phone_country_code,
+ @preserve_email_hostname,
+ @partially_preserve_email_username,
+ @text, @filter_string = false, false, false, text, '[FILTERED]'
+ end
+
+ def filtered
+ @partially_preserve_email_username or @preserve_email_hostname ? email_filter : simple_email_filter
+ @preserve_phone_country_code ? phone_filter : simple_phone_filter
+ @text
+ end
+
+ def email_filter
+ @text.gsub!(Regexp.new(Pattern.user_name.to_s + '@' + Pattern.host.to_s)) do |match|
+ email = match.split('@')
+ filtered_email = @filter_string << '@' << email[1]
+ email[0][0, 3] << filtered_email if @partially_preserve_email_username and email[0].size > 5
+ end
+ end
+
+ def phone_filter
+ @text.gsub!(Pattern.phone) do |match|
+ size = match[0, 2] == '00' ? 5 : 4 # ugly, stupid and even...incorrect!
+ match[0, size] << @filter_string unless /\A0[\s\-\(\)1-9]/ =~ match
+ end
+ end
+
+ def simple_email_filter
+ @text.gsub!(Regexp.new(Pattern.user_name.to_s + '@' + Pattern.host.to_s), '[EMAIL]')
+ end
+
+ def simple_phone_filter
+ @text.gsub!(Pattern.phone, '[PHONE]')
+ end
+end

Не мога да не отбележа, че в класа Validation имам голямо количество повтарящ се код. Първоначалната ми идея беше да ги реализирам чрез alias и да ги викам с Pattern.send(variable), но честно казано вече не помня защо се отказах (дали защото още съм буден?)

Тихомир обнови решението на 28.11.2012 16:45 (преди над 11 години)

class Pattern
def self.user_name
/[a-zA-Z0-9][\.\+\-a-zA-Z0-9_]{,200}/
end
def self.host
/([a-zA-Z0-9])[\-a-zA-Z0-9]{,61}\g<1>(\.[a-zA-Z]{2,3})\g<2>?/
end
def self.phone
/(0|(\+|00)[1-9][0-9]{0,2})([\s\-\(\)]{0,2}[0-9]){6,11}/
end
def self.ip_address
/([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])(\.\g<1>){3}}/
end
def self.number
/\-?(0|[1-9][0-9]+)\.?[0-9]+/
end
def self.integer
/\-?(0|[1-9][0-9]+)/
end
def self.date
/[0-9]{4}\-(0[1-9]|1[0-2])\-(0[1-9]|[1-2][0-9]|3[01])/
end
def self.time
/([0-1][0-9]|2[0-3])(:[0-5][0-9]){2}/
end
+
+ def self.concat(pattern_1, pattern_2, string = '')
+ Regexp.new(pattern_1.to_s + string + pattern_2.to_s)
+ end
end
class Validation
def self.email? (value)
return false unless value.include? '@'
user_name, host_name = value.split('@')
Pattern.user_name =~ user_name and self.host? host_name
end
def self.host? (value)
Pattern.host =~ value
end
def self.phone? (value)
Pattern.phone =~ value
end
def self.ip_address? (value)
Pattern.ip_address =~ value
end
def self.number? (value)
Pattern.number =~ value
end
def self.integer? (value)
Pattern.integer =~ value
end
def self.date? (value)
Pattern.date =~ value
end
def self.time? (value)
Pattern.time =~ value
end
def self.date_time? (value)
self.date? value[0, 10] and self.time? value[-8, 8]
end
end
class PrivacyFilter
attr_writer :preserve_phone_country_code,
:preserve_email_hostname,
:partially_preserve_email_username
def initialize(text)
@preserve_phone_country_code,
@preserve_email_hostname,
@partially_preserve_email_username,
@text, @filter_string = false, false, false, text, '[FILTERED]'
end
def filtered
@partially_preserve_email_username or @preserve_email_hostname ? email_filter : simple_email_filter
@preserve_phone_country_code ? phone_filter : simple_phone_filter
@text
end
def email_filter
- @text.gsub!(Regexp.new(Pattern.user_name.to_s + '@' + Pattern.host.to_s)) do |match|
+ @text.gsub!(Pattern.concat(Pattern.user_name, Pattern.host, '@')) do |match|
email = match.split('@')
filtered_email = @filter_string << '@' << email[1]
email[0][0, 3] << filtered_email if @partially_preserve_email_username and email[0].size > 5
end
end
def phone_filter
@text.gsub!(Pattern.phone) do |match|
size = match[0, 2] == '00' ? 5 : 4 # ugly, stupid and even...incorrect!
match[0, size] << @filter_string unless /\A0[\s\-\(\)1-9]/ =~ match
end
end
def simple_email_filter
@text.gsub!(Regexp.new(Pattern.user_name.to_s + '@' + Pattern.host.to_s), '[EMAIL]')
end
def simple_phone_filter
@text.gsub!(Pattern.phone, '[PHONE]')
end
end